454394322a
Add a check for nil secrets
...
Improve the error message if
secrets are not provided in request
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit b8568a5bb9
)
2019-09-27 18:05:33 +05:30
756a650cd1
Remove rootfs from rbd provisioner pod
...
rootfs dependency was removed from rbd
by removing support for `nsenter`, This
PR removed the `/` mount from provisioner
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit 3d0cba1931
)
2019-09-27 18:04:00 +05:30
e5904485a3
refactor: Merge 1.13 and 1.14 Helm charts and improve charts
...
Signed-off-by: wilmardo <info@wilmardenouden.nl >
(cherry picked from commit afda225d75
)
2019-09-27 10:44:17 +00:00
68a276677e
change v1.2.1 to v1.2-canary
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-27 09:53:07 +05:30
ecac134c38
Added E2E for rbd nodeplugin restart
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit 3f8a073258
)
v1.2.1
2019-09-25 15:40:51 +05:30
74852cf230
deprecate containerized flag and remove nsenter
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit d2fd76a9a5
)
2019-09-25 15:40:51 +05:30
64fd06825a
tempate changes for containerized flag removal
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit e0264da49a
)
2019-09-25 15:40:51 +05:30
c1e374fae7
Remove nsenter packages from vendor
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit 0ff5026bbe
)
2019-09-25 15:40:51 +05:30
ccdb23297d
We were defaulting to ext4 at first and then moved toxfs.
...
However further testing shows that, ext4 should be
the default or preferred fs for RBD devices.
This patch bring that change
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
(cherry picked from commit b44a81bdbc
)
2019-09-25 14:17:19 +05:30
a5896ba633
Merge pull request #636 from humblec/discard
...
Format RBD volumes with `nodiscard` formatting options.
2019-09-25 14:05:06 +05:30
488050d573
Merge pull request #638 from Madhu-1/update-template
...
Update templates for 1.2.1
2019-09-25 13:56:00 +05:30
80447caea3
update readme with 1.2.1 details
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-25 10:22:31 +05:30
d767d0fa48
update cephcsi image version to 1.2.1
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-25 10:22:31 +05:30
f9dc39973f
Merge pull request #637 from Madhu-1/change-img-tag
...
Push cephcsi 1.2.1 image
2019-09-25 10:21:38 +05:30
f535e503c2
Push cephcsi 1.2.1 image
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-25 09:54:18 +05:30
d1c8cce659
Format RBD volumes with nodiscard
formatting options.
...
Currently rbd CSI plugin uses formatAndMount of
mount.SafeFormatAndMount. This does not allow to pass or use
specific formatting arguments with it. This patch introduce
RBD specific formatting options with both xfs and ext4,
for example: -E no-discard with ext4 and -k option with
XFS to boost formatting performance of RBD device.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
(cherry picked from commit 0e6617e1ff
)
2019-09-24 14:41:36 +05:30
61db816a89
connect to provisioner socket
...
Fixes : #619
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit e2890a27ff
)
2019-09-23 13:16:17 +00:00
1ae09be924
Change the logic of locking
...
if any on going opearation is seen,we
have to return Abort error message
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit 6aac399075
)
2019-09-23 12:38:51 +00:00
cbd42a2181
use rook v1.1.0 in E2E testing
...
rook master is not good enough to
depend on for E2E testing, swithing to v1.1.0
for E2E
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
(cherry picked from commit 18151e9ca8
)
2019-09-23 09:10:18 +00:00
e3e8afc0d8
push v1.2-canary image
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-12 07:16:35 +00:00
c420ee6de9
Merge pull request #596 from Madhu-1/fix-img-push
...
Fix readme
v1.2.0
2019-09-06 22:39:06 +05:30
7bcb33a2e9
Fix readme
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-06 22:18:32 +05:30
404a272e82
Merge pull request #590 from Madhu-1/update-img
...
Prepare for v1.2.0
2019-09-06 22:11:39 +05:30
51e4469878
update canary to v1.2.0 in helm chat
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-06 22:08:49 +05:30
9168a5ee09
update canary to v1.2.0 to push cephcsi image
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-06 22:08:49 +05:30
5e5b396db2
update image versions from canary to v1.2.0
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-06 22:08:49 +05:30
99e81e6b61
Merge pull request #594 from Madhu-1/cherrypick-vol
...
Add mount option for Cephfs
2019-09-06 22:08:01 +05:30
82b85d536f
Add mount option for Cephfs
...
The storage class already takes MountOptions(MountFlags), these are the
bind mount options. Some of these options may not be recognised by the
cephfs mount. Hence added a new parameterin Storage Class for
- cephfs kernel mount options,
- ceph-fuse mount options
Ceph kernel mount options are different from ceph-fuse options, hence
added two different parameters.
Signed-off-by: Poornima G <pgurusid@redhat.com >
2019-09-06 22:03:31 +05:30
b38496793e
Merge pull request #592 from Madhu-1/cherry-pick-liv
...
Fix liveness connection opening endless sockets
2019-09-06 21:47:45 +05:30
18e22e500e
Fix liveness connection opening endless sockets
...
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com >
2019-09-06 09:56:31 +05:30
22a7be55ea
Merge pull request #589 from Madhu-1/cherry-pic-vol
...
Remove volumemounter flag from cephfs
2019-09-05 13:07:23 +05:30
b90ddd7ade
Remove volumemounter flag from cephfs
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-05 13:04:44 +05:30
90c4d6a451
Cephfs: Use ceph kernel client if kernel version >= 4.17
...
Ceph kernel client is more performant than ceph fuse client.
The kernel client has Quota support only in the kernel version >=4.17.
Hence use ceph kernel client when the kernel version is >=4.17.
Signed-off-by: Poornima G <pgurusid@redhat.com >
2019-09-05 04:55:05 +00:00
d03a352abf
e2e: correct log format in execCommandInPod()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2019-09-04 12:26:55 +00:00
8f133e03b8
Add 'gosec' to the static-checks
...
Run static security scanning tool 'gosec' while testing.
URL: https://github.com/securego/gosec
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2019-09-04 11:48:37 +00:00
dd668e59f1
Address security concerns reported by 'gosec'
...
gosec reports several issues, none of them looks very critical. With
this change the following concerns have been addressed:
[pkg/cephfs/nodeserver.go:229] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
> os.Chmod(targetPath, 0777)
[pkg/cephfs/util.go:39] - G204: Subprocess launched with variable (Confidence: HIGH, Severity: MEDIUM)
> exec.Command(program, args...)
[pkg/rbd/nodeserver.go:156] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
> os.Chmod(stagingTargetPath, 0777)
[pkg/rbd/nodeserver.go:205] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
> os.OpenFile(mountPath, os.O_CREATE|os.O_RDWR, 0750)
[pkg/rbd/rbd_util.go:797] - G304: Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
> ioutil.ReadFile(fPath)
[pkg/util/cephcmds.go:35] - G204: Subprocess launched with variable (Confidence: HIGH, Severity: MEDIUM)
> exec.Command(program, args...)
[pkg/util/credentials.go:47] - G104: Errors unhandled. (Confidence: HIGH, Severity: LOW)
> os.Remove(tmpfile.Name())
[pkg/util/credentials.go:92] - G104: Errors unhandled. (Confidence: HIGH, Severity: LOW)
> os.Remove(cr.KeyFile)
[pkg/util/pidlimit.go:74] - G304: Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
> os.Open(pidsMax)
URL: https://github.com/securego/gosec
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2019-09-04 11:48:37 +00:00
d6f1c938d8
comment yum update from dockerfile
...
currently we are facing issue in building
docker image,commenting yum update it fix it
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-04 11:12:07 +00:00
64ca401a51
Fix mon endpoint issue in E2E
...
in toolbox mon endpoints are not
updated properly, this is causing an issue in E2E
this PR is a workaround to fix this issue.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-09-04 11:12:07 +00:00
677be13b11
Merge pull request #583 from nixpanic/mergify/dismiss_reviews
...
mergify: Remove approved review when a PR changes
2019-09-04 15:14:25 +05:30
2192d40937
mergify: Remove approved review when a PR changes
...
When people have reviewed a PR, and the contributor updates it, the
reviews are staying valid. This is unfortunate as the PR might need new
corrections.
Ideally a positive review (Approved) needs to be given again. And there
needs to be a confirmation that a negative review (Changes requested)
has been addressed.
Closes : #505
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2019-09-03 14:29:40 +02:00
ae67534a44
Add wait logic to check fsid from toolbox
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-30 06:50:32 +00:00
a81a3bf96b
implement grpc metrics for ceph-csi
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-30 06:50:32 +00:00
01a78cace5
switch to cephfs, utils, and csicommon to new loging system
...
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com >
2019-08-29 14:04:31 +00:00
7d3a18c5b7
Fix e2e failure caused due to mon connection from toolbox
...
i think now its take time to discover the mon IP
from svc name in tool box, this is a workaround
to fix it.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-29 11:17:54 +00:00
025aec3dd3
Trace backend volume from pvc
...
logs
```
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
| PVC Name | PV Name | Image Name | PV name in omap | Image ID in omap | Image in cluster |
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
| rbd-pvc | pvc-f1a501dd-03f6-45c9-89f4-85eed7a13ef2 | csi-vol-1b00f5f8-b1c1-11e9-8421-9243c1f659f0 | True | True | False |
| rbd-pvcq | pvc-09a8bceb-0f60-4036-85b9-dc89912ae372 | csi-vol-b781b9b1-b1c5-11e9-8421-9243c1f659f0 | True | True | True |
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
```
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-26 14:42:12 +00:00
3af364e7b5
move to statand context package
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-26 06:19:24 +00:00
38ca08bf65
Context based logging for rbd
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2019-08-26 06:19:24 +00:00
81c28d6cb0
implement klog wrapper
...
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com >
2019-08-21 14:36:41 +00:00
aa74f8c87f
Implement context based logging
...
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com >
2019-08-21 14:36:41 +00:00
3111e7712a
feat: Adds Ceph logo as icon for Helm charts
...
Signed-off-by: wilmardo <info@wilmardenouden.nl >
2019-08-20 05:34:28 +00:00