Madhu Rajanna
fa78c00535
update struct names and struct fiels
...
it wont be meaningful to call cephfs.NewcephfsDriver()
to get a new driver, it will be better if we call
cephfs.GetNewDriver() which returns the cephfs driver
object.
same goes for rbd also
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:14:48 +05:30
Madhu Rajanna
15b5b0112e
rename Id to ID to fix lint issue
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:14:48 +05:30
Madhu Rajanna
8f2941dd47
Remove code complexity
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:13:04 +05:30
Madhu Rajanna
de1f099680
Remove unused struct fields
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:10:52 +05:30
Madhu Rajanna
9f76f6bd59
Remove dead code
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:10:52 +05:30
Huamin Chen
c6c496ff59
switch to node registrar
2019-01-22 14:46:41 -05:00
Huamin Chen
0151792684
review feedback: make monValueFromSecret override monitors if both are set
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-21 09:21:03 -05:00
Huamin Chen
db463edeef
allow ceph mon stored in secret so when mon changes, cephfs driver can get latest mons and override old ones
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-18 10:27:48 -05:00
Huamin Chen
48407e2484
add csi volume device mount path to csi plugin
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-17 08:57:18 -05:00
Huamin Chen
263c45bb45
enable csi block; use canary external-provisioner image to pick up block volume provisioning
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-16 13:52:45 -05:00
Masaki Kimura
0e60dabca3
Move resolving bind mount logic from k8s
2019-01-16 13:00:48 -05:00
Masaki Kimura
ea75a9d162
Fix pv deletion issue caused by not dettaching due to wrong mount count
2019-01-16 12:51:13 -05:00
Masaki Kimura
5867d495fd
Change csi rbd to create/delete targetPath for publish/unpublish
2019-01-16 12:50:17 -05:00
Masaki Kimura
165b82a44c
Add block supports to rbd driver
2019-01-16 12:49:02 -05:00
Madhu Rajanna
e42e66ff30
user errors.New if error formatting is not required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-16 18:54:13 +05:30
Madhu Rajanna
17f5c0a7ce
use Errorf is error formatting is required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-16 18:54:06 +05:30
Madhu Rajanna
20af5afcab
Fix golint issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-16 18:33:38 +05:30
Madhu Rajanna
9ddc265c10
reject block volume creation in cephfs
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-16 18:17:14 +05:30
Huamin Chen
aed7506d88
fix merge leftovers; use canary driver-registrar image, as v1.0.0 is not hosted in quay.io
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-15 13:31:06 -05:00
Huamin Chen
e46099a504
reconcile merge
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2019-01-15 16:20:41 +00:00
Huamin Chen
85b8415024
Merge branch 'master' into master-to-1.0
2019-01-15 16:15:30 +00:00
mickymiek
b387daaabf
remove useless comment
2019-01-14 20:15:09 +00:00
mickymiek
32cb974b8c
gofmt
2019-01-14 20:15:09 +00:00
mickymiek
62d65ad0cb
cm metadata persist for rbd and cephfs
2019-01-14 20:15:09 +00:00
Patrick Ohly
51d6ac6f55
rbd: refuse to create block volumes
...
Without this check, the driver fails one of the E2E storage tests in
Kubernetes 1.13: provisioning a block volume is expected to fail in
e689d515f7/test/e2e/storage/testsuites/volumemode.go (L329-L330)
2019-01-14 20:15:09 +00:00
gman
29bdeb2261
cephfs: don't set quotas for zero-sized volumes
2019-01-14 20:15:09 +00:00
Patrick Ohly
403cad682c
rbd: protect against concurrent gRPC calls
...
The timeout value in external-provisioner is fairly low. It's not
uncommon that it times out and retries before the rbdplugin is done
with CreateVolume. rbdplugin has to serialize calls and ensure that
they are idempotent to deal with this.
2019-01-14 20:15:09 +00:00
Mike Cronce
2c3961b960
pkg/rbd/rbd.go: Fix "go vet" errors
2018-12-04 21:54:00 -05:00
Mike Cronce
23a4126aed
pkg/rbd/controllerserver.go: gofmt
2018-12-04 21:44:04 -05:00
Mike Cronce
d9fbdeb517
pkg/cephfs: Use request name to generate deterministic volume names
2018-12-04 21:39:00 -05:00
Mike Cronce
04872e5ebf
Merge branch 'master' of github.com:ceph/ceph-csi into csi-v1.0.0
2018-12-04 16:28:37 -05:00
Mike Cronce
22e23640a4
pkg/rbd/rbd.go: Updated PluginFolder to use new CSI 1.x directory
2018-12-04 15:38:09 -05:00
Mike Cronce
37caeb5b2c
pkg/cephfs/driver.go: Updated PluginFolder to use new CSI 1.x directory
2018-12-04 15:38:09 -05:00
gman
ed811e0506
cephfs: don't set quotas for zero-sized volumes
2018-12-01 10:39:09 +01:00
Mike Cronce
af3083f717
pkg: Updated "version" variables from 0.3.0 to 1.0.0
2018-11-29 13:15:52 -05:00
Mike Cronce
93cb8a04d7
pkg/rbd: Updated for new versions of CSI/Kubernetes dependencies
2018-11-24 14:18:24 -05:00
Mike Cronce
41b30eb6c2
pkg/cephfs: Updated for new versions of CSI/Kubernetes dependencies
2018-11-24 13:48:36 -05:00
Patrick Ohly
720ad4afeb
rbd: protect against concurrent gRPC calls
...
The timeout value in external-provisioner is fairly low. It's not
uncommon that it times out and retries before the rbdplugin is done
with CreateVolume. rbdplugin has to serialize calls and ensure that
they are idempotent to deal with this.
2018-10-26 15:29:48 +02:00
Huamin Chen
188cdd1d68
Merge pull request #89 from rootfs/containerized
...
support nsmounter when running in containerized mode
2018-10-15 20:25:40 -04:00
Huamin Chen
3436a094f7
support nsmounter when running in containerized mode
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2018-10-15 14:59:41 +00:00
Patrick Ohly
25e3a961c3
rbdplugin: idempotent DeleteVolume
...
When the initial DeleteVolume times out (as it does on slow clusters
due to the low 10 second limit), the external-provisioner calls it
again. The CSI standard requires the second call to succeed if the
volume has been deleted in the meantime. This didn't work because
DeleteVolume returned an error when failing to find the volume info
file:
rbdplugin: E1008 08:05:35.631783 1 utils.go:100] GRPC error: rbd: open err /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json/open /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json: no such file or directory
The fix is to treat a missing volume info file as "volume already
deleted" and return success. To detect this, the original os error
must be wrapped, otherwise the caller of loadVolInfo cannot determine
the root cause.
Note that further work may be needed to make the driver really
resilient, for example there are probably concurrency issues.
But for now this fixes : #82
2018-10-09 12:08:56 +02:00
Huamin Chen
239f295dd1
Merge pull request #79 from rootfs/rbd-nbd
...
allow monitors be embedded in credential secret
2018-09-24 08:58:09 -04:00
Huamin Chen
d5b7543565
allow monitors be embedded in credential secret
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2018-09-21 14:43:01 +00:00
Kenjiro Nakayama
c1e072de0b
Fix misspelling of "successfully"
2018-09-21 23:08:23 +09:00
Huamin Chen
30a5d9a6e7
add rbd-nbd mounter in storage class
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2018-09-18 14:09:12 +00:00
Huamin Chen
6f3625b11e
review feedback
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2018-09-18 13:10:28 +00:00
Huamin Chen
8955eb03bc
support rbd-nbd
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2018-09-17 18:12:22 +00:00
gman
3c11129149
cephfs: ceph user is created in CreateVolume and deleted in DeleteVolume
2018-08-28 10:21:11 +02:00
gman
9c3389d784
cephfs/util: log execCommandJson; cache mount.New() instance
2018-08-28 10:19:28 +02:00
gman
12958d0a9a
cephfs/cephuser: fixed getCephUser
...
output from `ceph auth -f json get` contains non-JSON data in the beginning
workaround for this is searching for the start of valid JSON data (starts with "[{")
and start reading from there
2018-08-28 10:13:53 +02:00
gman
6ddf98addf
cephfs: cache available volume mounters
2018-08-14 16:48:30 +02:00
gman
c515a013d3
cephfs: volumemounter probe
...
The driver will now probe for either ceph fuse/kernel every time
it's about to mount a cephfs volume.
This also affects CreateVolume/DeleteVolume where the mounting
was hard-coded to ceph kernel client till now - mounter configuration
and probing are now honored.
2018-08-14 11:19:41 +02:00
Huamin Chen
43b9f9aeaa
Merge pull request #61 from sngchlko/support-snapshot-in-rbdplugin
...
Support snapshot in rbdplugin
2018-08-09 09:31:31 -04:00
Seungcheol Ko
38aa575925
check snapshot feature
2018-08-09 22:07:13 +09:00
Seungcheol Ko
4312907f7b
remove the snapshot if can't store snapshot information
2018-08-09 22:07:06 +09:00
Seungcheol Ko
b0e68a52e0
Refactoring using users
2018-08-09 22:07:00 +09:00
Seungcheol Ko
7d90783f03
fix nit
2018-08-09 22:06:51 +09:00
Róbert Vašek
069140e74a
Merge pull request #65 from clkao/execCommandJson-error
...
Log error output for execCommandJson as well.
2018-08-08 17:58:52 +02:00
Chia-liang Kao
a1de128a81
Log error output for execCommandJson as well.
2018-08-08 23:39:19 +08:00
gman
1c38412e39
cephfs: CSI 0.3.0; NodeStageVolume/NodeUnstageVolume; refactoring
2018-08-08 14:47:25 +02:00
Seungcheol Ko
f0fba1240a
Revert "Implement NodeGetInfo for csi spec 3.0"
...
This reverts commit c93466b009
.
2018-08-08 20:22:59 +09:00
Seungcheol Ko
b1ccdbb154
Support snapshot feature in rbdplugin
2018-08-08 17:16:07 +09:00
Seungcheol Ko
c93466b009
Implement NodeGetInfo for csi spec 3.0
2018-08-08 14:41:45 +09:00
Huamin Chen
4331960ab3
Merge pull request #55 from nak3/nonempty
...
Add nonempty option to ceph-fuse to support ReadWriteMany
2018-08-07 14:14:57 -04:00
Kenjiro Nakayama
e8784ec094
Logging command and options for debug friendly
...
Some commands were executed in ceph-csi, but users do not know what
commands with what options were executed. Hence, it is difficult to
debug once the command did not work fine.
This patch adds logging what commmand and options are executed.
2018-07-31 15:31:11 +09:00
Kenjiro Nakayama
b649d4f1f6
Add nonempty option to ceph-fuse to support ReadWriteMany
...
fuse mount does not allow to mount directory if it contains some
files. Due to this, currently scaled pod with cephfs failed to mount
by ceph-fuse.
This patch adds nonempty option to ceph-fuse command to support
ReadWriteMany with ceph-fuse.
2018-07-31 14:44:33 +09:00
Seungcheol Ko
bc34bd389e
support image features for csi-rbdplugin
2018-07-21 00:59:54 +09:00
Masaki Kimura
753dbc2303
Fix Cephfs plugin to return false to ValidateVolumeCapabilities if Block volume is specified
...
Cephfs doesn't have a feature to provide Block Volume, therefore it should return false to ValidateVolumeCapabilities if Block Volume is specified.
Fixes #44
2018-07-10 16:48:55 +00:00
Huamin Chen
0df9e8e794
Merge pull request #42 from gman0/cephfs-delete-policy
...
cephfs: forbid deletion of shares not provisioned by the driver
2018-06-13 14:43:49 -04:00
gman
675ee93e46
cephfs: DeleteVolume() calls are allowed only for volumes with provisionVolume=true parameter
2018-06-13 16:29:10 +02:00
malc0lm
f273874f26
rbd: advertises PluginCapability_Service_CONTROLLER_SERVICE
2018-06-13 15:14:15 +08:00
gman
8c53b5eb79
cephfs: Identity Service advertises PluginCapability_Service_CONTROLLER_SERVICE
2018-06-12 17:09:44 +02:00
gman
0cc1e06beb
cephfs: createCephUser needs admin credentials
2018-06-12 17:08:14 +02:00
gman
b260bff659
cephfs: CreateVolume() needs ceph config
2018-06-12 17:07:20 +02:00
gman
2fcc252f5c
cephfs: pass volume UUIDs where needed
2018-06-12 17:05:42 +02:00
gman
f45ddd7c9d
cephfs: cephuser: set config and admin explicitly when creating/deleting users
2018-06-12 17:03:45 +02:00
gman
cc88d2fa09
cephfs: cephconf: include volume UUID in keyrings/secrets
2018-06-12 17:02:14 +02:00
gman
0ba3174bbc
cephfs/NodePublishVolume: fix error message
2018-05-23 10:28:25 +02:00
gman
1a7b365b95
cephfs: ceph config filename is now mixed with volume UUID
2018-05-18 18:17:37 +02:00
gman
bf89151b87
cephfs: ceph.conf is created in NodePublishVolume instead of CreateVolume
2018-05-18 18:15:37 +02:00
gman
77469c8370
cephfs/volumecache: fixed error msg
2018-04-20 16:24:13 +02:00
gman
8844452453
cephfs/nodeserver: create a new user if necessary; updated NodeUnpublishVolume
2018-04-13 15:53:43 +02:00
gman
a2160e88a7
cephfs/controllerserver: create volume if provisionVolume=true; implemented DeleteVolume
2018-04-13 14:54:40 +02:00
gman
886fdccb9b
cephfs: added mounter probing and --volumemounter cmd arg
2018-04-13 14:53:17 +02:00
gman
b7d856e562
cephfs/volume: added createVolume and purgeVolume
2018-04-13 14:49:49 +02:00
gman
c21d05a536
cephfs/cephconf: added cephFullCapsKeyring
2018-04-13 14:38:44 +02:00
gman
58eb8d1de7
updated cephfs/util
2018-04-13 14:34:48 +02:00
gman
88ca7077ae
added cephfs/cephuser
2018-04-13 14:31:46 +02:00
gman
8fd5478aa1
added cephfs/credentials
2018-04-13 14:31:03 +02:00
gman
cc6921fbd3
moved cephfs mounting logic to volumemounter
2018-04-13 14:29:54 +02:00
gman
62f271056a
added cephfs/volumecache - stores volume info in json files
2018-04-13 14:28:59 +02:00
gman
69ecce1e75
cephfs/volumeidentifier: changed volume ID scheme
...
volumes have "csi-cephfs-dyn-" prefix when they are provisioned dynamically (provisionVolume=true)
and have "csi-cephfs-sta-" prefix when they are provisioned statically by the user (provisionVolume=false)
2018-04-13 14:24:40 +02:00
gman
374176c6ce
cephfs/volumeoptions: added fields; validate values
...
added Pool and ProvisionVolume fields
Mounter is now optional
2018-04-13 14:21:15 +02:00
gman
61103bbc47
cephfs/cephconf: workaround for http://tracker.ceph.com/issues/23446
2018-03-26 15:01:13 +02:00
gman
cb36c9e4c8
cephfs: code cleaning
2018-03-26 15:00:28 +02:00
gman
4c5c67b8f9
cephfs: check volumeOptions.Mounter and choose ceph-fuse or mount.ceph accordingly
2018-03-22 14:14:57 +01:00
gman
defc676b3d
cephfs/volume: added the ability to use either FUSE or ceph kernel client
2018-03-22 14:14:57 +01:00
gman
9fefc270d8
cephfs/controllerserver: write ceph.conf
2018-03-20 16:40:30 +01:00
gman
aa4130865c
cephfs/nodeserver: read credentials from Secret
2018-03-20 16:40:30 +01:00
gman
436bb54262
cephfs/volume: fixed arguments for ceph-fuse; assume volume root and cephx user already exist
2018-03-20 16:40:23 +01:00