Niels de Vos
e3ea8ca0b1
cleanup: standardize error format in util.GetTopologyFromDomainLabels()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
6d5de7458d
cleanup: standardize error format in util.k8sGetNodeLabels()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
752841d213
cleanup: standardize error format in util.readClusterInfo()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
3dfe65d17c
cleanup: return error type in GetCryptoPassphrase()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
c8c8176a37
cleanup: return error type in util.storeKey()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
f8ebc6aa3f
cleanup: return error type in ensureEncryptionMetadataSet()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
d8e443ab49
cleanup: return error type in cleanupRBDImageMetadataStash()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
f262673b60
cleanup: return error type in lookupRBDImageMetadataStash()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
8e589587ae
cleanup: return error type in stashRBDImageMetadata()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
57ce07f54e
cleanup: return error type in updateVolWithImageInfo()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
610162b5f4
cleanup: return error type in genVolFromVolumeOptions()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
729e2419ef
cleanup: return error type in detachRBDImageOrDeviceSpec()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
7eae69f10c
cleanup: return error type in rbdGetDeviceList()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
4dde3fc9e0
cleanup: return error type in encryptDevice()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
d6fb8f302d
cleanup: return error type in NodeServer.processEncryptedDevice()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
8019e4d1bc
rbd: return CSI status-error on resize failure
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
65a10fd553
cleanup: standardize error format in NodeServer.NodeStageVolume()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
cc3f146ad1
cleanup: return error type in rbdVolume.checkCloneImage()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
37471c7a5f
cleanup: return error type in ReconcilePersistentVolume.getCredentials()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Niels de Vos
a7a928d7ec
cleanup: return error from execCommandErr() in bindMount()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-09 08:35:35 +00:00
Madhu Rajanna
518ccf42b3
deploy: add option to set default-fstype in provisioner
...
external-provisioner is exposing a new argument
to set the default fstype while starting the provisioner
sidecar, if the fstype is not specified in the storageclass
the default fstype will be applied for the pvc created from
the storageclass.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 16:09:25 +00:00
Madhu Rajanna
7d3bff0654
e2e: enable topology based provisioning
...
as we are testing the topology based
provisioning in our E2E, we need to set
topology=true in E2E.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 16:09:25 +00:00
Madhu Rajanna
e3d1ba7703
deploy: set topology=false in provisioner sidecar
...
with csi-provisioner v2.x the topology based
provisioning will not have any backward compatibility
with older version of kubernetes, if the nodes are
not labeled with topology keys, the pvc creation
is going to get fail with error `accessibility
requirements: no available topology found`, disabling
the topology based provisioning by default, if user want
to use it he can always enable it.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 16:09:25 +00:00
Madhu Rajanna
1c469fa522
doc: update new release matrix
...
updating the readme with latest release
image and version.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 10:43:06 +00:00
Madhu Rajanna
72fa77a6d7
ci: add mergify rules for release-v3.2
...
added mergify rules for backporting and
for auto merging the PR.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-08 11:25:16 +01:00
Mudit Agarwal
a92d8d7f2e
deploy: update csi sidecar images
...
This PR makes the changes in csi templates and
upgrade documentation required for updating
csi sidecar images.
Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
2020-12-08 10:23:34 +00:00
Mudit Agarwal
ba8ead6e04
doc: add upgrade document for 3.2
...
Added upgrade document for 3.2 with a separate section on
CSI sidecar containers update.
Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
2020-12-07 15:16:46 +00:00
Madhu Rajanna
43fde0a30a
cleanup: add a helper function storeImageID
...
added a helper function storeImageID to reduce
code duplication.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 11:03:27 +00:00
Madhu Rajanna
b2fb43b335
cleanup: reduce the code complexity of controller
...
created a new helper function to getCredentials.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 11:03:27 +00:00
Madhu Rajanna
e243c0006b
rbd: dont generate OMAP data for static volume
...
if the user has created a static PV for a RBD
image which is not created by CSI driver, dont
generate the OMAP data.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 11:03:27 +00:00
Madhu Rajanna
c40872df00
rbd: undo reservation incase of errors
...
If cephcsi encounters any error after
reservation, as a cleanup operation
it should revert back the reservation.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 11:03:27 +00:00
Madhu Rajanna
99dbe27921
rbd: return nil if the omap data exists
...
If the omap data already exits return nil.
so that omap generator will not try to reserve
anything again.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 11:03:27 +00:00
Madhu Rajanna
5cddfc454e
ci: update mergify rules for github actions
...
as we have added new github actions for the
static checks in #1762 . This commits adds
the mergify rules for those github actions.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 10:48:53 +01:00
Madhu Rajanna
edf6abce99
ci: add github workflows for static checks
...
adding a github workflow to run static checks
inside a container.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-07 12:57:29 +05:30
Niels de Vos
11e1eda98b
build: install diffutils in test container image
...
Depending on the local changes, running 'make containerized-test' fails
with an error like:
level=error msg="Running error: gofmt: error computing diff: exec: \"diff\": executable file not found in $PATH"
Installing the diffutils package makes sure 'go fmt' finds the
executable.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-04 05:01:17 +00:00
Madhu Rajanna
ebb413534f
cephfs: remove unsed cr util.Credentials
...
remove unused cr util.Credentials variable.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-03 14:53:33 +00:00
Madhu Rajanna
0f451ed465
cephfs: implement getSnapshotInfo with go-ceph
...
implement getSnapshotInfo function with go-ceph
to get subvolume information.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-03 14:53:33 +00:00
Niels de Vos
b0f3b27209
ci: set imagePullPolicy for Vault to IfNotPresent
...
Deploying Vault still fails on occasion. It seems that the
imagePullPolicy has not been configured for the container yet.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-03 13:17:24 +00:00
Madhu Rajanna
ddf91de859
cephfs: implement clonesnapshot with go-ceph
...
updated ceph fs CLI implementaion of cloning
with go-ceph.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-03 06:39:18 +00:00
Madhu Rajanna
814bf4459a
cephfs: implement snapshot protect and unprotect to go-ceph
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-03 06:39:18 +00:00
yati1998
78968f76e8
doc: update snap-clone with rbd snapshot
...
RBD Snapshot doc was the part of the README.md file. Hence,
renamed the cephfs-snap-clone.md file to snap-clone.md file
and moved the rbd snapshot document there.
Signed-off-by: yati1998 <ypadia@redhat.com>
2020-12-02 21:48:39 +00:00
Madhu Rajanna
00d34fdb2d
ci: run github work flow only for pull request
...
currently github action are getting trigerred for
both pull and push request, this commits removes the
action for push events.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-12-02 20:09:56 +05:30
Niels de Vos
3433cefaa5
cleanup: standardize logging in deleteSnapshot
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 14:36:39 +00:00
Niels de Vos
294f7b22d4
cephfs: remove unused Credentials argument from deleteSnapshot()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 14:36:39 +00:00
Niels de Vos
9d9b5b3303
cephfs: implement deleteSnapshot() with go-ceph
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 14:36:39 +00:00
Niels de Vos
032db78d8a
cephfs: make deleteSnapshot() a method of volumeOptions
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 14:36:39 +00:00
Niels de Vos
5883f244d2
cleanup: standardize logging in createSnapshot
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 13:18:47 +05:30
Niels de Vos
7c580af412
cephfs: remove unused Credentials argument from createSnapshot()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 13:18:47 +05:30
Niels de Vos
1d8cc75282
cephfs: implement createSnapshot() with go-ceph
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 13:18:47 +05:30
Niels de Vos
57f8ee0aa7
cephfs: make createSnapshot() a method of volumeOptions
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-12-02 13:18:47 +05:30