Madhu Rajanna
18d65ba3f5
cephfs: replace Errorf with ErrorLog in createCloneFromSnapshot
...
replace Errorf with ErrorLog in createCloneFromSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fa512617b
cephfs: replace Errorf with util.ErrorLog in cleanupClone
...
replace Errorf with util.ErrorLog in cleanupCloneFromSubvolumeSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e1fb708d48
cephfs: replace Errorf with util.ErrorLog in createCloneFromSubvolume
...
replace Errorf with util.ErrorLog in createCloneFromSubvolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
20dbbe54b0
cephfs: replace klog.Warningf with util.WarningLog in deleteSnapshot
...
replace klog.Warningf with util.WarningLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7eefadf1eb
cephfs: replace klog.Warning with util.WarningLog in DeleteVolume
...
replace klog.Warning with util.WarningLog in DeleteVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e3c3bbf0e3
cephfs: replace klog.Warning with util.WarningLog in CreateVolume
...
replace klog.Warning with util.WarningLog in CreateVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3d12456493
util: add WarningLog to log with context
...
added WarningLog to log with context
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
b223924044
util: rename WarningLog to WarningLogMsg
...
renamed WarningLog function to WarningLogMsg
to log with message.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f45ad230a2
cephfs: replace klog.Error with util.ErrorLog in deleteSnapshot
...
replace klog.Error with util.ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
52f14cf9fe
cephfs: replace klog.Error with util.ErrorLog in validateSnapshotReq
...
replace klog.Error with util.ErrorLog in validateSnapshotReq
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d101cbc888
cephfs: replace klog.Error with util.ErrorLog in doSnapshot
...
replace klog.Error with util.ErrorLog in doSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5802265b28
cephfs: replace klog.Error with util.ErrorLog in createSnapshot
...
replace klog.Error with util.ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
81b52b311d
cephfs: replace klog.Error with util.ErrorLog in ControllerExpand
...
replace klog.Error with util.ErrorLog in ControllerExpand
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7ed5dfe81a
cephfs: replace klog.Error with util.ErrorLog in DeleteVolume
...
replaced klog.Error with util.ErrorLog in DeleteVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
cc600dab76
cephfs: replace klog.Error with util.ErrorLog in CreateVolume
...
replaced klog.Error with util.ErrorLog
in createVolume function.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3c45ec32db
cephfs: replace klog.Error in createBackingVolume
...
replace klog.Error with util.ErrorLog in
createBackingVolume function.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
8c32045c4e
util: use ErrorLog for context based logging
...
use ErrorLog for context based logging for
more detailed logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7c24f4d597
util: add ErrorLog for log with context
...
added a new function ErrorLog to log with
context.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
9229e84a77
util: rename ErrorLog to ErrorLogMsg to parity
...
as we have 2 functions for logging. one for logging
with message and another one is for logging with
context. renamed ErrorLog to ErrorLogMsg to log
with messages.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d4186a6880
rbd: discard flattening error if the image doesnt have parent
...
if the image is created without flattening image-feature
the image will get few image-features by default, deep-flatten
is one of them. if the image doesnot have any parent
the rbd image flattening will fail, This commit discards
error message if the image doesnt have any parent.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 08:37:53 +00:00
Humble Chirammal
3c6149b86e
cephfs: Add documentation about snapshot create/restore and clone
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-13 07:16:31 +00:00
Niels de Vos
9bd91bc9d3
ci: use last "git fetch" output to test commitlint
...
When running in the CI the git repository is not completely cloned. This
causes the 'commitlint' job to be unable to resolve the history of the
commits.
By using FETCH_HEAD, the last 'git fetch' output will be used.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-13 12:12:58 +05:30
Humble Chirammal
2b180d89c5
cephfs: change the volumetype to RWX instead of RWO
...
The intention here is to keep the example YAMLs of CephFS
with recommended Access Mode of CephFS which is RWX instead of RWO.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-13 03:37:28 +00:00
Madhu Rajanna
22158ebf17
rebase: workaround missing redirect
...
This fix is needed because we were hitting:
```
vbom.ml/util@v0.0.0-20180919145318-efcd4e0f9787:
unrecognized import path "vbom.ml/util":
reading https://vbom.ml/util?go-get=1 : 503 Service Unavailable
```
Source for the workaround:
golang/dep#1169
The fix consists in simply enforcing what the redirect was supposed to
do.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-12 17:22:21 +00:00
Mudit Agarwal
46acd6b2cd
doc: update e2e README for snapshot operation
...
Updated e2e README with the prerequisites to run snapshot/clone e2e tests.
Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
2020-08-12 16:27:49 +00:00
Madhu Rajanna
8a581ec6c0
rbd: fix build issue for rbd
...
merging of https://github.com/ceph/ceph-csi/pull/1035
broken the cephcsi building. This commits fixes
the build issue.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-12 19:53:48 +05:30
Mehdy Khoshnoody
204487383d
e2e: Add e2e test cases for rbd rados namespace
...
These test cases are will be executed against a rados namespace.
- Create a PVC and bind it to an app.
- Resize block PVC and check device size.
- Create a PVC clone and bind it to an app.
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
2020-08-12 16:22:58 +05:30
Mehdy Khoshnoody
3081eabba5
doc: Add rados namespace to option to csi-configs
...
A minimal documentation on how to use a rados namespace with rbd.
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
2020-08-12 16:22:58 +05:30
Mehdy Khoshnoody
fc5eadf106
rbd: Add rados namespace support for rbd
...
Make sure to operate within the namespace if any given
when dealing with rbd images and snapshots and their journals.
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
2020-08-12 16:22:58 +05:30
Madhu Rajanna
b5320d9273
e2e: add backend validation for pvc restore and clone
...
added backend subvolume validation for cephfs
snapshot restore and pvc to pvc clone.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 16:21:29 +00:00
Madhu Rajanna
2307687dc2
e2e: add backend validation of cephfs pvc
...
added a backend validation to check subvolumes
count when we create and delete pvc.
fixes #1316
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 16:21:29 +00:00
Madhu Rajanna
141b89f514
e2e: add function to get subvolume list
...
added a helper function in e2e to list subvolumes
in a filesystem
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 16:21:29 +00:00
Humble Chirammal
07890aace6
doc: correct rbd snap-clone doc
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-11 13:39:47 +00:00
Madhu Rajanna
44191b5a1f
e2e: update cephcsi upgrade testing version
...
updated upgrade testing version to 3.0.0
to check the backward compatibility with the
latest release.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 12:20:19 +00:00
Madhu Rajanna
bfde065f92
util: move getMonsAndClusterID to util
...
as we had duplicate functions in both cephfs
and rbd this commit moves the function to util.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 10:02:53 +00:00
Madhu Rajanna
18f4e9d519
util: move csiconfigfile to util
...
as we have csiconfigfile in both cephfs
and rbd moving the configfile path to
util folder.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-11 10:02:53 +00:00
Niels de Vos
35c5afcd3e
ci: always fetch GIT_SINCE for commitlint
...
When running the commitlint CI job, the branch that the PR is based on
may not be available. That makes it impossible for commitlint to detect
the changes between the HEAD of the branch, and the commits in the PR.
By fetching GIT_SINCE unconditionally, commitlint should be able to
detect the changes and only run the tests against the commits that were
added through the PR.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
b864afd6d7
util: use local ErrorLog() for Create/RemoveObject() instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
eaea18df0f
util: use local FatalLog() for NewK8sClient() instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
9d4020d255
util: use local ErrorLog() for CheckKernelSupport() instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
75ae16cfab
util: use local DefaultLog() for util/topology instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
bf02227207
util: use local ErrorLog() for OperationLock.release() instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
fb56a7595a
util: use local ErrorLog() for GetCryptoPassphrase() instead of klog
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
61924adf57
util: use FatalLog() in util/httpserver.go
...
Hide the use of klog by using our own FatalLog() function.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
ab033f85df
util: add FatalLog(), ErrorLog() and WarningLog() functions
...
These functions will always log the message, irrespectively of the
log-level that has been configured.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Niels de Vos
44863a9d29
cleanup: move log functions to util/log.go
...
There is a util/log.go file, so the log functions in util/util.go can be
moved there.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-11 08:11:37 +00:00
Madhu Rajanna
b86d329d1e
rbd: add stagingpath to error message
...
if the stagingpath is not present inside
the container send the staging path in error
message.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-10 08:51:23 +00:00
Humble Chirammal
ef1785ce4d
e2e: remove volume populate test case and also change writeDataInPod()
...
As we are populating the volume in other two test cases for clone and
snapshot operation, we dont need a specific test case now.
WriteDataInPod() function is also changed to take the pod spec and write
some data to it
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-08 00:11:35 +00:00
Humble Chirammal
7d2bba1375
cephfs: introduce parsetime() to parse createdAt field in snap return
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-08 00:11:35 +00:00
Humble Chirammal
c3400bfb97
cephfs: add snapshot create and delete functionalilies
...
It also add helper routines like parsetime,doSnapshot..etc
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-08 00:11:35 +00:00