3dfe65d17c
cleanup: return error type in GetCryptoPassphrase()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
c8c8176a37
cleanup: return error type in util.storeKey()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
f8ebc6aa3f
cleanup: return error type in ensureEncryptionMetadataSet()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
d8e443ab49
cleanup: return error type in cleanupRBDImageMetadataStash()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
f262673b60
cleanup: return error type in lookupRBDImageMetadataStash()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
8e589587ae
cleanup: return error type in stashRBDImageMetadata()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
57ce07f54e
cleanup: return error type in updateVolWithImageInfo()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
610162b5f4
cleanup: return error type in genVolFromVolumeOptions()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
729e2419ef
cleanup: return error type in detachRBDImageOrDeviceSpec()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
7eae69f10c
cleanup: return error type in rbdGetDeviceList()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
4dde3fc9e0
cleanup: return error type in encryptDevice()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
d6fb8f302d
cleanup: return error type in NodeServer.processEncryptedDevice()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
8019e4d1bc
rbd: return CSI status-error on resize failure
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
65a10fd553
cleanup: standardize error format in NodeServer.NodeStageVolume()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
cc3f146ad1
cleanup: return error type in rbdVolume.checkCloneImage()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
37471c7a5f
cleanup: return error type in ReconcilePersistentVolume.getCredentials()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
a7a928d7ec
cleanup: return error from execCommandErr() in bindMount()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-09 08:35:35 +00:00
43fde0a30a
cleanup: add a helper function storeImageID
...
added a helper function storeImageID to reduce
code duplication.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-07 11:03:27 +00:00
b2fb43b335
cleanup: reduce the code complexity of controller
...
created a new helper function to getCredentials.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-07 11:03:27 +00:00
e243c0006b
rbd: dont generate OMAP data for static volume
...
if the user has created a static PV for a RBD
image which is not created by CSI driver, dont
generate the OMAP data.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-07 11:03:27 +00:00
c40872df00
rbd: undo reservation incase of errors
...
If cephcsi encounters any error after
reservation, as a cleanup operation
it should revert back the reservation.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-07 11:03:27 +00:00
99dbe27921
rbd: return nil if the omap data exists
...
If the omap data already exits return nil.
so that omap generator will not try to reserve
anything again.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-07 11:03:27 +00:00
ebb413534f
cephfs: remove unsed cr util.Credentials
...
remove unused cr util.Credentials variable.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-03 14:53:33 +00:00
0f451ed465
cephfs: implement getSnapshotInfo with go-ceph
...
implement getSnapshotInfo function with go-ceph
to get subvolume information.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-03 14:53:33 +00:00
ddf91de859
cephfs: implement clonesnapshot with go-ceph
...
updated ceph fs CLI implementaion of cloning
with go-ceph.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-03 06:39:18 +00:00
814bf4459a
cephfs: implement snapshot protect and unprotect to go-ceph
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-03 06:39:18 +00:00
3433cefaa5
cleanup: standardize logging in deleteSnapshot
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 14:36:39 +00:00
294f7b22d4
cephfs: remove unused Credentials argument from deleteSnapshot()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 14:36:39 +00:00
9d9b5b3303
cephfs: implement deleteSnapshot() with go-ceph
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 14:36:39 +00:00
032db78d8a
cephfs: make deleteSnapshot() a method of volumeOptions
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 14:36:39 +00:00
5883f244d2
cleanup: standardize logging in createSnapshot
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 13:18:47 +05:30
7c580af412
cephfs: remove unused Credentials argument from createSnapshot()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 13:18:47 +05:30
1d8cc75282
cephfs: implement createSnapshot() with go-ceph
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 13:18:47 +05:30
57f8ee0aa7
cephfs: make createSnapshot() a method of volumeOptions
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-12-02 13:18:47 +05:30
a35a835e9c
cephfs: fix logic to call ceph fs resize
...
clusterAdditionalInfo map is holding a localClusterState
for checking ceph cluster supports resize and subvolumegroup
is created or not, currently we are checking if the key is present
in a map and localClusterStatelocalClusterState.resizeSupported
is set to false to call ceph fs subvolume resize to check command is
supported or not, if a structure is initialized all its members
are set to default value. so we will never going to check the
ceph fs subvolume resize command is supported in backend or not, we are
always using ceph fs subvolume create to resize subvolume. in some
ceph version ceph fs subvolume create wont work to resize a subvolume.
This commit changes the resizeSupported from bool to *bool for
proper handling of this scenario.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 13:31:39 +00:00
a1c8942e2b
cephfs: remove unused invalidCommand error const
...
removed unused invalidCommand from cephfs
error const.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
1ba160afdb
cephfs: handle invalid error in subvolume info
...
go ceph returns NotImplementedError for invalid
commands,cephcsi is using errors.As to find out
the error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
66eb3b7525
cephfs: handle invalid error in fs resize
...
go ceph returns NotImplementedError for invalid
commands,cephcsi is using errors.As to find out
the error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
2232067e99
cephfs: use rados.ErrNotFound in subvolume info
...
go-ceph rados.ErrNotFound for not found errors,cephcsi
need to check same for not found errors.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
a0283ef7f9
cephfs: use rados.ErrNotFound in getVolumeRootPathCeph
...
go-ceph rados.ErrNotFound for not found errors,cephcsi
need to check same for not found errors.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
b40d561228
cephfs: make getVolumeRootPathCeph as a method
...
getVolumeRootPathCeph is a method of volumeOptions
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
e4713bc9ed
cephfs: remove unused Credentials argument from getVolumeRootPathCeph
...
remove unused Credentials argument from getVolumeRootPathCeph
function.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
b6f3ba885e
cephfs: implement getVolumeRootPathCeph with go-ceph
...
instead of ceph fs CLI commands using go-ceph library
to get subvolume path.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-12-01 09:46:52 +00:00
5565a902ac
rebase: split vaultConnection from VaultKMS
...
In order to re-use the configuration of Vault, split a new
vaultConnection type from the VaultKMS type.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-11-30 19:16:39 +00:00
8ebb9a1ba0
cleanup: fix misspell words
...
fixed misspell words detected by codespell
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-11-30 08:46:48 +01:00
39b1f2b4d3
cleanup: fix mispell words
...
fixed mispell words in the repo.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2020-11-29 12:47:46 +05:30
8d08e8b37e
cephfs: remove unused Credentials argument from getCloneState()
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-11-29 07:13:35 +00:00
055975f790
cephfs: implement getCloneState() with go-ceph
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-11-29 07:13:35 +00:00
476ad18d2e
cephfs: make getCloneState() a method of volumeOptions
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-11-29 07:13:35 +00:00
66aa595e77
cephfs: do not export internal CloneStatus type
...
getCloneInfo() does not need to return a full CloneStatus struct that
only has one member. Instead, it can just return the value of the single
member, so the JSON type/struct does not need to be exposed.
This makes the API for getCloneInfo() a little simpler, so it can be
replaced by a go-ceph implementation later on.
As the function does not return any of the unused attributes anymore, it
is renamed to getCloneStatu() as well.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2020-11-29 07:13:35 +00:00
