Niels de Vos
f6de345cc9
cleanup: standardize error logs in cephfs/volume.go
...
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-10-01 12:00:59 +00:00
Humble Chirammal
b5d1edd3f7
cephfs: correct cephFSCloneInprogress source code comment
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-09-25 17:36:14 +00:00
Madhu Rajanna
89b326c896
cephfs: check ENOTEMPTY when removing subvolume
...
return a proper error message to the user when
the subvolume has the snapshots and it cannot
be removed until the snapshots on the subvolume
have to be deleted.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-09-23 13:51:23 +00:00
Niels de Vos
6f2f972f5b
cephfs: trim spaces around fuseMountOptions
...
When passing
fuseMountOptions: debug
in the StorageClass, the mount options passed on the ceph-fuse
commandline result in "-o nonempty ,debug". The additional space before
the ",debug" causes the mount command to fail.
Fixes: 1485
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-09-23 12:12:51 +00:00
Yug
0682f0e500
cephfs: Fetch subvolume features in newSnapshotOptionsFromID
...
Get subvolume features using subvolume info and update the
volume options with Features parameter.
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-16 16:05:28 +00:00
Yug
9e959c45a3
cephfs: No-Op Unprotect call if "snapshot-autoprotect" feature present
...
The subvolume features consists the list of features, which if includes
"snapshot-autoprotect", result in query based approach to
detecting the need for protect/unprotect.
If "snapshot-autoprotect" feature is present, The UnprotectSnapshot
call should be treated as a no-op
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-16 16:05:28 +00:00
Yug
43a4c100ec
cephfs: No-Op Protect call if "snapshot-autoprotect" feature present
...
The subvolume features consists the list of features, which if includes
"snapshot-autoprotect", result in query based approach to
detecting the need for protect/unprotect.
If "snapshot-autoprotect" feature is present, The ProtectSnapshot
call should be treated as a no-op
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-16 16:05:28 +00:00
Yug
365eb58ff7
cephfs: use subvolume info if available
...
Use subvolume info to fetch the subvolume path.
If `subvolume info` command is not available,
use `getpath` command instead.
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-10 15:03:45 +00:00
Yug
59fc4aa00f
cephfs: validate if subvolume has snapshot-retention feature
...
Add validateSnapshotRetention() to verify if subvolume has
`snapshot-retention` feature.
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-10 15:03:45 +00:00
Yug
6351358752
cephfs: Add --retain-snapshots
flag to purge volume operations
...
Snapshots can be retained even after subvolume deletion in
Ceph 14.2.12. Adding support for the same in ceph-csi.
Signed-off-by: Yug <yuggupta27@gmail.com>
2020-09-10 15:03:45 +00:00
Madhu Rajanna
860b65c446
cephfs: allow readonly only for volume with contentsource
...
It doesnot make sense to allow the creation of empty
volumes with readonly access, this commit allows the
creation of volume which is having readonly capabilities
only if the content source is set for the volume.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-09-10 13:47:23 +00:00
Madhu Rajanna
0bd45a5eb1
cephfs: use string const for cli error comparison
...
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.
updates #1242
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 17:09:12 +00:00
Madhu Rajanna
787ba69089
cephfs: fix lock release in volumeDelete
...
currently the lock is not released which is
taken on the request name. this is causing issues
when the subvolume is requested for delete.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Madhu Rajanna
31c7c95fdb
cephfs: check error output contains Error: ENOENT
...
execCommandErr returns both error and stderror
message. checking strings.HasPrefix is not helpful
as the stderr will be the first string. its good
to do string comparison and find out that error
is volume not found error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Madhu Rajanna
f566b0fc2d
cephfs: replace Warningf with WarningLog in unmountVolume
...
replace Errorf with ErrorLog in unmountVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fe3d25dda
cephfs: replace Errorf with ErrorLogMsg in loadAvailableMounters
...
replace Errorf with ErrorLog in loadAvailableMounters
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
fbe090065d
cephfs: replace Errorf with ErrorLog in purgeVolume
...
replace Errorf with ErrorLog in purgeVolume
for context based logging
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5a1652e5e8
cephfs: replace Errorf with ErrorLog in resizeVolume
...
replace Errorf with ErrorLog in resizeVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
a882c1194b
cephfs: replace Errorf with ErrorLog in createVolume
...
replace Errorf with ErrorLog in createVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f3d9b8933b
cephfs: replace Errorf with ErrorLog in getSubVolumeInfo
...
replace Errorf with ErrorLog in getSubVolumeInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
2b7aade289
cephfs: replace Errorf with ErrorLog in getVolumeRootPathCeph
...
replace Errorf with ErrorLog in getVolumeRootPathCeph
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d1ac832266
cephfs: replace Errorf with ErrorLog in genSnapFromOptions
...
replace Errorf with ErrorLog in genSnapFromOptions
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e83a51c1e1
cephfs: replace Errorf with ErrorLog in parseTime
...
replace Errorf with ErrorLog in parseTime
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e7a043271d
cephfs: replace Errorf with ErrorLog in cloneSnapshot
...
replace Errorf with ErrorLog in cloneSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
841a3713f5
cephfs: replace Errorf with ErrorLog in unprotectSnapshot
...
replace Errorf with ErrorLog in unprotectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
91811c18c5
cephfs: replace Errorf with ErrorLog in protectSnapshot
...
replace Errorf with ErrorLog in protectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
72dfe6a265
cephfs: replace Errorf with ErrorLog in getSnapshotInfo
...
replace Errorf with ErrorLog in getSnapshotInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7e8cc41aca
cephfs: replace Errorf with ErrorLog in deleteSnapshot
...
replace Errorf with ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7f00fa66f4
cephfs: replace Errorf with ErrorLog in createSnapshot
...
replace Errorf with ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
57454cf379
cephfs: replace Errorf with ErrorLog in nodeUnstageVolume
...
replace Errorf with ErrorLog in nodeUnstageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
0a5581b7a0
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
...
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
79dbc41d14
cephfs: replace Errorf with ErrorLog in NodePublishVolume
...
replace Errorf with ErrorLog in NodePublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
48a313c6cc
cephfs: replace Errorf with ErrorLog in mount
...
replace Errorf with ErrorLog in mount for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
032901b8d0
cephfs: replace Errorf with ErrorLog in nodeStageVolume
...
replace Errorf with ErrorLog in nodeStageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
c57189382f
cephfs: replace Errorf with ErrorLog in checkSnapExists
...
replace Errorf with ErrorLog in checkSnapExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
98e97baa60
cephfs: replace Errorf with ErrorLog in checkVolExists
...
replace Errorf with ErrorLog in checkVolExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
abd548e420
cephfs: replace warning with WarningLogMsg in Run
...
replace warning with WarningLogMsg in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
38273f879f
cephfs: replace fatal with util.FatalLog in Run
...
replace fatal with util.FatalLog in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
71a6dc3ba8
cephfs: replace Errorf with util.ErrorLog in getCloneInfo
...
replace Errorf with util.ErrorLog in getCloneInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
ae6b77f105
cephfs: add comment for exported CloneStatus struct
...
added comment for exported structure.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
18d65ba3f5
cephfs: replace Errorf with ErrorLog in createCloneFromSnapshot
...
replace Errorf with ErrorLog in createCloneFromSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fa512617b
cephfs: replace Errorf with util.ErrorLog in cleanupClone
...
replace Errorf with util.ErrorLog in cleanupCloneFromSubvolumeSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e1fb708d48
cephfs: replace Errorf with util.ErrorLog in createCloneFromSubvolume
...
replace Errorf with util.ErrorLog in createCloneFromSubvolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
20dbbe54b0
cephfs: replace klog.Warningf with util.WarningLog in deleteSnapshot
...
replace klog.Warningf with util.WarningLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7eefadf1eb
cephfs: replace klog.Warning with util.WarningLog in DeleteVolume
...
replace klog.Warning with util.WarningLog in DeleteVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e3c3bbf0e3
cephfs: replace klog.Warning with util.WarningLog in CreateVolume
...
replace klog.Warning with util.WarningLog in CreateVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f45ad230a2
cephfs: replace klog.Error with util.ErrorLog in deleteSnapshot
...
replace klog.Error with util.ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
52f14cf9fe
cephfs: replace klog.Error with util.ErrorLog in validateSnapshotReq
...
replace klog.Error with util.ErrorLog in validateSnapshotReq
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d101cbc888
cephfs: replace klog.Error with util.ErrorLog in doSnapshot
...
replace klog.Error with util.ErrorLog in doSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5802265b28
cephfs: replace klog.Error with util.ErrorLog in createSnapshot
...
replace klog.Error with util.ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00