Commit Graph

4 Commits

Author SHA1 Message Date
Praveen M
c1b3325677 cleanup: move rbd errors to internal/rbd/errors
This commit includes:
1). Moves rbd errors from internal/util/errors to internal/rbd/errors.

2). Introduces ShouldRetryVolumeGroupGeneration helper function to determine
whether volume group generation should continue based on specific error types.
The function returns true if the error is of type ErrPoolNotFound,
ErrRBDGroupNotFound, ErrPermissionDenied. (Ceph user might not have access to
all the objects/pools where mapping exists)

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-03-04 16:56:24 +05:30
Nikhil-Ladha
18a62ec9de util: return correct status code for VolumeGroupSnapshot
Fix status codes that are returned for Get/Delete RPC calls
for VolumeGroup/VolumeGroupSnapshot.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2024-12-19 10:42:01 +00:00
Niels de Vos
cea8bf8110 rbd: set SnapshotGroupID on each Snapshot of a VolumeGroupSnapshot
Without the SnapshotGroupID in the Snapshot object, Kubernetes CSI does
not know that the Snapshot belongs to a group. In that case, it allows
the deletion of the Snapshot, which should be denied.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-11-06 11:37:44 +00:00
Niels de Vos
455a90e9f4 rbd: add VolumeGroupSnapshot type
The VolumeGroupSnapshot type will be used by the rbd.Manager to create,
inspect and delete VolumeGroupSnapshos.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-11-06 11:37:44 +00:00