Madhu Rajanna
38892c3068
rbd: rearrange the cleanup order incase clone fails
...
in case of clone failure, we need to first delete
the clone and the snapshot from which we created
the clone, then as part of cleanup we need to remove
the temporary cloned image and the temporary snapshot
created on the parent image.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-24 08:16:59 +00:00
Madhu Rajanna
a7b65087af
rbd: fix return error message
...
incase of flattening error return the
flatten error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-24 08:16:59 +00:00
Madhu Rajanna
0bd45a5eb1
cephfs: use string const for cli error comparison
...
we should not return the CLI errors in GRPC errors
we need to return proper readable error messages
to the user for better understanding and better
debugging.
updates #1242
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 17:09:12 +00:00
Madhu Rajanna
27d2cc644d
util: replace klog with util logger in liveness.go
...
replace klog with util logger in liveness.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
ed289fea5e
journal: replace klog with util logger in voljournal.go
...
journal: replace klog with util logger in voljournal.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
1a9cd23f64
journal: replace klog with util logger in omap.go
...
replace klog with util logger in omap.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
7c9fee17af
rbd: replace klog with util logger in snapshot.go
...
rbd: replace klog with util logger in snapshot.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
9305e27797
rbd: replace klog with util logger in rbd_util.go
...
rbd: replace klog with util logger in rbd_util.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
90cc5a4fd0
rbd: replace klog with util logger in rbd_journal.go
...
replace klog with util logger in rbd_journal.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
9512aa6206
rbd: replace klog with util logger in rbd_attach.go
...
replace klog with util logger in rbd_attach.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
e768c0dfc0
rbd: replace klog with util logger in nodeserver.go
...
replace klog with util logger in nodeserver.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
883485b082
rbd: replace klog with util logger in driver.go
...
replace klog with util logger in driver.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
c4f30c23c1
rbd: replace klog with util logger in clone.go
...
replace klog with util logger in clone.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Madhu Rajanna
d8ca56fbe9
rbd: replace klog with util in controllerserver.go
...
replace klog with util in controllerserver.go
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-19 14:38:12 +00:00
Humble Chirammal
1f5b84745f
rbd: Bail out from nodeexpansion if its block mode pvc
...
At CSI spec < 1.2.0, there was no volumecapability in the
expand request. However its available from v1.2+ which allows
us to declare the node operations based on the volume mode.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-19 12:34:20 +00:00
Madhu Rajanna
787ba69089
cephfs: fix lock release in volumeDelete
...
currently the lock is not released which is
taken on the request name. this is causing issues
when the subvolume is requested for delete.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Madhu Rajanna
31c7c95fdb
cephfs: check error output contains Error: ENOENT
...
execCommandErr returns both error and stderror
message. checking strings.HasPrefix is not helpful
as the stderr will be the first string. its good
to do string comparison and find out that error
is volume not found error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Madhu Rajanna
f566b0fc2d
cephfs: replace Warningf with WarningLog in unmountVolume
...
replace Errorf with ErrorLog in unmountVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fe3d25dda
cephfs: replace Errorf with ErrorLogMsg in loadAvailableMounters
...
replace Errorf with ErrorLog in loadAvailableMounters
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
fbe090065d
cephfs: replace Errorf with ErrorLog in purgeVolume
...
replace Errorf with ErrorLog in purgeVolume
for context based logging
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5a1652e5e8
cephfs: replace Errorf with ErrorLog in resizeVolume
...
replace Errorf with ErrorLog in resizeVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
a882c1194b
cephfs: replace Errorf with ErrorLog in createVolume
...
replace Errorf with ErrorLog in createVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f3d9b8933b
cephfs: replace Errorf with ErrorLog in getSubVolumeInfo
...
replace Errorf with ErrorLog in getSubVolumeInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
2b7aade289
cephfs: replace Errorf with ErrorLog in getVolumeRootPathCeph
...
replace Errorf with ErrorLog in getVolumeRootPathCeph
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d1ac832266
cephfs: replace Errorf with ErrorLog in genSnapFromOptions
...
replace Errorf with ErrorLog in genSnapFromOptions
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e83a51c1e1
cephfs: replace Errorf with ErrorLog in parseTime
...
replace Errorf with ErrorLog in parseTime
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e7a043271d
cephfs: replace Errorf with ErrorLog in cloneSnapshot
...
replace Errorf with ErrorLog in cloneSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
841a3713f5
cephfs: replace Errorf with ErrorLog in unprotectSnapshot
...
replace Errorf with ErrorLog in unprotectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
91811c18c5
cephfs: replace Errorf with ErrorLog in protectSnapshot
...
replace Errorf with ErrorLog in protectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
72dfe6a265
cephfs: replace Errorf with ErrorLog in getSnapshotInfo
...
replace Errorf with ErrorLog in getSnapshotInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7e8cc41aca
cephfs: replace Errorf with ErrorLog in deleteSnapshot
...
replace Errorf with ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7f00fa66f4
cephfs: replace Errorf with ErrorLog in createSnapshot
...
replace Errorf with ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
57454cf379
cephfs: replace Errorf with ErrorLog in nodeUnstageVolume
...
replace Errorf with ErrorLog in nodeUnstageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
0a5581b7a0
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
...
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
79dbc41d14
cephfs: replace Errorf with ErrorLog in NodePublishVolume
...
replace Errorf with ErrorLog in NodePublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
48a313c6cc
cephfs: replace Errorf with ErrorLog in mount
...
replace Errorf with ErrorLog in mount for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
032901b8d0
cephfs: replace Errorf with ErrorLog in nodeStageVolume
...
replace Errorf with ErrorLog in nodeStageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
c57189382f
cephfs: replace Errorf with ErrorLog in checkSnapExists
...
replace Errorf with ErrorLog in checkSnapExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
98e97baa60
cephfs: replace Errorf with ErrorLog in checkVolExists
...
replace Errorf with ErrorLog in checkVolExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
abd548e420
cephfs: replace warning with WarningLogMsg in Run
...
replace warning with WarningLogMsg in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
38273f879f
cephfs: replace fatal with util.FatalLog in Run
...
replace fatal with util.FatalLog in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
eeb0859f99
util: rename FatalLog to FatalLogMsg for parity
...
rename FatalLog to FatalLogMsg to keep functions
in parity functions ends with Msg if its only message
logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
71a6dc3ba8
cephfs: replace Errorf with util.ErrorLog in getCloneInfo
...
replace Errorf with util.ErrorLog in getCloneInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
ae6b77f105
cephfs: add comment for exported CloneStatus struct
...
added comment for exported structure.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
18d65ba3f5
cephfs: replace Errorf with ErrorLog in createCloneFromSnapshot
...
replace Errorf with ErrorLog in createCloneFromSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fa512617b
cephfs: replace Errorf with util.ErrorLog in cleanupClone
...
replace Errorf with util.ErrorLog in cleanupCloneFromSubvolumeSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e1fb708d48
cephfs: replace Errorf with util.ErrorLog in createCloneFromSubvolume
...
replace Errorf with util.ErrorLog in createCloneFromSubvolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
20dbbe54b0
cephfs: replace klog.Warningf with util.WarningLog in deleteSnapshot
...
replace klog.Warningf with util.WarningLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7eefadf1eb
cephfs: replace klog.Warning with util.WarningLog in DeleteVolume
...
replace klog.Warning with util.WarningLog in DeleteVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e3c3bbf0e3
cephfs: replace klog.Warning with util.WarningLog in CreateVolume
...
replace klog.Warning with util.WarningLog in CreateVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00