Madhu Rajanna
e861f12a60
Fix review comments
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-02-26 14:35:16 +00:00
Madhu Rajanna
3b320ef19e
Add support of RBD list volumes
...
currently all the created volumes are
stored in the metadata store, so we
can use this information to support
list volumes.
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-26 14:35:16 +00:00
gman
d12fdfd400
rbd: fixed metadata idempotency in DeleteVolume; DeleteSnapshot should assume the snapshot to be already deleted if metadata doesn't exist
2019-02-25 18:09:21 +01:00
gman
ce3affcc6a
cephfs: DeleteVolume should assume the volume to be already deleted if metadata doesn't exist
2019-02-25 18:07:28 +01:00
gman
e5dbea15d3
util/cachepersister: check and return CacheEntryNotFound error in Get()
2019-02-25 18:05:20 +01:00
Huamin Chen
e627a6166c
Merge pull request #220 from Madhu-1/skip_cred_log
...
remove secret and key from logging
2019-02-25 08:04:38 -05:00
Madhu Rajanna
68e69502e8
remove secret and key from logging
...
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2019-02-21 17:05:24 +05:30
gman
0235b9c249
k8s metadata cache: delete shouldn't fail on NotFound errors
2019-02-20 20:20:44 +01:00
Róbert Vašek
bc256aa755
Merge pull request #211 from Madhu-1/clean-up
...
cleanup: remove duplicate code
2019-02-19 15:50:46 +01:00
Madhu Rajanna
fd4c019aba
cleanup: remove duplicate code
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-19 13:44:10 +05:30
Madhu Rajanna
e91a59d2f9
RBD: Remove dead code
...
during volume creation we are validating
that volume name cannot be empty,removing
this check as we are not going to hit
this case
Fixes : #204
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-19 12:17:40 +05:30
Madhu Rajanna
6fbde110cd
skip redundant error check
...
correct misspelled word
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-18 17:16:59 +05:30
gman
49f5d4a54e
fix lint error
2019-02-14 21:31:52 +00:00
gman
1803a1be97
rbd: don't delete volume/snapshot if metadata creation fails
2019-02-14 21:31:52 +00:00
gman
8223ae325b
addressed review comments
2019-02-14 13:55:51 +00:00
gman
96bf4a98bd
cephfs: don't need to store keyrings anymore
2019-02-14 13:55:51 +00:00
gman
8e371f62fa
cephfs: ceph-fuse mimic supports passing keys via args, let's use it
2019-02-14 13:55:51 +00:00
gman
b3944f3121
cephfs exec: read stdout and stderr separately
2019-02-14 13:55:51 +00:00
gman
892d65d387
added StripSecretInArgs in pkg/util
2019-02-14 13:55:51 +00:00
gman
a63b06a620
cephfs: specify monitors explicitly
2019-02-13 14:09:33 +00:00
gman
9cd0786569
cephfs/volume: fixed incorrect path for unmountAndRemove
2019-02-12 17:39:54 +01:00
gman
6099f142f0
moved klog initialization into pkg/util package
2019-02-12 16:31:55 +01:00
Huamin Chen
a195856104
Merge pull request #186 from Madhu-1/remove-glog
...
Remove glog from Gopkg.toml
2019-02-08 07:23:13 -05:00
Huamin Chen
9c4e5543c9
Merge pull request #185 from Madhu-1/log-req
...
Avoid logging secrets in request
2019-02-08 07:21:19 -05:00
Madhu Rajanna
bf7ec10fea
Remove glog from Gopkg.toml
...
replace klog with glog
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-08 13:51:22 +05:30
Madhu Rajanna
a5f2635bc0
avoid logging secrets in request
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-08 13:20:21 +05:30
Madhu Rajanna
f670c62526
Remove userID and key logging from rbd
...
Fixes : #171
2019-02-08 12:40:48 +05:30
Humble Chirammal
c0712db08a
migrate util package to klog from glog.
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-02-05 12:09:04 +00:00
Humble Chirammal
cb77ff5d87
Migrate rbd package to klog from glog
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-02-05 12:09:04 +00:00
Humble Chirammal
c9da8469ad
migrate cephfs code to use klog instead of glog
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-02-05 12:09:04 +00:00
Madhu Rajanna
5983fedddb
Fix issues found in gometalinter static check
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-02-04 10:44:37 +05:30
Madhu Rajanna
74796bd57b
Fix review comment
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 18:29:07 +05:30
Madhu Rajanna
03d93219d7
Fix metalinter issue
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:37:03 +05:30
Madhu Rajanna
50ba8ed446
Fix gometalinter issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:24:36 +05:30
Madhu Rajanna
ca2e475296
Fix gometalinter issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:23:50 +05:30
Madhu Rajanna
7a0c233c27
Fix issues found in gometalinter
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:20:35 +05:30
Madhu Rajanna
008c82c1e7
Fix gometalinter issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:20:35 +05:30
Madhu Rajanna
25642fe404
Add method comments
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-29 11:20:35 +05:30
Madhu Rajanna
b71a9bfe40
Fix issue with error handling in metadata store
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-28 10:26:57 +05:30
Huamin Chen
aa4fce2c8b
Merge pull request #133 from Madhu-1/fix-golint
...
Fix golint
2019-01-27 10:04:42 -05:00
Madhu Rajanna
48ca11336e
Fix snapshot time during snapshot create
...
Fixes : #146
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 19:09:35 +05:30
Madhu Rajanna
7fcbdfb945
Fix template to add userID
...
Fix Node server
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:20:32 +05:30
Madhu Rajanna
1a246f7bf3
simplify the error check
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:16:03 +05:30
Madhu Rajanna
36f99e36ca
Fix unparam issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:16:03 +05:30
Madhu Rajanna
284c5801c3
Fix golint issue
...
pkg/rbd/rbd.go:67:65⚠️ exported func NewNodeServer
returns unexported type *rbd.nodeServer, which can be
annoying to use (golint)
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:16:03 +05:30
Madhu Rajanna
4c564207c6
Fix error checking issue in json Decode
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:15:25 +05:30
Madhu Rajanna
1d11d0acc3
Fix lint issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:15:25 +05:30
Madhu Rajanna
5eb1974e38
Fix vetshadow issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:15:25 +05:30
Madhu Rajanna
75beccd8c0
Remove unused variable
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:14:48 +05:30
Madhu Rajanna
49c8fe5d50
Remove conversion which is not required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
2019-01-25 14:14:48 +05:30