mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-09-19 15:09:56 +00:00
3eb0fa5e21
Currently, we support mapOption: "krbd:v1,v2,v3;nbd:v1,v2,v3" - By omitting `krbd:` or `nbd:`, the option(s) apply to rbdDefaultMounter which is krbd. - A user can _override_ the options for a mounter by specifying `krbd:` or `nbd:`. mapOption: "v1,v2,v3;nbd:v1,v2,v3" is effectively the same as the 1st example. - Sections are split by `;`. - If users want to specify common options for both `krbd` and `nbd`, they should mention them twice. But in case if the krbd or nbd specifc options contian `:` within them, then the parsing is failing now. E0301 10:19:13.615111 7348 utils.go:200] ID: 63 Req-ID: 0001-0009-rook-ceph-0000000000000001-fd37c41b-9948-11ec-ad32-0242ac110004 GRPC error: badly formatted map/unmap options: "krbd:read_from_replica=localize,crush_location=zone:zone1;" This patch fix the above case where the options itself contain `:` delimitor ex: krbd:v1,v2,v3=v31:v32;nbd:v1,v2,v3" Please note, if you are using such options which contain `:` delimiter, then it is mandatory to specify the mounter-type. Fixes: #2910 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
107 lines
3.1 KiB
Go
107 lines
3.1 KiB
Go
/*
|
|
Copyright 2021 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbd
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseMapOptions(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
mapOption string
|
|
expectKrbdOptions string
|
|
expectNbdOptions string
|
|
expectErr string
|
|
}{
|
|
{
|
|
name: "with old format",
|
|
mapOption: "kOp1,kOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with new format",
|
|
mapOption: "krbd:kOp1,kOp2;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "without krbd: label",
|
|
mapOption: "kOp1,kOp2;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with only nbd label",
|
|
mapOption: "nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with `:` delimiter used with in the options",
|
|
mapOption: "krbd:kOp1,kOp2=kOp21:kOp22;nbd:nOp1,nOp2=nOp21:nOp22",
|
|
expectKrbdOptions: "kOp1,kOp2=kOp21:kOp22",
|
|
expectNbdOptions: "nOp1,nOp2=nOp21:nOp22",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with `:` delimiter used with in the options, without mounter label",
|
|
mapOption: "kOp1,kOp2=kOp21:kOp22;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "",
|
|
expectErr: "unknown mounter type",
|
|
},
|
|
{
|
|
name: "unknown mounter used",
|
|
mapOption: "xyz:xOp1,xOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "",
|
|
expectErr: "unknown mounter type",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tc := tt
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
krbdOpts, nbdOpts, err := parseMapOptions(tc.mapOption)
|
|
if err != nil && !strings.Contains(err.Error(), tc.expectErr) {
|
|
// returned error
|
|
t.Errorf("parseMapOptions(%s) returned error, expected: %v, got: %v",
|
|
tc.mapOption, tc.expectErr, err)
|
|
}
|
|
if krbdOpts != tc.expectKrbdOptions {
|
|
// unexpected krbd option error
|
|
t.Errorf("parseMapOptions(%s) returned unexpected krbd options, expected :%q, got: %q",
|
|
tc.mapOption, tc.expectKrbdOptions, krbdOpts)
|
|
}
|
|
if nbdOpts != tc.expectNbdOptions {
|
|
// unexpected nbd option error
|
|
t.Errorf("parseMapOptions(%s) returned unexpected nbd options, expected: %q, got: %q",
|
|
tc.mapOption, tc.expectNbdOptions, nbdOpts)
|
|
}
|
|
})
|
|
}
|
|
}
|