mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-12-23 21:40:20 +00:00
fa68c35f3b
This commit adds support to mount and delete volumes provisioned by older plugin versions (1.0.0) in order to support backward compatibility to 1.0.0 created volumes. It adds back the ability to specify where older meta data was specified, using the metadatastorage option to the plugin. Further, using the provided meta data to mount and delete the older volumes. It also supports a variety of ways in which monitor information may have been specified (in the storage class, or in the secret), to keep the monitor information current. Testing done: - Mount/Delete 1.0.0 plugin created volume with monitors in the StorageClass - Mount/Delete 1.0.0 plugin created volume with monitors in the secret with a key "monitors" - Mount/Delete 1.0.0 plugin created volume with monitors in the secret with a user specified key - PVC creation and deletion with the current version (to ensure at the minimum no broken functionality) - Tested some negative cases, where monitor information is missing in secrets or present with a different key name, to understand if failure scenarios work as expected Updates #378 Follow-up work: - Documentation on how to upgrade to 1.1 plugin and retain above functionality for older volumes Signed-off-by: ShyamsundarR <srangana@redhat.com>
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
/*
|
|
Copyright 2019 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbd
|
|
|
|
// ErrImageNotFound is returned when image name is not found in the cluster on the given pool
|
|
type ErrImageNotFound struct {
|
|
imageName string
|
|
err error
|
|
}
|
|
|
|
func (e ErrImageNotFound) Error() string {
|
|
return e.err.Error()
|
|
}
|
|
|
|
// ErrSnapNotFound is returned when snap name passed is not found in the list of snapshots for the
|
|
// given image
|
|
type ErrSnapNotFound struct {
|
|
snapName string
|
|
err error
|
|
}
|
|
|
|
func (e ErrSnapNotFound) Error() string {
|
|
return e.err.Error()
|
|
}
|
|
|
|
// ErrVolNameConflict is generated when a requested CSI volume name already exists on RBD but with
|
|
// different properties, and hence is in conflict with the passed in CSI volume name
|
|
type ErrVolNameConflict struct {
|
|
requestName string
|
|
err error
|
|
}
|
|
|
|
func (e ErrVolNameConflict) Error() string {
|
|
return e.err.Error()
|
|
}
|
|
|
|
// ErrInvalidVolID is returned when a CSI passed VolumeID does not conform to any known volume ID
|
|
// formats
|
|
type ErrInvalidVolID struct {
|
|
err error
|
|
}
|
|
|
|
func (e ErrInvalidVolID) Error() string {
|
|
return e.err.Error()
|
|
}
|