ceph-csi/internal/util/connection.go
Sven Anderson 8393fbe40b util: simplify error handling
The sentinel error code had additional fields in the errors, that are
used nowhere.  This leads to unneccesarily complicated code.  This
change replaces the sentinel errors in utils with standard errors
created with errors.New() and adds a simple JoinErrors() function to
be able to combine sentinel errors from different code tiers.

Related: #1203

Signed-off-by: Sven Anderson <sven@redhat.com>
2020-07-23 11:16:40 +00:00

86 lines
2.1 KiB
Go

/*
Copyright 2020 The Ceph-CSI Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package util
import (
"errors"
"fmt"
"time"
"github.com/ceph/go-ceph/rados"
)
type ClusterConnection struct {
// connection
conn *rados.Conn
// FIXME: temporary reference for credentials. Remove this when go-ceph
// is used for operations.
Creds *Credentials
}
var (
// large interval and timeout, it should be longer than the maximum
// time an operation can take (until refcounting of the connections is
// available)
cpInterval = 15 * time.Minute
cpExpiry = 10 * time.Minute
connPool = NewConnPool(cpInterval, cpExpiry)
)
// rbdVol.Connect() connects to the Ceph cluster and sets rbdVol.conn for further usage.
func (cc *ClusterConnection) Connect(monitors string, cr *Credentials) error {
if cc.conn == nil {
conn, err := connPool.Get(monitors, cr.ID, cr.KeyFile)
if err != nil {
return fmt.Errorf("failed to get connection: %w", err)
}
cc.conn = conn
// FIXME: remove .Creds from ClusterConnection
cc.Creds = cr
}
return nil
}
func (cc *ClusterConnection) Destroy() {
if cc.conn != nil {
connPool.Put(cc.conn)
}
}
func (cc *ClusterConnection) GetIoctx(pool string) (*rados.IOContext, error) {
if cc.conn == nil {
return nil, errors.New("cluster is not connected yet")
}
ioctx, err := cc.conn.OpenIOContext(pool)
if err != nil {
// ErrNotFound indicates the Pool was not found
if errors.Is(err, rados.ErrNotFound) {
err = JoinErrors(ErrPoolNotFound, err)
} else {
err = fmt.Errorf("failed to open IOContext for pool %s: %w", pool, err)
}
return nil, err
}
return ioctx, nil
}