mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-26 16:20:28 +00:00
8f25edc888
As per the csiaddon spec last sync time is required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, return not found error message instead of nil which is empty response Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
495 lines
11 KiB
Go
495 lines
11 KiB
Go
/*
|
|
Copyright 2021 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbd
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
librbd "github.com/ceph/go-ceph/rbd"
|
|
"github.com/ceph/go-ceph/rbd/admin"
|
|
"google.golang.org/protobuf/types/known/timestamppb"
|
|
)
|
|
|
|
func TestValidateSchedulingInterval(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
interval string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
"valid interval in minutes",
|
|
"3m",
|
|
false,
|
|
},
|
|
{
|
|
"valid interval in hour",
|
|
"22h",
|
|
false,
|
|
},
|
|
{
|
|
"valid interval in days",
|
|
"13d",
|
|
false,
|
|
},
|
|
{
|
|
"invalid interval without number",
|
|
"d",
|
|
true,
|
|
},
|
|
{
|
|
"invalid interval without (m|h|d) suffix",
|
|
"12",
|
|
true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
err := validateSchedulingInterval(tt.interval)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("validateSchedulingInterval() error = %v, wantErr %v", err, tt.wantErr)
|
|
|
|
return
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateSchedulingDetails(t *testing.T) {
|
|
t.Parallel()
|
|
ctx := context.TODO()
|
|
tests := []struct {
|
|
name string
|
|
parameters map[string]string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
"valid parameters",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
schedulingIntervalKey: "1h",
|
|
schedulingStartTimeKey: "14:00:00-05:00",
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"valid parameters when optional startTime is missing",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
schedulingIntervalKey: "1h",
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"when mirroring mode is journal",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeJournal),
|
|
schedulingIntervalKey: "1h",
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"when startTime is specified without interval",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
schedulingStartTimeKey: "14:00:00-05:00",
|
|
},
|
|
true,
|
|
},
|
|
{
|
|
"when no scheduling is specified",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"when no parameters and scheduling details are specified",
|
|
map[string]string{},
|
|
false,
|
|
},
|
|
{
|
|
"when no mirroring mode is specified",
|
|
map[string]string{
|
|
schedulingIntervalKey: "1h",
|
|
schedulingStartTimeKey: "14:00:00-05:00",
|
|
},
|
|
false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
err := validateSchedulingDetails(ctx, tt.parameters)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("getSchedulingDetails() error = %v, wantErr %v", err, tt.wantErr)
|
|
|
|
return
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetSchedulingDetails(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
parameters map[string]string
|
|
wantInterval admin.Interval
|
|
wantStartTime admin.StartTime
|
|
}{
|
|
{
|
|
"valid parameters",
|
|
map[string]string{
|
|
schedulingIntervalKey: "1h",
|
|
schedulingStartTimeKey: "14:00:00-05:00",
|
|
},
|
|
admin.Interval("1h"),
|
|
admin.StartTime("14:00:00-05:00"),
|
|
},
|
|
{
|
|
"valid parameters when optional startTime is missing",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
schedulingIntervalKey: "1h",
|
|
},
|
|
admin.Interval("1h"),
|
|
admin.NoStartTime,
|
|
},
|
|
{
|
|
"when startTime is specified without interval",
|
|
map[string]string{
|
|
imageMirroringKey: string(imageMirrorModeSnapshot),
|
|
schedulingStartTimeKey: "14:00:00-05:00",
|
|
},
|
|
admin.NoInterval,
|
|
admin.StartTime("14:00:00-05:00"),
|
|
},
|
|
{
|
|
"when no parameters and scheduling details are specified",
|
|
map[string]string{},
|
|
admin.NoInterval,
|
|
admin.NoStartTime,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
interval, startTime := getSchedulingDetails(tt.parameters)
|
|
if !reflect.DeepEqual(interval, tt.wantInterval) {
|
|
t.Errorf("getSchedulingDetails() interval = %v, want %v", interval, tt.wantInterval)
|
|
}
|
|
if !reflect.DeepEqual(startTime, tt.wantStartTime) {
|
|
t.Errorf("getSchedulingDetails() startTime = %v, want %v", startTime, tt.wantStartTime)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCheckVolumeResyncStatus(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
args librbd.SiteMirrorImageStatus
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "test when rbd mirror daemon is not running",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: false,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for unknown state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "test for error state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateError,
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for syncing state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateSyncing,
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for starting_replay state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateStartingReplay,
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for replaying state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateReplaying,
|
|
Up: true,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "test for stopping_replay state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateStoppingReplay,
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for stopped state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusStateStopped,
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "test for invalid state",
|
|
args: librbd.SiteMirrorImageStatus{
|
|
State: librbd.MirrorImageStatusState(100),
|
|
Up: true,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
ts := tt
|
|
t.Run(ts.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
if err := checkVolumeResyncStatus(ts.args); (err != nil) != ts.wantErr {
|
|
t.Errorf("checkVolumeResyncStatus() error = %v, expect error = %v", err, ts.wantErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCheckRemoteSiteStatus(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
args librbd.GlobalMirrorImageStatus
|
|
wantReady bool
|
|
}{
|
|
{
|
|
name: "Test a single peer in sync",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
},
|
|
},
|
|
wantReady: true,
|
|
},
|
|
{
|
|
name: "Test a single peer in sync, including a local instance",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
{
|
|
MirrorUUID: "",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
},
|
|
},
|
|
wantReady: true,
|
|
},
|
|
{
|
|
name: "Test a multiple peers in sync",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote1",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
{
|
|
MirrorUUID: "remote2",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
},
|
|
},
|
|
wantReady: true,
|
|
},
|
|
{
|
|
name: "Test no remote peers",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{},
|
|
},
|
|
wantReady: false,
|
|
},
|
|
{
|
|
name: "Test single peer not in sync",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote",
|
|
State: librbd.MirrorImageStatusStateReplaying,
|
|
Up: true,
|
|
},
|
|
},
|
|
},
|
|
wantReady: false,
|
|
},
|
|
{
|
|
name: "Test single peer not up",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: false,
|
|
},
|
|
},
|
|
},
|
|
wantReady: false,
|
|
},
|
|
{
|
|
name: "Test multiple peers, when first peer is not in sync",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote1",
|
|
State: librbd.MirrorImageStatusStateStoppingReplay,
|
|
Up: true,
|
|
},
|
|
{
|
|
MirrorUUID: "remote2",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
},
|
|
},
|
|
wantReady: false,
|
|
},
|
|
{
|
|
name: "Test multiple peers, when second peer is not up",
|
|
args: librbd.GlobalMirrorImageStatus{
|
|
SiteStatuses: []librbd.SiteMirrorImageStatus{
|
|
{
|
|
MirrorUUID: "remote1",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: true,
|
|
},
|
|
{
|
|
MirrorUUID: "remote2",
|
|
State: librbd.MirrorImageStatusStateUnknown,
|
|
Up: false,
|
|
},
|
|
},
|
|
},
|
|
wantReady: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
ts := tt
|
|
t.Run(ts.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
if ready := checkRemoteSiteStatus(context.TODO(), &ts.args); ready != ts.wantReady {
|
|
t.Errorf("checkRemoteSiteStatus() ready = %v, expect ready = %v", ready, ts.wantReady)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateLastSyncTime(t *testing.T) {
|
|
t.Parallel()
|
|
tests := []struct {
|
|
name string
|
|
description string
|
|
timestamp *timestamppb.Timestamp
|
|
expectedErr string
|
|
}{
|
|
{
|
|
"valid description",
|
|
//nolint:lll // sample output cannot be split into multiple lines.
|
|
`replaying,{"bytes_per_second":0.0,"bytes_per_snapshot":149504.0,"local_snapshot_timestamp":1662655501,"remote_snapshot_timestamp":1662655501}`,
|
|
timestamppb.New(time.Unix(1662655501, 0)),
|
|
"",
|
|
},
|
|
{
|
|
"empty description",
|
|
"",
|
|
nil,
|
|
ErrLastSyncTimeNotFound.Error(),
|
|
},
|
|
{
|
|
"description without local_snapshot_timestamp",
|
|
`replaying,{"bytes_per_second":0.0,"bytes_per_snapshot":149504.0,"remote_snapshot_timestamp":1662655501}`,
|
|
nil,
|
|
"",
|
|
},
|
|
{
|
|
"description with invalid JSON",
|
|
`replaying,{"bytes_per_second":0.0,"bytes_per_snapshot":149504.0","remote_snapshot_timestamp":1662655501`,
|
|
nil,
|
|
"failed to unmarshal",
|
|
},
|
|
{
|
|
"description with no JSON",
|
|
`replaying`,
|
|
nil,
|
|
ErrLastSyncTimeNotFound.Error(),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
ts, err := getLastSyncTime(tt.description)
|
|
if err != nil && !strings.Contains(err.Error(), tt.expectedErr) {
|
|
// returned error
|
|
t.Errorf("getLastSyncTime() returned error, expected: %v, got: %v",
|
|
tt.expectedErr, err)
|
|
}
|
|
if !ts.AsTime().Equal(tt.timestamp.AsTime()) {
|
|
t.Errorf("getLastSyncTime() %v, expected %v", ts, tt.timestamp)
|
|
}
|
|
})
|
|
}
|
|
}
|