mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-30 18:20:19 +00:00
5c0f9d565e
In case the NFS-export has already been removed from the NFS-server, but
the CSI Controller was restarted, a retry to remove the NFS-volume will
fail with an error like:
> GRPC error: ....: response status not empty: "Export does not exist"
When this error is reported, assume the NFS-export was already removed
from the NFS-server configuration, and continue with deleting the
backend volume.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
(cherry picked from commit 9d7faf850f
)
153 lines
4.8 KiB
Go
153 lines
4.8 KiB
Go
/*
|
|
Copyright 2022 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package controller
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
"github.com/ceph/ceph-csi/internal/cephfs"
|
|
"github.com/ceph/ceph-csi/internal/cephfs/store"
|
|
fsutil "github.com/ceph/ceph-csi/internal/cephfs/util"
|
|
csicommon "github.com/ceph/ceph-csi/internal/csi-common"
|
|
"github.com/ceph/ceph-csi/internal/journal"
|
|
"github.com/ceph/ceph-csi/internal/util"
|
|
"github.com/ceph/ceph-csi/internal/util/log"
|
|
|
|
"github.com/container-storage-interface/spec/lib/go/csi"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
// Server struct of CEPH CSI driver with supported methods of CSI controller
|
|
// server spec.
|
|
type Server struct {
|
|
csi.UnimplementedControllerServer
|
|
|
|
// backendServer handles the CephFS requests
|
|
backendServer *cephfs.ControllerServer
|
|
}
|
|
|
|
// NewControllerServer initialize a controller server for ceph CSI driver.
|
|
func NewControllerServer(d *csicommon.CSIDriver) *Server {
|
|
// global instance of the volume journal, yuck
|
|
store.VolJournal = journal.NewCSIVolumeJournalWithNamespace(cephfs.CSIInstanceID, fsutil.RadosNamespace)
|
|
|
|
return &Server{
|
|
backendServer: cephfs.NewControllerServer(d),
|
|
}
|
|
}
|
|
|
|
// ControllerGetCapabilities uses the CephFS backendServer to return the
|
|
// capabilities that were set in the Driver.Run() function.
|
|
func (cs *Server) ControllerGetCapabilities(
|
|
ctx context.Context,
|
|
req *csi.ControllerGetCapabilitiesRequest) (*csi.ControllerGetCapabilitiesResponse, error) {
|
|
return cs.backendServer.ControllerGetCapabilities(ctx, req)
|
|
}
|
|
|
|
// ValidateVolumeCapabilities checks whether the volume capabilities requested
|
|
// are supported.
|
|
func (cs *Server) ValidateVolumeCapabilities(
|
|
ctx context.Context,
|
|
req *csi.ValidateVolumeCapabilitiesRequest) (*csi.ValidateVolumeCapabilitiesResponse, error) {
|
|
return cs.backendServer.ValidateVolumeCapabilities(ctx, req)
|
|
}
|
|
|
|
// CreateVolume creates the backing subvolume and on any error cleans up any
|
|
// created entities.
|
|
func (cs *Server) CreateVolume(
|
|
ctx context.Context,
|
|
req *csi.CreateVolumeRequest) (*csi.CreateVolumeResponse, error) {
|
|
res, err := cs.backendServer.CreateVolume(ctx, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
backend := res.Volume
|
|
|
|
log.DebugLog(ctx, "CephFS volume created: %s", backend.VolumeId)
|
|
|
|
secret := req.GetSecrets()
|
|
cr, err := util.NewAdminCredentials(secret)
|
|
if err != nil {
|
|
log.ErrorLog(ctx, "failed to retrieve admin credentials: %v", err)
|
|
|
|
return nil, status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
defer cr.DeleteCredentials()
|
|
|
|
nfsVolume, err := NewNFSVolume(ctx, backend.VolumeId)
|
|
if err != nil {
|
|
return nil, status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
|
|
err = nfsVolume.Connect(cr)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.InvalidArgument, "failed to connect: %v", err)
|
|
}
|
|
defer nfsVolume.Destroy()
|
|
|
|
err = nfsVolume.CreateExport(backend)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.InvalidArgument, "failed to create export: %v", err)
|
|
}
|
|
|
|
log.DebugLog(ctx, "published NFS-export: %s", nfsVolume)
|
|
|
|
// volume has been exported over NFS, set the "share" parameter to
|
|
// allow mounting
|
|
backend.VolumeContext["share"] = nfsVolume.GetExportPath()
|
|
|
|
return &csi.CreateVolumeResponse{Volume: backend}, nil
|
|
}
|
|
|
|
// DeleteVolume deletes the volume in backend and its reservation.
|
|
func (cs *Server) DeleteVolume(
|
|
ctx context.Context,
|
|
req *csi.DeleteVolumeRequest) (*csi.DeleteVolumeResponse, error) {
|
|
secret := req.GetSecrets()
|
|
cr, err := util.NewAdminCredentials(secret)
|
|
if err != nil {
|
|
log.ErrorLog(ctx, "failed to retrieve admin credentials: %v", err)
|
|
|
|
return nil, status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
defer cr.DeleteCredentials()
|
|
|
|
nfsVolume, err := NewNFSVolume(ctx, req.GetVolumeId())
|
|
if err != nil {
|
|
return nil, status.Error(codes.InvalidArgument, err.Error())
|
|
}
|
|
|
|
err = nfsVolume.Connect(cr)
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.InvalidArgument, "failed to connect: %v", err)
|
|
}
|
|
defer nfsVolume.Destroy()
|
|
|
|
err = nfsVolume.DeleteExport()
|
|
// if the export does not exist, continue with deleting the backend volume
|
|
if err != nil && !strings.Contains(err.Error(), "Export does not exist") {
|
|
return nil, status.Errorf(codes.InvalidArgument, "failed to delete export: %v", err)
|
|
}
|
|
|
|
log.DebugLog(ctx, "deleted NFS-export: %s", nfsVolume)
|
|
|
|
return cs.backendServer.DeleteVolume(ctx, req)
|
|
}
|