mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-10 00:10:20 +00:00
2192d40937
When people have reviewed a PR, and the contributor updates it, the reviews are staying valid. This is unfortunate as the PR might need new corrections. Ideally a positive review (Approved) needs to be given again. And there needs to be a confirmation that a negative review (Changes requested) has been addressed. Closes: #505 Signed-off-by: Niels de Vos <ndevos@redhat.com>
22 lines
501 B
YAML
22 lines
501 B
YAML
---
|
|
pull_request_rules:
|
|
- name: remove outdated approvals
|
|
conditions:
|
|
- base=master
|
|
actions:
|
|
dismiss_reviews:
|
|
approved: true
|
|
changes_requested: false
|
|
- name: automatic merge
|
|
conditions:
|
|
- label!=DNM
|
|
- '#approved-reviews-by>=2'
|
|
- 'status-success=continuous-integration/travis-ci/pr'
|
|
actions:
|
|
merge:
|
|
method: rebase
|
|
rebase_fallback: merge
|
|
strict: smart
|
|
dismiss_reviews: {}
|
|
delete_head_branch: {}
|