mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-12-18 11:00:25 +00:00
0e7b06e9d0
golangci-lint reports these:
The copy of the 'for' variable "kmsID" can be deleted (Go 1.22+)
(copyloopvar)
Signed-off-by: Niels de Vos <ndevos@ibm.com>
106 lines
3.0 KiB
Go
106 lines
3.0 KiB
Go
/*
|
|
Copyright 2021 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbd
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseMapOptions(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
mapOption string
|
|
expectKrbdOptions string
|
|
expectNbdOptions string
|
|
expectErr string
|
|
}{
|
|
{
|
|
name: "with old format",
|
|
mapOption: "kOp1,kOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with new format",
|
|
mapOption: "krbd:kOp1,kOp2;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "without krbd: label",
|
|
mapOption: "kOp1,kOp2;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "kOp1,kOp2",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with only nbd label",
|
|
mapOption: "nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "nOp1,nOp2",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with `:` delimiter used with in the options",
|
|
mapOption: "krbd:kOp1,kOp2=kOp21:kOp22;nbd:nOp1,nOp2=nOp21:nOp22",
|
|
expectKrbdOptions: "kOp1,kOp2=kOp21:kOp22",
|
|
expectNbdOptions: "nOp1,nOp2=nOp21:nOp22",
|
|
expectErr: "",
|
|
},
|
|
{
|
|
name: "with `:` delimiter used with in the options, without mounter label",
|
|
mapOption: "kOp1,kOp2=kOp21:kOp22;nbd:nOp1,nOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "",
|
|
expectErr: "unknown mounter type",
|
|
},
|
|
{
|
|
name: "unknown mounter used",
|
|
mapOption: "xyz:xOp1,xOp2",
|
|
expectKrbdOptions: "",
|
|
expectNbdOptions: "",
|
|
expectErr: "unknown mounter type",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
krbdOpts, nbdOpts, err := parseMapOptions(tt.mapOption)
|
|
if err != nil && !strings.Contains(err.Error(), tt.expectErr) {
|
|
// returned error
|
|
t.Errorf("parseMapOptions(%s) returned error, expected: %v, got: %v",
|
|
tt.mapOption, tt.expectErr, err)
|
|
}
|
|
if krbdOpts != tt.expectKrbdOptions {
|
|
// unexpected krbd option error
|
|
t.Errorf("parseMapOptions(%s) returned unexpected krbd options, expected :%q, got: %q",
|
|
tt.mapOption, tt.expectKrbdOptions, krbdOpts)
|
|
}
|
|
if nbdOpts != tt.expectNbdOptions {
|
|
// unexpected nbd option error
|
|
t.Errorf("parseMapOptions(%s) returned unexpected nbd options, expected: %q, got: %q",
|
|
tt.mapOption, tt.expectNbdOptions, nbdOpts)
|
|
}
|
|
})
|
|
}
|
|
}
|