mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-30 02:00:19 +00:00
bd204d7d45
Every Ceph CLI that is invoked at present passes the key via the --key option, and hence is exposed to key being displayed on the host using a ps command or such means. This commit addresses this issue by stashing the key in a tmp file, which is again created on a tmpfs (or empty dir backed by memory). Further using such tmp files as arguments to the --keyfile option for every CLI that is invoked. This prevents the key from being visible as part of the argument list of the invoked program on the system. Fixes: #318 Signed-off-by: ShyamsundarR <srangana@redhat.com>
48 lines
1.3 KiB
Go
48 lines
1.3 KiB
Go
/*
|
|
Copyright 2018 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cephfs
|
|
|
|
import (
|
|
"github.com/ceph/ceph-csi/pkg/util"
|
|
)
|
|
|
|
const (
|
|
cephUserPrefix = "user-"
|
|
cephEntityClientPrefix = "client."
|
|
)
|
|
|
|
func genUserIDs(adminCr *util.Credentials, volID volumeID) (adminID, userID string) {
|
|
return cephEntityClientPrefix + adminCr.ID, cephEntityClientPrefix + getCephUserName(volID)
|
|
}
|
|
|
|
func getCephUserName(volID volumeID) string {
|
|
return cephUserPrefix + string(volID)
|
|
}
|
|
|
|
func deleteCephUserDeprecated(volOptions *volumeOptions, adminCr *util.Credentials, volID volumeID) error {
|
|
adminID, userID := genUserIDs(adminCr, volID)
|
|
|
|
// TODO: Need to return success if userID is not found
|
|
return execCommandErr("ceph",
|
|
"-m", volOptions.Monitors,
|
|
"-n", adminID,
|
|
"--keyfile="+adminCr.KeyFile,
|
|
"-c", util.CephConfigPath,
|
|
"auth", "rm", userID,
|
|
)
|
|
}
|