mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-14 10:20:20 +00:00
1c59f0683e
when a Snapshot is encrypted during a CreateSnapshot
operation, the encryption key gets created in the KMS
when we delete the Snapshot the key from the KMS
should also gets deleted.
When we create a volume from snapshot we are copying
required information but we missed to copy the
encryption information, This commit adds the missing
information to delete the encryption key.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit c3bae17fce)
108 lines
3.4 KiB
Go
108 lines
3.4 KiB
Go
/*
|
|
Copyright 2020 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package rbd
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/ceph/ceph-csi/internal/util"
|
|
)
|
|
|
|
func createRBDClone(ctx context.Context, parentVol, cloneRbdVol *rbdVolume, snap *rbdSnapshot, cr *util.Credentials) error {
|
|
// create snapshot
|
|
err := parentVol.createSnapshot(ctx, snap)
|
|
if err != nil {
|
|
util.ErrorLog(ctx, "failed to create snapshot %s: %v", snap, err)
|
|
return err
|
|
}
|
|
|
|
snap.RbdImageName = parentVol.RbdImageName
|
|
// create clone image and delete snapshot
|
|
err = cloneRbdVol.cloneRbdImageFromSnapshot(ctx, snap)
|
|
if err != nil {
|
|
util.ErrorLog(ctx, "failed to clone rbd image %s from snapshot %s: %v", cloneRbdVol.RbdImageName, snap.RbdSnapName, err)
|
|
err = fmt.Errorf("failed to clone rbd image %s from snapshot %s: %w", cloneRbdVol.RbdImageName, snap.RbdSnapName, err)
|
|
}
|
|
errSnap := parentVol.deleteSnapshot(ctx, snap)
|
|
if errSnap != nil {
|
|
util.ErrorLog(ctx, "failed to delete snapshot: %v", errSnap)
|
|
delErr := deleteImage(ctx, cloneRbdVol, cr)
|
|
if delErr != nil {
|
|
util.ErrorLog(ctx, "failed to delete rbd image: %s with error: %v", cloneRbdVol, delErr)
|
|
}
|
|
return err
|
|
}
|
|
|
|
err = cloneRbdVol.getImageInfo()
|
|
if err != nil {
|
|
util.ErrorLog(ctx, "failed to get rbd image: %s details with error: %v", cloneRbdVol, err)
|
|
delErr := deleteImage(ctx, cloneRbdVol, cr)
|
|
if delErr != nil {
|
|
util.ErrorLog(ctx, "failed to delete rbd image: %s with error: %v", cloneRbdVol, delErr)
|
|
}
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func cleanUpSnapshot(ctx context.Context, parentVol *rbdVolume, rbdSnap *rbdSnapshot, rbdVol *rbdVolume, cr *util.Credentials) error {
|
|
err := parentVol.deleteSnapshot(ctx, rbdSnap)
|
|
if err != nil {
|
|
if !errors.Is(err, ErrSnapNotFound) {
|
|
util.ErrorLog(ctx, "failed to delete snapshot: %v", err)
|
|
return err
|
|
}
|
|
}
|
|
err = deleteImage(ctx, rbdVol, cr)
|
|
if err != nil {
|
|
if !errors.Is(err, ErrImageNotFound) {
|
|
util.ErrorLog(ctx, "failed to delete rbd image: %s/%s with error: %v", rbdVol.Pool, rbdVol.VolName, err)
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func generateVolFromSnap(rbdSnap *rbdSnapshot) *rbdVolume {
|
|
vol := new(rbdVolume)
|
|
vol.ClusterID = rbdSnap.ClusterID
|
|
vol.VolID = rbdSnap.VolID
|
|
vol.Monitors = rbdSnap.Monitors
|
|
vol.Pool = rbdSnap.Pool
|
|
vol.JournalPool = rbdSnap.JournalPool
|
|
vol.RadosNamespace = rbdSnap.RadosNamespace
|
|
vol.RbdImageName = rbdSnap.RbdSnapName
|
|
vol.ImageID = rbdSnap.ImageID
|
|
// copyEncryptionConfig cannot be used here because the volume and the
|
|
// snapshot will have the same volumeID which cases the panic in
|
|
// copyEncryptionConfig function.
|
|
vol.encryption = rbdSnap.encryption
|
|
return vol
|
|
}
|
|
|
|
func undoSnapshotCloning(ctx context.Context, parentVol *rbdVolume, rbdSnap *rbdSnapshot, cloneVol *rbdVolume, cr *util.Credentials) error {
|
|
err := cleanUpSnapshot(ctx, parentVol, rbdSnap, cloneVol, cr)
|
|
if err != nil {
|
|
util.ErrorLog(ctx, "failed to clean up %s or %s: %v", cloneVol, rbdSnap, err)
|
|
return err
|
|
}
|
|
err = undoSnapReservation(ctx, rbdSnap, cr)
|
|
return err
|
|
}
|