mirror of
https://github.com/ceph/ceph-csi.git
synced 2025-03-09 08:59:30 +00:00
c1b3325677
This commit includes: 1). Moves rbd errors from internal/util/errors to internal/rbd/errors. 2). Introduces ShouldRetryVolumeGroupGeneration helper function to determine whether volume group generation should continue based on specific error types. The function returns true if the error is of type ErrPoolNotFound, ErrRBDGroupNotFound, ErrPermissionDenied. (Ceph user might not have access to all the objects/pools where mapping exists) Signed-off-by: Praveen M <m.praveen@ibm.com>
74 lines
1.9 KiB
Go
74 lines
1.9 KiB
Go
/*
|
|
Copyright 2025 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package group
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
rbd_errors "github.com/ceph/ceph-csi/internal/rbd/errors"
|
|
"github.com/ceph/ceph-csi/internal/util"
|
|
|
|
"github.com/ceph/go-ceph/rados"
|
|
)
|
|
|
|
func Test_shouldRetryVolumeGroupGeneration(t *testing.T) {
|
|
t.Parallel()
|
|
type args struct {
|
|
err error
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want bool
|
|
}{
|
|
{
|
|
name: "No error (stop searching)",
|
|
args: args{err: nil},
|
|
want: false, // No error, stop searching
|
|
},
|
|
{
|
|
name: "ErrPoolNotFound (continue searching)",
|
|
args: args{err: util.ErrPoolNotFound},
|
|
want: true, // Known error, continue searching
|
|
},
|
|
{
|
|
name: "ErrRBDGroupNotFound (continue searching)",
|
|
args: args{err: rbd_errors.ErrRBDGroupNotFound},
|
|
want: true, // Known error, continue searching
|
|
},
|
|
{
|
|
name: "ErrPermissionDenied (continue searching)",
|
|
args: args{err: rados.ErrPermissionDenied},
|
|
want: true, // Known error, continue searching
|
|
},
|
|
{
|
|
name: "Different error (stop searching)",
|
|
args: args{err: errors.New("unknown error")},
|
|
want: false, // Unknown error, stop searching
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
if got := ShouldRetryVolumeGroupGeneration(tt.args.err); got != tt.want {
|
|
t.Errorf("ShouldRetryVolumeGeneration() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|