mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-27 00:30:18 +00:00
6d3e25f069
Following the CSI specification, values that are included in the
VolumeUsage MUST NOT be negative. However, CephFS seems to return -1 for
the number of inodes that are available. Instead of returning a
negative value, set it to 0 so that it will not get included in the
encoded JSON response.
Updates: #2579
See-also: 5b0d454015/spec.md (L2477-L2487)
Signed-off-by: Niels de Vos <ndevos@redhat.com>
119 lines
2.7 KiB
Go
119 lines
2.7 KiB
Go
/*
|
|
Copyright 2019 ceph-csi authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package csicommon
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/container-storage-interface/spec/lib/go/csi"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var fakeID = "fake-id"
|
|
|
|
func TestGetReqID(t *testing.T) {
|
|
t.Parallel()
|
|
req := []interface{}{
|
|
&csi.CreateVolumeRequest{
|
|
Name: fakeID,
|
|
},
|
|
&csi.DeleteVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.CreateSnapshotRequest{
|
|
Name: fakeID,
|
|
},
|
|
&csi.DeleteSnapshotRequest{
|
|
SnapshotId: fakeID,
|
|
},
|
|
|
|
&csi.ControllerExpandVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.NodeStageVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.NodeUnstageVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.NodePublishVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.NodeUnpublishVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
&csi.NodeExpandVolumeRequest{
|
|
VolumeId: fakeID,
|
|
},
|
|
}
|
|
for _, r := range req {
|
|
if got := getReqID(r); got != fakeID {
|
|
t.Errorf("getReqID() = %v, want %v", got, fakeID)
|
|
}
|
|
}
|
|
|
|
// test for nil request
|
|
if got := getReqID(nil); got != "" {
|
|
t.Errorf("getReqID() = %v, want empty string", got)
|
|
}
|
|
}
|
|
|
|
func TestFilesystemNodeGetVolumeStats(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// ideally this is tested on different filesystems, including CephFS,
|
|
// but we'll settle for the filesystem where the project is checked out
|
|
cwd, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
|
|
// retry until a mountpoint is found
|
|
for {
|
|
stats, err := FilesystemNodeGetVolumeStats(context.TODO(), cwd)
|
|
if err != nil && cwd != "/" && strings.HasSuffix(err.Error(), "is not mounted") {
|
|
// try again with the parent directory
|
|
cwd = filepath.Dir(cwd)
|
|
|
|
continue
|
|
}
|
|
|
|
require.NoError(t, err)
|
|
assert.NotEqual(t, len(stats.Usage), 0)
|
|
for _, usage := range stats.Usage {
|
|
assert.NotEqual(t, usage.Available, -1)
|
|
assert.NotEqual(t, usage.Total, -1)
|
|
assert.NotEqual(t, usage.Used, -1)
|
|
assert.NotEqual(t, usage.Unit, 0)
|
|
}
|
|
|
|
// tests done, no need to retry again
|
|
break
|
|
}
|
|
}
|
|
|
|
func TestRequirePositive(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
assert.Equal(t, requirePositive(0), int64(0))
|
|
assert.Equal(t, requirePositive(-1), int64(0))
|
|
assert.Equal(t, requirePositive(1), int64(1))
|
|
}
|