mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-24 15:20:19 +00:00
1c02e69ba4
This PR modifies the execCryptSetupCommand so that the process is killed in an event of lock timeout. Useful in cases where the volume lock is released but the command is still running. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
271 lines
7.6 KiB
Go
271 lines
7.6 KiB
Go
/*
|
|
Copyright 2019 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cryptsetup
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/ceph/ceph-csi/internal/util/file"
|
|
"github.com/ceph/ceph-csi/internal/util/log"
|
|
"github.com/ceph/ceph-csi/internal/util/stripsecrets"
|
|
)
|
|
|
|
const (
|
|
// Maximum time to wait for cryptsetup commands to complete.
|
|
ExecutionTimeout = 2*time.Minute + 30*time.Second
|
|
|
|
// Limit memory used by Argon2i PBKDF to 32 MiB.
|
|
pkdbfMemoryLimit = 32 << 10 // 32768 KiB
|
|
)
|
|
|
|
// LuksWrapper is a struct that provides a context-aware wrapper around cryptsetup commands.
|
|
type LUKSWrapper interface {
|
|
Format(devicePath, passphrase string) (string, string, error)
|
|
Open(devicePath, mapperFile, passphrase string) (string, string, error)
|
|
Close(mapperFile string) (string, string, error)
|
|
AddKey(devicePath, passphrase, newPassphrase, slot string) error
|
|
RemoveKey(devicePath, passphrase, slot string) error
|
|
Resize(mapperFile string) (string, string, error)
|
|
VerifyKey(devicePath, passphrase, slot string) (bool, error)
|
|
Status(mapperFile string) (string, string, error)
|
|
}
|
|
|
|
// luksWrapper is a type that implements LUKSWrapper interface
|
|
// and provides a shared context for its methods.
|
|
type luksWrapper struct {
|
|
ctx context.Context
|
|
}
|
|
|
|
// NewLUKSWrapper creates a new LUKSWrapper instance with the provided context.
|
|
// The context is used to control the lifetime of the cryptsetup commands.
|
|
func NewLUKSWrapper(ctx context.Context) LUKSWrapper {
|
|
return &luksWrapper{ctx: ctx}
|
|
}
|
|
|
|
// LuksFormat sets up volume as an encrypted LUKS partition.
|
|
func (l *luksWrapper) Format(devicePath, passphrase string) (string, string, error) {
|
|
return l.execCryptsetupCommand(
|
|
&passphrase,
|
|
"-q",
|
|
"luksFormat",
|
|
"--type",
|
|
"luks2",
|
|
"--hash",
|
|
"sha256",
|
|
"--pbkdf-memory",
|
|
strconv.Itoa(pkdbfMemoryLimit),
|
|
devicePath,
|
|
"-d",
|
|
"/dev/stdin")
|
|
}
|
|
|
|
// LuksOpen opens LUKS encrypted partition and sets up a mapping.
|
|
func (l *luksWrapper) Open(devicePath, mapperFile, passphrase string) (string, string, error) {
|
|
// cryptsetup option --disable-keyring (introduced with cryptsetup v2.0.0)
|
|
// will be ignored with luks1
|
|
return l.execCryptsetupCommand(
|
|
&passphrase,
|
|
"luksOpen",
|
|
devicePath,
|
|
mapperFile,
|
|
"--disable-keyring",
|
|
"-d",
|
|
"/dev/stdin")
|
|
}
|
|
|
|
// LuksResize resizes LUKS encrypted partition.
|
|
func (l *luksWrapper) Resize(mapperFile string) (string, string, error) {
|
|
return l.execCryptsetupCommand(nil, "resize", mapperFile)
|
|
}
|
|
|
|
// LuksClose removes existing mapping.
|
|
func (l *luksWrapper) Close(mapperFile string) (string, string, error) {
|
|
return l.execCryptsetupCommand(nil, "luksClose", mapperFile)
|
|
}
|
|
|
|
// LuksStatus returns encryption status of a provided device.
|
|
func (l *luksWrapper) Status(mapperFile string) (string, string, error) {
|
|
return l.execCryptsetupCommand(nil, "status", mapperFile)
|
|
}
|
|
|
|
// LuksAddKey adds a new key to the specified slot.
|
|
func (l *luksWrapper) AddKey(devicePath, passphrase, newPassphrase, slot string) error {
|
|
passFile, err := file.CreateTempFile("luks-", passphrase)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer os.Remove(passFile.Name())
|
|
|
|
newPassFile, err := file.CreateTempFile("luks-", newPassphrase)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer os.Remove(newPassFile.Name())
|
|
|
|
_, stderr, err := l.execCryptsetupCommand(
|
|
nil,
|
|
"--verbose",
|
|
"--key-file="+passFile.Name(),
|
|
"--key-slot="+slot,
|
|
"luksAddKey",
|
|
devicePath,
|
|
newPassFile.Name(),
|
|
)
|
|
|
|
// Return early if no error to save us some time
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
|
|
// Possible scenarios
|
|
// 1. The provided passphrase to unlock the disk is wrong
|
|
// 2. The key slot is already in use
|
|
// If so, check if the key we want to add to the slot is already there
|
|
// If not, remove it and then add the new key to the slot
|
|
if strings.Contains(stderr, fmt.Sprintf("Key slot %s is full", slot)) {
|
|
// The given slot already has a key
|
|
// Check if it is the one that we want to update with
|
|
exists, fErr := l.VerifyKey(devicePath, newPassphrase, slot)
|
|
if fErr != nil {
|
|
return fErr
|
|
}
|
|
|
|
// Verification passed, return early
|
|
if exists {
|
|
return nil
|
|
}
|
|
|
|
// Else, we remove the key from the given slot and add the new one
|
|
// Note: we use existing passphrase here as we are not yet sure if
|
|
// the newPassphrase is present in the headers
|
|
fErr = l.RemoveKey(devicePath, passphrase, slot)
|
|
if fErr != nil {
|
|
return fErr
|
|
}
|
|
|
|
// Now the slot is free, add the new key to it
|
|
fErr = l.AddKey(devicePath, passphrase, newPassphrase, slot)
|
|
if fErr != nil {
|
|
return fErr
|
|
}
|
|
|
|
// No errors, we good.
|
|
return nil
|
|
}
|
|
|
|
// The existing passphrase is wrong and the slot is empty
|
|
return err
|
|
}
|
|
|
|
// LuksRemoveKey removes the key by killing the specified slot.
|
|
func (l *luksWrapper) RemoveKey(devicePath, passphrase, slot string) error {
|
|
keyFile, err := file.CreateTempFile("luks-", passphrase)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer os.Remove(keyFile.Name())
|
|
|
|
_, stderr, err := l.execCryptsetupCommand(
|
|
nil,
|
|
"--verbose",
|
|
"--key-file="+keyFile.Name(),
|
|
"luksKillSlot",
|
|
devicePath,
|
|
slot,
|
|
)
|
|
if err != nil {
|
|
// If a slot is not active, don't treat that as an error
|
|
if !strings.Contains(stderr, fmt.Sprintf("Keyslot %s is not active.", slot)) {
|
|
return fmt.Errorf("failed to kill slot %s for device %s: %w", slot, devicePath, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// LuksVerifyKey verifies that a key exists in a given slot.
|
|
func (l *luksWrapper) VerifyKey(devicePath, passphrase, slot string) (bool, error) {
|
|
// Create a temp file that we will use to open the device
|
|
keyFile, err := file.CreateTempFile("luks-", passphrase)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
defer os.Remove(keyFile.Name())
|
|
|
|
_, stderr, err := l.execCryptsetupCommand(
|
|
nil,
|
|
"--verbose",
|
|
"--key-file="+keyFile.Name(),
|
|
"--key-slot="+slot,
|
|
"luksChangeKey",
|
|
devicePath,
|
|
keyFile.Name(),
|
|
)
|
|
if err != nil {
|
|
// If the passphrase doesn't match the key in given slot
|
|
if strings.Contains(stderr, "No key available with this passphrase.") {
|
|
// No match, no error
|
|
return false, nil
|
|
}
|
|
|
|
// Otherwise it was something else, return the wrapped error
|
|
log.ErrorLogMsg("failed to verify key in slot %s. stderr: %s. err: %v", slot, stderr, err)
|
|
|
|
return false, fmt.Errorf("failed to verify key in slot %s for device %s: %w", slot, devicePath, err)
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (l *luksWrapper) execCryptsetupCommand(stdin *string, args ...string) (string, string, error) {
|
|
var (
|
|
program = "cryptsetup"
|
|
cmd = exec.CommandContext(l.ctx, program, args...) // #nosec:G204, commands executing not vulnerable.
|
|
sanitizedArgs = stripsecrets.InArgs(args)
|
|
stdoutBuf bytes.Buffer
|
|
stderrBuf bytes.Buffer
|
|
)
|
|
|
|
cmd.Stdout = &stdoutBuf
|
|
cmd.Stderr = &stderrBuf
|
|
if stdin != nil {
|
|
cmd.Stdin = strings.NewReader(*stdin)
|
|
}
|
|
err := cmd.Run()
|
|
stdout := stdoutBuf.String()
|
|
stderr := stderrBuf.String()
|
|
|
|
if errors.Is(l.ctx.Err(), context.DeadlineExceeded) {
|
|
return stdout, stderr, fmt.Errorf("timeout occurred while running %s args: %v", program, sanitizedArgs)
|
|
}
|
|
|
|
if err != nil {
|
|
return stdout, stderr, fmt.Errorf("an error (%v)"+
|
|
" occurred while running %s args: %v", err, program, sanitizedArgs)
|
|
}
|
|
|
|
return stdout, stderr, err
|
|
}
|