ceph-csi/pkg/rbd
ShyamsundarR c4a3675cec Move locks to more granular locking than CPU count based
As detailed in issue #279, current lock scheme has hash
buckets that are count of CPUs. This causes a lot of contention
when parallel requests are made to the CSI plugin. To reduce
lock contention, this commit introduces granular locks per
identifier.

The commit also changes the timeout for gRPC requests to Create
and Delete volumes, as the current timeout is 10s (kubernetes
documentation says 15s but code defaults are 10s). A virtual
setup takes about 12-15s to complete a request at times, that leads
to unwanted retries of the same request, hence the increased
timeout to enable operation completion with minimal retries.

Tests to create PVCs before and after these changes look like so,

Before:
Default master code + sidecar provisioner --timeout option set
to 30 seconds

20 PVCs
Creation: 3 runs, 396/391/400 seconds
Deletion: 3 runs, 218/271/118 seconds
  - Once was stalled for more than 8 minutes and cancelled the run

After:
Current commit + sidecar provisioner --timeout option set to 30 sec
20 PVCs
Creation: 3 runs, 42/59/65 seconds
Deletion: 3 runs, 32/32/31 seconds

Fixes: #279
Signed-off-by: ShyamsundarR <srangana@redhat.com>
2019-07-01 14:10:14 +00:00
..
controllerserver.go Move locks to more granular locking than CPU count based 2019-07-01 14:10:14 +00:00
errors.go Refactor voljournal to aid reuse with CephFS 2019-05-30 09:58:40 +00:00
identityserver.go Replaces the references to the Kubernete Authors with the Ceph-CSI authors 2019-04-03 11:14:08 +02:00
nodeserver.go Move locks to more granular locking than CPU count based 2019-07-01 14:10:14 +00:00
rbd_attach.go Move locks to more granular locking than CPU count based 2019-07-01 14:10:14 +00:00
rbd_journal.go Modify RBD plugin to use a single ID and move the id and key into the secret 2019-06-24 13:46:14 +00:00
rbd_util.go Move locks to more granular locking than CPU count based 2019-07-01 14:10:14 +00:00
rbd.go Modify RBD plugin to use a single ID and move the id and key into the secret 2019-06-24 13:46:14 +00:00