mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-12-22 13:00:19 +00:00
9a03d735a2
The SnapshotClass for RBD requires a pool parameter. This is redundant as a snapshot is not created on a different pool than the source image of the snapshot (refer rbd man page). Further, when a snapshot needs to be created its source CSI VolumeID is passed to the creation call, and hence the source volumes pool needs to be reused to create the snapshot. Similarly to clone a snapshot, the create request would come in with a SnapshotID to help identify the snapshot pool, and the same create request parameters would contain the storage class based pool parameter to create the clone into (as clones can be in different pools as compared to their parent snapshots). Thus, the parameter pool seems redundant in the snapshot class and should be removed to improve ease of use. Fixes #379 Signed-off-by: ShyamsundarR <srangana@redhat.com>
19 lines
763 B
YAML
19 lines
763 B
YAML
---
|
|
apiVersion: snapshot.storage.k8s.io/v1alpha1
|
|
kind: VolumeSnapshotClass
|
|
metadata:
|
|
name: csi-rbdplugin-snapclass
|
|
snapshotter: rbd.csi.ceph.com
|
|
parameters:
|
|
# String representing a Ceph cluster to provision storage from.
|
|
# Should be unique across all Ceph clusters in use for provisioning,
|
|
# cannot be greater than 36 bytes in length, and should remain immutable for
|
|
# the lifetime of the StorageClass in use.
|
|
# Ensure to create an entry in the config map named ceph-csi-config, based on
|
|
# csi-config-map-sample.yaml, to accompany the string chosen to
|
|
# represent the Ceph cluster in clusterID below
|
|
clusterID: <cluster-id>
|
|
|
|
csi.storage.k8s.io/snapshotter-secret-name: csi-rbd-secret
|
|
csi.storage.k8s.io/snapshotter-secret-namespace: default
|