mirror of
https://github.com/ceph/ceph-csi.git
synced 2025-05-22 07:16:41 +00:00
bc8b1e792f
Many reports are about closing or removing files. In some cases it is possible to report an error in the logs, in other cases the error can be ignored without potential issues. Test cases have been modified to not remove the temporary files. The temporary directory that is provided by the testing package, is removed once the tests are done. Signed-off-by: Niels de Vos <ndevos@ibm.com>
115 lines
3.4 KiB
Go
115 lines
3.4 KiB
Go
/*
|
|
Copyright 2024 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
librbd "github.com/ceph/go-ceph/rbd"
|
|
|
|
rbderrors "github.com/ceph/ceph-csi/internal/rbd/errors"
|
|
"github.com/ceph/ceph-csi/internal/rbd/types"
|
|
"github.com/ceph/ceph-csi/internal/util/log"
|
|
)
|
|
|
|
// AddToGroup adds the image to the group. This is called from the rbd_group
|
|
// package.
|
|
func (rv *rbdVolume) AddToGroup(ctx context.Context, vg types.VolumeGroup) error {
|
|
ioctx, err := vg.GetIOContext(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("could not get iocontext for volume group %q: %w", vg, err)
|
|
}
|
|
|
|
name, err := vg.GetName(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("could not get name for volume group %q: %w", vg, err)
|
|
}
|
|
|
|
// check if the image is already part of a group
|
|
// "rbd: ret=-17, File exists" is returned if the image is part of ANY group
|
|
image, err := rv.open()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to open image %q: %w", rv, err)
|
|
}
|
|
defer func() {
|
|
cErr := image.Close()
|
|
if cErr != nil {
|
|
log.WarningLog(ctx, "resource leak, failed to close image: %v", cErr)
|
|
}
|
|
}()
|
|
|
|
info, err := image.GetGroup()
|
|
if err != nil {
|
|
return fmt.Errorf("could not get group information for image %q: %w", rv, err)
|
|
}
|
|
|
|
if info.Name != "" && info.Name != name {
|
|
return fmt.Errorf("image %q is already part of volume group %q", rv, info.Name)
|
|
}
|
|
|
|
err = librbd.GroupImageAdd(ioctx, name, rv.ioctx, rv.RbdImageName)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to add image %q to volume group %q: %w", rv, vg, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// RemoveFromGroup removes the image from the group. This is called from the
|
|
// rbd_group package.
|
|
func (rv *rbdVolume) RemoveFromGroup(ctx context.Context, vg types.VolumeGroup) error {
|
|
ioctx, err := vg.GetIOContext(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("could not get iocontext for volume group %q: %w", vg, err)
|
|
}
|
|
|
|
name, err := vg.GetName(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("could not get name for volume group %q: %w", vg, err)
|
|
}
|
|
|
|
return librbd.GroupImageRemove(ioctx, name, rv.ioctx, rv.RbdImageName)
|
|
}
|
|
|
|
// GetVolumeGroupID returns the ID of the VolumeGroup where this rbdVolume
|
|
// belongs to. If the rbdVolume does not belong to a VolumeGroup, a
|
|
// rbderrors.ErrGroupNotFound is returned.
|
|
func (rv *rbdVolume) GetVolumeGroupID(ctx context.Context, resolver types.VolumeGroupResolver) (string, error) {
|
|
image, err := rv.open()
|
|
if err != nil {
|
|
return "", fmt.Errorf("failed to open image %q: %w", rv, err)
|
|
}
|
|
defer func() {
|
|
cErr := image.Close()
|
|
if cErr != nil {
|
|
log.WarningLog(ctx, "resource leak, failed to close image: %v", cErr)
|
|
}
|
|
}()
|
|
|
|
info, err := image.GetGroup()
|
|
if err != nil {
|
|
return "", fmt.Errorf("could not get group information for image %q: %w", rv, err)
|
|
}
|
|
|
|
if info.Name == "" {
|
|
return "", fmt.Errorf("%w: image %q is not part of a volume group", rbderrors.ErrGroupNotFound, rv)
|
|
}
|
|
|
|
return resolver.MakeVolumeGroupID(ctx, info.PoolID, info.Name)
|
|
}
|