mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-09-20 07:29:50 +00:00
a0fd805a8b
Added support for RBD PVC to PVC cloning, below commands are executed to create a PVC-PVC clone from RBD side. * Check the depth(n) of the cloned image if n>=(hard limit -2) or ((soft limit-2) Add a task to flatten the image and return about (to avoid image leak) **Note** will try to flatten the temp clone image in the chain if available * Reserve the key and values in omap (this will help us to avoid the leak as it's not reserved earlier as we have returned ABORT (the request may not come back)) * Create a snapshot of rbd image * Clone the snapshot (temp clone) * Delete the snapshot * Snapshot the temp clone * Clone the snapshot (final clone) * Delete the snapshot ```bash 1) check the image depth of the parent image if flatten required add a task to flatten image and return ABORT to avoid leak (hardlimit-2 and softlimit-2 check will be done) 2) Reserve omap keys 2) rbd snap create <RBD image for src k8s volume>@<random snap name> 3) rbd clone --rbd-default-clone-format 2 --image-feature layering,deep-flatten <RBD image for src k8s volume>@<random snap> <RBD image for temporary snap image> 4) rbd snap rm <RBD image for src k8s volume>@<random snap name> 5) rbd snap create <cloned RBD image created in snapshot process>@<random snap name> 6) rbd clone --rbd-default-clone-format 2 --image-feature <k8s dst vol config> <RBD image for temporary snap image>@<random snap name> <RBD image for k8s dst vol> 7)rbd snap rm <RBD image for src k8s volume>@<random snap name> ``` * Delete temporary clone image created as part of clone(delete if present) * Delete rbd image Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
107 lines
3.3 KiB
Go
107 lines
3.3 KiB
Go
/*
|
|
Copyright 2020 The Ceph-CSI Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
package rbd
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/ceph/ceph-csi/internal/util"
|
|
|
|
klog "k8s.io/klog/v2"
|
|
)
|
|
|
|
func createRBDClone(ctx context.Context, parentVol, cloneRbdVol *rbdVolume, snap *rbdSnapshot, cr *util.Credentials) error {
|
|
// create snapshot
|
|
err := parentVol.createSnapshot(ctx, snap)
|
|
if err != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to create snapshot %s: %v"), snap, err)
|
|
return err
|
|
}
|
|
|
|
snap.RbdImageName = parentVol.RbdImageName
|
|
// create clone image and delete snapshot
|
|
err = cloneRbdVol.cloneRbdImageFromSnapshot(ctx, snap)
|
|
if err != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to clone rbd image %s from snapshot %s: %v"), cloneRbdVol.RbdImageName, snap.RbdSnapName, err)
|
|
err = fmt.Errorf("failed to clone rbd image %s from snapshot %s: %w", cloneRbdVol.RbdImageName, snap.RbdSnapName, err)
|
|
}
|
|
errSnap := parentVol.deleteSnapshot(ctx, snap)
|
|
if errSnap != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to delete snapshot: %v"), errSnap)
|
|
delErr := deleteImage(ctx, cloneRbdVol, cr)
|
|
if delErr != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to delete rbd image: %s with error: %v"), cloneRbdVol, delErr)
|
|
}
|
|
return err
|
|
}
|
|
|
|
err = cloneRbdVol.getImageInfo()
|
|
if err != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to get rbd image: %s details with error: %v"), cloneRbdVol, err)
|
|
delErr := deleteImage(ctx, cloneRbdVol, cr)
|
|
if delErr != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to delete rbd image: %s with error: %v"), cloneRbdVol, delErr)
|
|
}
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func cleanUpSnapshot(ctx context.Context, parentVol *rbdVolume, rbdSnap *rbdSnapshot, rbdVol *rbdVolume, cr *util.Credentials) error {
|
|
err := parentVol.deleteSnapshot(ctx, rbdSnap)
|
|
if err != nil {
|
|
var esnf ErrSnapNotFound
|
|
if !errors.As(err, &esnf) {
|
|
klog.Errorf(util.Log(ctx, "failed to delete snapshot: %v"), err)
|
|
return err
|
|
}
|
|
}
|
|
err = deleteImage(ctx, rbdVol, cr)
|
|
if err != nil {
|
|
var einf ErrImageNotFound
|
|
if !errors.As(err, &einf) {
|
|
klog.Errorf(util.Log(ctx, "failed to delete rbd image: %s/%s with error: %v"), rbdVol.Pool, rbdVol.VolName, err)
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func generateVolFromSnap(rbdSnap *rbdSnapshot) *rbdVolume {
|
|
vol := new(rbdVolume)
|
|
vol.ClusterID = rbdSnap.ClusterID
|
|
vol.VolID = rbdSnap.SnapID
|
|
vol.Monitors = rbdSnap.Monitors
|
|
vol.Pool = rbdSnap.Pool
|
|
vol.JournalPool = rbdSnap.JournalPool
|
|
vol.RbdImageName = rbdSnap.RbdSnapName
|
|
vol.ImageID = rbdSnap.ImageID
|
|
return vol
|
|
}
|
|
|
|
func undoSnapshotCloning(ctx context.Context, parentVol *rbdVolume, rbdSnap *rbdSnapshot, cloneVol *rbdVolume, cr *util.Credentials) error {
|
|
err := cleanUpSnapshot(ctx, parentVol, rbdSnap, cloneVol, cr)
|
|
if err != nil {
|
|
klog.Errorf(util.Log(ctx, "failed to clean up %s or %s: %v"), cloneVol, rbdSnap, err)
|
|
return err
|
|
}
|
|
err = undoSnapReservation(ctx, rbdSnap, cr)
|
|
return err
|
|
}
|