mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-17 20:00:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: check for cookie support from kernel

Browse Source 
Currently we only check if the rbd-nbd tool supports cookie feature.
This change will also defend cookie addition based on kernel version

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
This commit is contained in:
Prasanna Kumar Kalever 2022-04-01 19:31:31 +05:30 committed by mergify[bot]
parent 804e2715d8
commit d760d0ab6d
1 changed files with 45 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
internal/rbd/rbd_attach.go
View File

@ -71,6 +71,25 @@ const (
var (
hasNBD = true
hasNBDCookieSupport = false
kernelCookieSupport = []util.KernelVersion{
{
Version: 5,
PatchLevel: 14,
SubLevel: 0,
ExtraVersion: 0,
Distribution: "",
Backport: false,
}, // standard 5.14+ versions
{
Version: 4,
PatchLevel: 18,
SubLevel: 0,
ExtraVersion: 365,
Distribution: ".el8",
Backport: true,
}, // CentOS-8.x
}
)
func init() {
@ -207,21 +226,42 @@ func setRbdNbdToolFeatures() {
_, stderr, err = util.ExecCommand(context.TODO(), "modprobe", moduleNbd)
if err != nil {
hasNBD = false
log.WarningLogMsg("rbd-nbd: nbd modprobe failed (%v): %q", err, stderr)
log.WarningLogMsg("nbd modprobe failed (%v): %q", err, stderr)
return
}
}
log.DefaultLog("nbd module loaded")
// fetch the current running kernel info
release, err := util.GetKernelVersion()
if err != nil {
log.WarningLogMsg("fetching current kernel version failed (%v)", err)
return
}
if !util.CheckKernelSupport(release, kernelCookieSupport) {
log.WarningLogMsg("kernel version %q doesn't support cookie feature", release)
return
}
log.DefaultLog("kernel version %q supports cookie feature", release)
// check if the rbd-nbd tool supports cookie
stdout, stderr, err := util.ExecCommand(context.TODO(), rbdTonbd, "--help")
if err != nil || stderr != "" {
hasNBD = false
log.WarningLogMsg("running rbd-nbd --help failed with error:%v, stderr:%s", err, stderr)
}
if strings.Contains(stdout, "--cookie") {
hasNBDCookieSupport = true
return
}
if !strings.Contains(stdout, "--cookie") {
log.WarningLogMsg("rbd-nbd tool doesn't support cookie feature")
log.DefaultLog("NBD module loaded: %t, rbd-nbd supported features, cookie: %t", hasNBD, hasNBDCookieSupport)
return
}
hasNBDCookieSupport = true
log.DefaultLog("rbd-nbd tool supports cookie feature")
}
// parseMapOptions helps parse formatted mapOptions and unmapOptions and