mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-09 16:00:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

doc: Correct minor nits

Browse Source 
Correct development-guide doc with minor
nit picks.

Signed-off-by: Yug <yuggupta27@gmail.com>
This commit is contained in:
Yug 2020-08-21 15:02:45 +05:30 committed by mergify[bot]
parent f74922fe57
commit e3fb20de21
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
docs/development-guide.md
View File

@ -201,22 +201,21 @@ and/or create an initial design doc PR. Once the design has been agreed upon
one or more PRs implementing the plan can be made. one or more PRs implementing the plan can be made.
**Review Process:** **Review Process:**
Once your PR has been submitted for review the following critieria will Once your PR has been submitted for review the following criteria will
need to be met before it will be merged: need to be met before it will be merged:
* Each PR needs reviews accepting the change from at least two developers * Each PR needs reviews accepting the change from at least two developers for merging.
* for merging * It is common to request reviews from those reviewers automatically suggested
* It is common to request reviews from those reviewers automatically suggested by GitHub.
* by github
* Each PR needs to have been open for at least 24 working hours to allow for * Each PR needs to have been open for at least 24 working hours to allow for
* community feedback community feedback.
* The 24 working hours counts hours occuring Mon-Fri in the local timezone * The 24 working hours counts hours occurring Mon-Fri in the local timezone
* of the submitter of the submitter.
* Each PR must be fully updated to master and tests must have passed * Each PR must be fully updated to master and tests must have passed
* If the PR is having trivial changes or the reviewer is confident enough that * If the PR is having trivial changes or the reviewer is confident enough that
PR doesn't need a second review, the reviewer can set `ready-to-merge` label PR doesn't need a second review, the reviewer can set `ready-to-merge` label
on the PR. The bot will merge the PR if it's having one approval and the on the PR. The bot will merge the PR if it's having one approval and the
label `ready-to-merge` label `ready-to-merge`.
When the criteria are met, a project maintainer can merge your changes into When the criteria are met, a project maintainer can merge your changes into
the project's master branch. the project's master branch.