Commit Graph

4473 Commits

Author SHA1 Message Date
Praveen M
549385021b rebase: update golang.org/x/net to v0.34.0 in /api
This commit resolves  CVE-2024-45338 -
Non-linear parsing of case-insensitive content in golang.org/x/net/html (high severity)
https://github.com/advisories/GHSA-w32m-9786-jp63

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-17 15:17:16 +05:30
Praveen M
4fdf0494f9 rebase: update K8s packages to v0.32.0
Update K8s packages in go.mod to v0.32.0

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-17 15:17:11 +05:30
dependabot[bot]
ccf9150c6d rebase: bump k8s.io/api in /api in the k8s-dependencies group
Bumps the k8s-dependencies group in /api with 1 update: [k8s.io/api](https://github.com/kubernetes/api).

Updates `k8s.io/api` from 0.31.3 to 0.32.0
- [Commits](https://github.com/kubernetes/api/compare/v0.31.3...v0.32.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-17 15:16:15 +05:30
Niels de Vos
d996439b30 ci: disable offlineExpansion in k8s-e2e-external-storage for RBD
The `offlineExpansion` option enables tests that try to expand volumes
in the CSI Controller (provisioner). This is only possible for BlockMode
volumes, as a FileMode volume needs run a filesystem resizer while the
volume is attached.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2025-01-17 08:47:05 +00:00
Niels de Vos
84dd5bbe68 rebase: update csi-resizer to v1.13.1
The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.

See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2025-01-17 08:47:05 +00:00
Niels de Vos
9e163ca8bf ci: update minikube to v1.35.0
A new release, and it contains many updated components and bugfixes.

See: https://github.com/kubernetes/minikube/releases/tag/v1.35.0
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2025-01-17 03:34:21 +00:00
Matthias Linhuber
bdd7c5a666 doc: Add hint that the userID must not include the client. prefix
Signed-off-by: Matthias Linhuber <matthias.linhuber@tum.de>
2025-01-15 08:46:51 +00:00
Niels de Vos
e89fe5ad1f rbd: add context in reported errors by GetVolumeReplicationInfo
Logged errors are much more helpful when there is some context around
the message about what went wrong.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
2025-01-15 08:36:39 +00:00
yati1998
4101b63e02 rbd: add check to getVolumeReplicationInfo
this commit adds a check to getVolumeReplicationInfo
to include status not found error while getting the
remote status.
This helps the failover to be done even if remote site status
is not found

Signed-off-by: yati1998 <ypadia@redhat.com>
2025-01-14 17:25:10 +00:00
dependabot[bot]
4b003156a4 rebase: bump google.golang.org/grpc from 1.69.2 to 1.69.4
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.69.2 to 1.69.4.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.69.2...v1.69.4)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-14 10:18:26 +00:00
dependabot[bot]
337769640e rebase: bump github/codeql-action from 3.27.9 to 3.28.1
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.9 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](df409f7d92...b6a472f63d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-14 09:45:09 +00:00
dependabot[bot]
853cecbee5 rebase: bump sigs.k8s.io/controller-runtime
Bumps the k8s-dependencies group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `sigs.k8s.io/controller-runtime` from 0.19.3 to 0.19.4
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.19.3...v0.19.4)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-10 14:48:21 +00:00
Praveen M
c2fff75610 doc: update examples to use volumeGroupNamePrefix
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-09 11:59:16 +00:00
Praveen M
eebfd15e78 rbd: rename groupNamePrefix to volumeGroupNamePrefix
CephFS uses the parameter `volumeGroupNamePrefix` for creating VolumeGroups.
This commit renames `groupNamePrefix` to `volumeGroupNamePrefix` for RBD
VolumeGroup creation to ensure consistent naming.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-09 11:59:16 +00:00
dependabot[bot]
d8477cb9d4 rebase: bump the golang-dependencies group across 1 directory with 3 updates
Bumps the golang-dependencies group with 2 updates in the / directory: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net).


Updates `golang.org/x/crypto` from 0.31.0 to 0.32.0
- [Commits](https://github.com/golang/crypto/compare/v0.31.0...v0.32.0)

Updates `golang.org/x/net` from 0.32.0 to 0.34.0
- [Commits](https://github.com/golang/net/compare/v0.32.0...v0.34.0)

Updates `golang.org/x/sys` from 0.28.0 to 0.29.0
- [Commits](https://github.com/golang/sys/compare/v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-09 08:50:08 +00:00
dependabot[bot]
62e1ccdcc5 rebase: bump google.golang.org/protobuf from 1.36.0 to 1.36.2
Bumps google.golang.org/protobuf from 1.36.0 to 1.36.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-08 16:13:38 +00:00
dependabot[bot]
0ccaa9d1c8 rebase: bump golang.org/x/oauth2 in /actions/retest
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.24.0 to 0.25.0.
- [Commits](https://github.com/golang/oauth2/compare/v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-08 14:07:33 +00:00
Niraj Yadav
7226945e72 doc: update documentation for userID and userKey
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2025-01-08 13:48:36 +00:00
Niraj Yadav
890af07c5a helm: Update helm charts to use userID and Keys
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2025-01-08 13:48:36 +00:00
Niraj Yadav
477d2ad517 e2e: Note to update to userID and userKey
Once the version we use for upgrade testing does
not depend on adminID and adminKey we should update
the tests to use just the userID and userKey.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2025-01-08 13:48:36 +00:00
Niraj Yadav
e96404b297 cephfs: use userid and keys for provisioning
This patch modifies the code to use userID and
userKey for provisioning of both static and dynamic
PVs.

In case user credentials are not found admin credentials
are used as a fallback and for backwards compatibility.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2025-01-08 13:48:36 +00:00
Praveen M
54a8b50957 ci: non-constant format string (govet)
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
Praveen M
96408c01c8 ci: address return value is not checked (errcheck)
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
Praveen M
dfc9bdaf03 ci: address shadowing of predeclared identifier
- Comparing integers makes more sense than comparing the strings.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
Praveen M
d46029ca1f ci: address arguments have the wrong order (staticcheck)
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
Praveen M
ea205410f5 ci: update golangci-lint to v1.62.2
- gomnd is replaced by mnd in v1.58.0
- gosec exlcude G115 rule (Potential integer overflow when converting between integer types)
- disable new iface linter
- disable new recvcheck linter

Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
Praveen M
6bd78fb778 build: update Go 1.23
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-08 11:56:24 +00:00
dependabot[bot]
59aeab49bb rebase: bump google.golang.org/grpc from 1.69.0 to 1.69.2
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.69.0 to 1.69.2.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.69.0...v1.69.2)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-07 16:22:14 +00:00
dependabot[bot]
42db99ac5b rebase: bump github.com/ceph/go-ceph
Bumps [github.com/ceph/go-ceph](https://github.com/ceph/go-ceph) from 0.30.1-0.20241102143109-75d1af3ed638 to 0.31.0.
- [Release notes](https://github.com/ceph/go-ceph/releases)
- [Changelog](https://github.com/ceph/go-ceph/blob/master/docs/release-process.md)
- [Commits](https://github.com/ceph/go-ceph/commits/v0.31.0)

---
updated-dependencies:
- dependency-name: github.com/ceph/go-ceph
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-07 14:10:18 +00:00
Praveen M
81d4f615ff ci: update mergify rules to drop K8s v1.29 from devel
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-06 12:11:07 +00:00
Praveen M
505c8e73ca ci: update mergify rules for K8s v1.32
Signed-off-by: Praveen M <m.praveen@ibm.com>
2025-01-06 12:11:07 +00:00
Nikhil-Ladha
18a62ec9de util: return correct status code for VolumeGroupSnapshot
Fix status codes that are returned for Get/Delete RPC calls
for VolumeGroup/VolumeGroupSnapshot.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2024-12-19 10:42:01 +00:00
dependabot[bot]
ca1ccdd9bf rebase: bump google.golang.org/protobuf from 1.35.2 to 1.36.0
Bumps google.golang.org/protobuf from 1.35.2 to 1.36.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-19 06:43:41 +00:00
dependabot[bot]
431e9231d2 rebase: bump google.golang.org/grpc from 1.68.1 to 1.69.0
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.68.1 to 1.69.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.68.1...v1.69.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-18 13:35:30 +00:00
dependabot[bot]
afd950ebed rebase: bump github.com/onsi/gomega in the github-dependencies group
Bumps the github-dependencies group with 1 update: [github.com/onsi/gomega](https://github.com/onsi/gomega).


Updates `github.com/onsi/gomega` from 1.36.0 to 1.36.1
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.36.0...v1.36.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-17 21:12:31 +00:00
dependabot[bot]
cf9ebf7810 rebase: bump github/codeql-action from 3.27.6 to 3.27.9
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.6 to 3.27.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](aa57810251...df409f7d92)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-17 15:47:36 +00:00
Rakshith R
50b2a0528e rbd: add layering & deep flattenfeatures for groupsnapshot image
Signed-off-by: Rakshith R <rar@redhat.com>
2024-12-17 15:15:42 +00:00
Rakshith R
09d848e017 rbd: make use of both listSnapshots and listChildren
Currently, CephCSI only uses listSnaps to determine
number of snapshots on a RBD image and uses snapshot
names as child image names to flatten them.
But child images may have different name(in case of
group snapshot) or they maybe in trash
(deleted k8s VolSnapshot with alive restored PVC).

The above problems are avoid by making use of both
snap and child image lists.

Signed-off-by: Rakshith R <rar@redhat.com>
2024-12-17 15:15:42 +00:00
Rakshith R
9936033283 rbd: consolidate snapshot flatten logic in PrepareVolumeForSnapshot()
This commit consolidates flatten logic checks for cloneDepth
and snapshotLimit in PrepareVolumeForSnapshot. This allows
the function to be called for both CreateSnapshot and
CreateVolumeGroupSnapshot.
Clone Depth check and flattening of grand parent image
now occurs before creation of snapshot starts.
This aligns better with how PVC-PVC clone and
PVC-restore process occurs currently.
Flattening the grandparent image once prevents
flattening of every newly created snapshot.
Snapshot in above para refers to k8s VolumeSnapshot
(which is backed by a rbd image).

Signed-off-by: Rakshith R <rar@redhat.com>
2024-12-17 15:15:42 +00:00
Rakshith R
afc08c531c e2e: test creation of additional groupSnaps to test minSnapLimit
Signed-off-by: Rakshith R <rar@redhat.com>
2024-12-17 15:15:42 +00:00
Madhu Rajanna
a88f86e9a4 e2e: remove vsg flag present in older snapshotter
Remove the vsg flag present in the older snapshotter
which is meant only for the Alpha Release and we are
no longer installing Alpha CRD.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
21d639df20 deploy: update the vgs api to v1beta1
updating the yamls of vgs to v1beta1

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
eb66ec8177 ci: adjust the snapshot to enable vgs
updating the snapshot container ARG
to enable the vgs feature.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
a17fef07e6 e2e: update snapshot to v1beta1
updating the snapshot client and
test to use v1beta1 client and API.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
5bfff89e04 helm: update template for vgs flag
updating the snapshotter image to 8.2.0
and update the flag to enable vgs
feature.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
23da6d9b13 deploy: update template for vgs flag
updating the snapshotter image to 8.2.0
and update the flag to enable vgs
feature.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Madhu Rajanna
884c47dd3c build: update snapshot version
updating the snapshot version in
the build.env

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-12-17 10:55:39 +00:00
Praveen M
88b7e0d668 e2e: validate images in trash for volumegroupsnapshot test
Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-12-16 13:36:22 +00:00
Praveen M
51d0a08112 rbd: fix volumeGroup UndoReservation
This commit fixes the VolumeGroup UndoReservation
by using the correct RequestName of the VolumeGroup
instead of the volumeGroupHandle.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-12-16 13:36:22 +00:00
Praveen M
797eceebb2 rbd: add rbdSnap.Delete() function
This function deletes rbd snap and rbd image
backing k8s snapshot.
The same function is used for deleting
individual snapshots in group snapshot.

Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-12-16 13:36:22 +00:00