Madhu Rajanna
787ba69089
cephfs: fix lock release in volumeDelete
...
currently the lock is not released which is
taken on the request name. this is causing issues
when the subvolume is requested for delete.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Madhu Rajanna
31c7c95fdb
cephfs: check error output contains Error: ENOENT
...
execCommandErr returns both error and stderror
message. checking strings.HasPrefix is not helpful
as the stderr will be the first string. its good
to do string comparison and find out that error
is volume not found error.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-18 06:12:43 +00:00
Niels de Vos
25899b0123
ci: do not constantly rebase PRs
...
It seems the 'rebase' action in Mergify causes each PR to be
automatically rebased once there is a change in the target branch. This
causes a very high load on the CI, which delays other PRs from getting
their test results.
Remove the 'rebase' action, as it does not work as intended. The
expectation was that '@mergifyio rebase' uses the configuration.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-17 16:23:12 +05:30
Niels de Vos
b881ef1eee
ci: prevent Mergify from doing merge commits
...
Merge commits cause the CentOS CI commitlint job to fail. By configuring
Mergify to not do merge commits, but rebases before final testing, we
can use the CentOS CI commitlint job when the GitHub commitlint App does
not work.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-17 16:23:12 +05:30
yati1998
75d800c07e
doc: documentation updates on capabilities
...
Documents exact capabilities a id requires against a
Ceph cluster for RBD and CephFS plugins.
Signed-off-by: yati1998 <ypadia@redhat.com>
2020-08-17 09:47:03 +00:00
Niels de Vos
aa5b53fcce
ci: use ceph-csi-bot account for merging PRs
...
Currently the "@mergifyio rebase" commands uses a random person from the
GitHub organization that owns the repository. This is rather confusing
and ugly. With this change, alls rebase/merge actions are done with the
ceph-csi-bot account that also posts the result of jobs in the CentOS CI.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-17 08:30:26 +05:30
Madhu Rajanna
738b5a1f46
ci: add mergify rules for v3.1 branch
...
add mergify rules for backport and auto
merge of PR's for release-v3.1 branch.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-17 08:30:00 +05:30
Niels de Vos
c0fbaf4276
ci: only retry "kubectl create" if objects are missing
...
There can be spurious failures in the CI when running kubectl create. On
occasion, the command returns with an error, but the api-server did
receive and process the request. This causes a 2nd create action to fail
with messages like:
cephcluster.ceph.rook.io/my-cluster created
Error from server: error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": etcdserver: request timed out
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": configmaps "rook-config-override" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": cephclusters.ceph.rook.io "my-cluster" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": configmaps "rook-config-override" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": cephclusters.ceph.rook.io "my-cluster" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": configmaps "rook-config-override" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": cephclusters.ceph.rook.io "my-cluster" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": configmaps "rook-config-override" already exists
Error from server (AlreadyExists): error when creating "/tmp/tmp.Ur1ZPG85o9/cluster-test.yaml": cephclusters.ceph.rook.io "my-cluster" already exists
By handling the create action differently, and checking for the
AlreadyExists word in the stderr output, it is possible to detect
repeated creates that are not needed.
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2020-08-13 16:28:28 +00:00
Madhu Rajanna
f11486f4b6
doc: add note for cephfs snapshot limitation
...
added a note for cephfs snapshot limitations
closes #1242
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 11:55:23 +00:00
Madhu Rajanna
fabe84d4fe
doc: add upgrade documentation for v3.1.0
...
added upgrade documentation to upgrade from
v3.0.0 to v3.1.0
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 11:03:36 +00:00
Humble Chirammal
1b94ed2b37
doc: update cephfs snapshot, restore and clone support matrix
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2020-08-13 10:12:14 +00:00
Madhu Rajanna
f566b0fc2d
cephfs: replace Warningf with WarningLog in unmountVolume
...
replace Errorf with ErrorLog in unmountVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fe3d25dda
cephfs: replace Errorf with ErrorLogMsg in loadAvailableMounters
...
replace Errorf with ErrorLog in loadAvailableMounters
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
fbe090065d
cephfs: replace Errorf with ErrorLog in purgeVolume
...
replace Errorf with ErrorLog in purgeVolume
for context based logging
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5a1652e5e8
cephfs: replace Errorf with ErrorLog in resizeVolume
...
replace Errorf with ErrorLog in resizeVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
a882c1194b
cephfs: replace Errorf with ErrorLog in createVolume
...
replace Errorf with ErrorLog in createVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f3d9b8933b
cephfs: replace Errorf with ErrorLog in getSubVolumeInfo
...
replace Errorf with ErrorLog in getSubVolumeInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
2b7aade289
cephfs: replace Errorf with ErrorLog in getVolumeRootPathCeph
...
replace Errorf with ErrorLog in getVolumeRootPathCeph
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d1ac832266
cephfs: replace Errorf with ErrorLog in genSnapFromOptions
...
replace Errorf with ErrorLog in genSnapFromOptions
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e83a51c1e1
cephfs: replace Errorf with ErrorLog in parseTime
...
replace Errorf with ErrorLog in parseTime
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e7a043271d
cephfs: replace Errorf with ErrorLog in cloneSnapshot
...
replace Errorf with ErrorLog in cloneSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
841a3713f5
cephfs: replace Errorf with ErrorLog in unprotectSnapshot
...
replace Errorf with ErrorLog in unprotectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
91811c18c5
cephfs: replace Errorf with ErrorLog in protectSnapshot
...
replace Errorf with ErrorLog in protectSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
72dfe6a265
cephfs: replace Errorf with ErrorLog in getSnapshotInfo
...
replace Errorf with ErrorLog in getSnapshotInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7e8cc41aca
cephfs: replace Errorf with ErrorLog in deleteSnapshot
...
replace Errorf with ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7f00fa66f4
cephfs: replace Errorf with ErrorLog in createSnapshot
...
replace Errorf with ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
57454cf379
cephfs: replace Errorf with ErrorLog in nodeUnstageVolume
...
replace Errorf with ErrorLog in nodeUnstageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
0a5581b7a0
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
...
cephfs: replace Errorf with ErrorLog in NodeUnPublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
79dbc41d14
cephfs: replace Errorf with ErrorLog in NodePublishVolume
...
replace Errorf with ErrorLog in NodePublishVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
48a313c6cc
cephfs: replace Errorf with ErrorLog in mount
...
replace Errorf with ErrorLog in mount for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
032901b8d0
cephfs: replace Errorf with ErrorLog in nodeStageVolume
...
replace Errorf with ErrorLog in nodeStageVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
c57189382f
cephfs: replace Errorf with ErrorLog in checkSnapExists
...
replace Errorf with ErrorLog in checkSnapExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
98e97baa60
cephfs: replace Errorf with ErrorLog in checkVolExists
...
replace Errorf with ErrorLog in checkVolExists
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
abd548e420
cephfs: replace warning with WarningLogMsg in Run
...
replace warning with WarningLogMsg in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
38273f879f
cephfs: replace fatal with util.FatalLog in Run
...
replace fatal with util.FatalLog in Run for
context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
eeb0859f99
util: rename FatalLog to FatalLogMsg for parity
...
rename FatalLog to FatalLogMsg to keep functions
in parity functions ends with Msg if its only message
logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
71a6dc3ba8
cephfs: replace Errorf with util.ErrorLog in getCloneInfo
...
replace Errorf with util.ErrorLog in getCloneInfo
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
ae6b77f105
cephfs: add comment for exported CloneStatus struct
...
added comment for exported structure.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
18d65ba3f5
cephfs: replace Errorf with ErrorLog in createCloneFromSnapshot
...
replace Errorf with ErrorLog in createCloneFromSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3fa512617b
cephfs: replace Errorf with util.ErrorLog in cleanupClone
...
replace Errorf with util.ErrorLog in cleanupCloneFromSubvolumeSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e1fb708d48
cephfs: replace Errorf with util.ErrorLog in createCloneFromSubvolume
...
replace Errorf with util.ErrorLog in createCloneFromSubvolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
20dbbe54b0
cephfs: replace klog.Warningf with util.WarningLog in deleteSnapshot
...
replace klog.Warningf with util.WarningLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
7eefadf1eb
cephfs: replace klog.Warning with util.WarningLog in DeleteVolume
...
replace klog.Warning with util.WarningLog in DeleteVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
e3c3bbf0e3
cephfs: replace klog.Warning with util.WarningLog in CreateVolume
...
replace klog.Warning with util.WarningLog in CreateVolume
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
3d12456493
util: add WarningLog to log with context
...
added WarningLog to log with context
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
b223924044
util: rename WarningLog to WarningLogMsg
...
renamed WarningLog function to WarningLogMsg
to log with message.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
f45ad230a2
cephfs: replace klog.Error with util.ErrorLog in deleteSnapshot
...
replace klog.Error with util.ErrorLog in deleteSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
52f14cf9fe
cephfs: replace klog.Error with util.ErrorLog in validateSnapshotReq
...
replace klog.Error with util.ErrorLog in validateSnapshotReq
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
d101cbc888
cephfs: replace klog.Error with util.ErrorLog in doSnapshot
...
replace klog.Error with util.ErrorLog in doSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00
Madhu Rajanna
5802265b28
cephfs: replace klog.Error with util.ErrorLog in createSnapshot
...
replace klog.Error with util.ErrorLog in createSnapshot
for context based logging.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2020-08-13 09:44:12 +00:00