mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-12-18 19:10:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
797 Commits 27 Branches 40 Tags 154 MiB
b44a81bdbc
Commit Graph

797 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Humble Chirammal
b44a81bdbc We were defaulting to ext4 at first and then moved toxfs. 
However further testing shows that, ext4 should be
the default or preferred fs for RBD devices.

This patch bring that change

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-09-24 14:36:50 +05:30
Humble Chirammal
0e6617e1ff Format RBD volumes with nodiscard formatting options. 
Currently rbd CSI plugin uses formatAndMount of
mount.SafeFormatAndMount. This does not allow to pass or use
specific formatting arguments with it. This patch introduce
RBD specific formatting options with both xfs and ext4,
for example: -E no-discard with ext4 and -k option with
XFS to boost formatting performance of RBD device.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-09-20 13:16:53 +00:00
Madhu Rajanna
e2890a27ff connect to provisioner socket 
Fixes: #619

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-20 08:13:19 +00:00
Madhu Rajanna
6aac399075 Change the logic of locking 
if any on going opearation is seen,we
have to return Abort error message

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-20 07:37:17 +00:00
Madhu Rajanna
18151e9ca8 use rook v1.1.0 in E2E testing 
rook master is not good enough to
depend on for E2E testing, swithing to v1.1.0
for E2E

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-18 12:30:43 +00:00
Madhu Rajanna
6da96c6327 remove support for create image with image-format 1 
tried to create an image with image-format=1

```
sh-4.2# rbd create --size=1024 replicapool/test --image-format=1
rbd: image format 1 is deprecated
rbd: create error: (22) Invalid argument
2019-09-11 07:00:54.531 7fb0e40bfb00 -1 librbd: Format 1 image creation unsupported.
```

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-12 07:52:32 +00:00
Madhu Rajanna
e395080cdc Add req-ID to logging 
with this log format we can easily identify
the logs per request

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-11 13:45:40 +00:00
Madhu Rajanna
ed9330d2f6 rename Key to CtxKey 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-11 13:45:40 +00:00
Madhu Rajanna
41b701c98c Add support for erasure pool in rbd 
Allow specifying different metadata and data pools in a
CSI RBD StorageClass

Fixes: #199
Fixes: https://github.com/rook/rook/issues/2650
Fixes: https://github.com/rook/rook/issues/3763

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-11 06:48:08 +00:00
Madhu Rajanna
8992e9d321 update readme for v1.2.0 release 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-10 13:11:53 +00:00
KingJ
0639e00705 Reorder kernel version checking logic 2019-09-07 11:10:27 +00:00
KingJ
197c8fcfcc Consider Kernel >=5.x as sufficent for using the Kernel mounter 2019-09-07 11:10:27 +00:00
Poornima G
060ff8d25e Add mount option for Cephfs 
The storage class already takes MountOptions(MountFlags), these are the
bind mount options. Some of these options may not be recognised by the
cephfs mount. Hence added a new parameterin Storage Class for
- cephfs kernel mount options,
- ceph-fuse mount options

Ceph kernel mount options are different from ceph-fuse options, hence
added two different parameters.

Signed-off-by: Poornima G <pgurusid@redhat.com>
 2019-09-06 16:32:10 +00:00
Daniel-Pivonka
d1952e5fd0 Fix liveness connection opening endless sockets 
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
 2019-09-06 03:15:28 +00:00
Madhu Rajanna
f4b38228ae Remove volumemounter flag from cephfs 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-05 07:20:50 +00:00
Poornima G
90c4d6a451 Cephfs: Use ceph kernel client if kernel version >= 4.17 
Ceph kernel client is more performant than ceph fuse client.
The kernel client has Quota support only in the kernel version >=4.17.
Hence use ceph kernel client when the kernel version is >=4.17.

Signed-off-by: Poornima G <pgurusid@redhat.com>
 2019-09-05 04:55:05 +00:00
Niels de Vos
d03a352abf e2e: correct log format in execCommandInPod() 
Signed-off-by: Niels de Vos <ndevos@redhat.com>
 2019-09-04 12:26:55 +00:00
Niels de Vos
8f133e03b8 Add 'gosec' to the static-checks 
Run static security scanning tool 'gosec' while testing.

URL: https://github.com/securego/gosec
Signed-off-by: Niels de Vos <ndevos@redhat.com>
 2019-09-04 11:48:37 +00:00
Niels de Vos
dd668e59f1 Address security concerns reported by 'gosec' 
gosec reports several issues, none of them looks very critical. With
this change the following concerns have been addressed:

[pkg/cephfs/nodeserver.go:229] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
  > os.Chmod(targetPath, 0777)

[pkg/cephfs/util.go:39] - G204: Subprocess launched with variable (Confidence: HIGH, Severity: MEDIUM)
  > exec.Command(program, args...)

[pkg/rbd/nodeserver.go:156] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
  > os.Chmod(stagingTargetPath, 0777)

[pkg/rbd/nodeserver.go:205] - G302: Expect file permissions to be 0600 or less (Confidence: HIGH, Severity: MEDIUM)
  > os.OpenFile(mountPath, os.O_CREATE|os.O_RDWR, 0750)

[pkg/rbd/rbd_util.go:797] - G304: Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
  > ioutil.ReadFile(fPath)

[pkg/util/cephcmds.go:35] - G204: Subprocess launched with variable (Confidence: HIGH, Severity: MEDIUM)
  > exec.Command(program, args...)

[pkg/util/credentials.go:47] - G104: Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > os.Remove(tmpfile.Name())

[pkg/util/credentials.go:92] - G104: Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > os.Remove(cr.KeyFile)

[pkg/util/pidlimit.go:74] - G304: Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
  > os.Open(pidsMax)

URL: https://github.com/securego/gosec
Signed-off-by: Niels de Vos <ndevos@redhat.com>
 2019-09-04 11:48:37 +00:00
Madhu Rajanna
d6f1c938d8 comment yum update from dockerfile 
currently we are facing issue in  building
docker image,commenting yum update it fix it

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-04 11:12:07 +00:00
Madhu Rajanna
64ca401a51 Fix mon endpoint issue in E2E 
in toolbox mon endpoints are not
updated properly, this is causing an issue in E2E
this PR is a workaround to fix this issue.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-09-04 11:12:07 +00:00
Madhu Rajanna
677be13b11
Merge pull request #583 from nixpanic/mergify/dismiss_reviews 
mergify: Remove approved review when a PR changes
 2019-09-04 15:14:25 +05:30
Niels de Vos
2192d40937 mergify: Remove approved review when a PR changes 
When people have reviewed a PR, and the contributor updates it, the
reviews are staying valid. This is unfortunate as the PR might need new
corrections.

Ideally a positive review (Approved) needs to be given again. And there
needs to be a confirmation that a negative review (Changes requested)
has been addressed.

Closes: #505
Signed-off-by: Niels de Vos <ndevos@redhat.com>
 2019-09-03 14:29:40 +02:00
Madhu Rajanna
ae67534a44 Add wait logic to check fsid from toolbox 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-30 06:50:32 +00:00
Madhu Rajanna
a81a3bf96b implement grpc metrics for ceph-csi 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-30 06:50:32 +00:00
Daniel-Pivonka
01a78cace5 switch to cephfs, utils, and csicommon to new loging system 
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
 2019-08-29 14:04:31 +00:00
Madhu Rajanna
7d3a18c5b7 Fix e2e failure caused due to mon connection from toolbox 
i think now its take time to discover the mon IP
from svc name in tool box, this is a workaround
to fix it.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-29 11:17:54 +00:00
Madhu Rajanna
025aec3dd3 Trace backend volume from pvc 
logs
```
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
| PVC Name |                 PV Name                  |                  Image Name                  | PV name in omap | Image ID in omap | Image in cluster |
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
| rbd-pvc  | pvc-f1a501dd-03f6-45c9-89f4-85eed7a13ef2 | csi-vol-1b00f5f8-b1c1-11e9-8421-9243c1f659f0 |       True      |       True       |      False       |
| rbd-pvcq | pvc-09a8bceb-0f60-4036-85b9-dc89912ae372 | csi-vol-b781b9b1-b1c5-11e9-8421-9243c1f659f0 |       True      |       True       |       True       |
+----------+------------------------------------------+----------------------------------------------+-----------------+------------------+------------------+
```

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-26 14:42:12 +00:00
Madhu Rajanna
3af364e7b5 move to statand context package 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-26 06:19:24 +00:00
Madhu Rajanna
38ca08bf65 Context based logging for rbd 
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-26 06:19:24 +00:00
Daniel-Pivonka
81c28d6cb0 implement klog wrapper 
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
 2019-08-21 14:36:41 +00:00
Daniel-Pivonka
aa74f8c87f Implement context based logging 
Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
 2019-08-21 14:36:41 +00:00
wilmardo
3111e7712a feat: Adds Ceph logo as icon for Helm charts 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-20 05:34:28 +00:00
Humble Devassy Chirammal
3f32dea047
Merge pull request #551 from humblec/dockerfile 
Fix the vulnarabilities in the image.
 2019-08-20 10:28:33 +05:30
Madhu Rajanna
e557438f87 unmap rbd image if connection timeout. 
Sometime rbd images are mapped even if the
connection timeout error occurs, this will
try to unmap if the received error message
is connection timeout.This will fix stale maps
and rbd image deletion issue

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-19 10:54:17 +00:00
Madhu Rajanna
0da4bd5151 start controller or node server based on config 
if both controller and nodeserver flags are set/unset
cephcsi will start both server,

if only one flag is set, it will start relavent
service.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-19 06:11:43 +00:00
Madhu Rajanna
89732d923f move flag configuration variable to util 
remove unwanted checks
remove getting drivertype from binary name

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-19 06:11:43 +00:00
Madhu Rajanna
2b1355061e rename rbd.go to driver.go 
to keep code struct similar with cephfs
renamed rbd.go to driver.go

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-19 06:11:43 +00:00
Humble Chirammal
0fc7f4513b Snashotter update 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-08-19 05:06:42 +00:00
wilmardo
0a90762970 fix: Adds liveness sidecar to v1.14+ helm charts 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-16 08:38:49 +00:00
wilmardo
30fb7de118 feat: Implement helm lint 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-16 07:38:33 +00:00
Humble Chirammal
6950ad468f Fix the vulnarabilities in the image. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-08-14 17:37:33 +05:30
Humble Chirammal
8fddb53931 Make the kube dependency to 1.15.2 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-08-14 07:40:50 +00:00
Humble Chirammal
9a3a04b180 Add container image compatibility matrix. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-08-14 06:48:43 +00:00
Daniel-Pivonka
d621a58207 prometheus liveness probe sidecar 
Signed-off-by: Daniel-Pivonka dpivonka@redhat.com
 2019-08-13 17:51:41 +00:00
Madhu Rajanna
2ca575b99d Wrap error if failed to fetch mon 
This will help user to check whats
the actual error. if the config file
is having issue or the  clusterid is
not valid.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
 2019-08-13 17:16:27 +00:00
wilmardo
cba6115e30 Fix 1.13 charts 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-13 16:42:15 +00:00
wilmardo
c739ce9d5e Removes last reference to node-publish-secret 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-13 16:42:15 +00:00
wilmardo
ca5fbc180c Rework of helm charts 
Signed-off-by: wilmardo <info@wilmardenouden.nl>
 2019-08-13 16:42:15 +00:00
ShyamsundarR
20d336fca3 Add support to use ceph manager rbd command to delete an image 
Image deletion takes time proportional to the size of the
image. Hence, ceph manager is enhanced to support async
deletion of an image, or rather passing the task of
deleting an image to the ceph manager.

This commit leverages the ceph manager enhancement in the CSI code.

NOTE: This is tested against a ceph cluster that is running
Ceph master version of the code. Once other releases
catch up in terms of the feature, the optimization would be
available to the CSI driver as well.

Fixes: #523
Signed-off-by: ShyamsundarR <srangana@redhat.com>
 2019-08-13 16:08:22 +00:00