It seems very common in other Go based projects to place the local
packages in the import statement last. Currently Ceph-CSI expects the
imports to group the local packages immediately after standard packages.
This exception compared to other projects often requires new
contributors to 'correct' their PR.
Following a more common convention for grouping imports should make it a
little easier to contribute to the project.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
This commit updates the key rotation docs with the following changes:
- Do not call LuksVerify
- Mention specifics of RWX volumes
- Rename the file to represent RBD backed volumes
Signed-off-by: black-dragon74 <niryadav@redhat.com>
fsName is optional and its required
to mount the filesystem incase if we have
multiple filesystem in the cluster.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Implemented the capability to include read affinity options
for individual clusters within the ceph-csi-config ConfigMap.
This allows users to configure the crush location for each
cluster separately. The read affinity options specified in
the ConfigMap will supersede those provided via command line arguments.
Signed-off-by: Praveen M <m.praveen@ibm.com>
As shallow volumes are default for ROX pvc from
snapshot, removing the details from doc for better
clarity.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
There are few PSP and clusterrole which does
not exists anymore in cephcsi, removing it
from the upgrade doc for the same reason.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
As Beta CRD is not supported and also
mentioned kubernetes versions are also
not supported anymore, Removing the
details from the doc for the same reason.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
we need to add `storageClassName: ""` in cephfs static pvc
similar what was done for rbd static pvc in #4010.
Signed-off-by: Rakshith R <rar@redhat.com>
we need to add `storageClassName: ""` in static pvc
yaml other we'll get error
```
Cannot bind to requested volume "fs-static-pv": storageClassName does not match
```
Signed-off-by: subhamkrai <srai@redhat.com>
`/retest all` causes a spike in resource consumption in Jenkins and the
OpenShift cluster kills the Pod. That means tests are not fully running
yet, and results never arrive back in the PR. Instead of `/retest all`,
the `ok-to-test` label can be used to trigger required tests with a
slight delay between each command.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Few common files related to deployments were kept
in the examples folder initially. Moving them to
deploy folder and updating the relevant files.
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Currently the Ceph-CSI community is on the 'free' Slack instance at
https://cephcsi.slack.com. The Ceph project uses a Slack instance that
we can use for Ceph-CSI as well. In order to integrate more with other
Ceph projects, we should ideally be active on the same Slack instance.
For now, we have `#ceph-csi` as only channel on the
https://ceph-storage-slack.com, we can add more channels if needed.
See-also: https://ceph.io/en/community/connect/
Signed-off-by: Niels de Vos <ndevos@ibm.com>
we dont support imageFormat anymore in
cephcsi and default is set to 2, removing
its reference from the repo.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.
Fixes: #374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Add the new parameter encryptionType and a hint to the encrypted
parameter that RBD now supports fscrypt on ext4 as an alternative
encryption scheme.
Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
the pre-commit version in the developement guide was too outdated
which has been updated and this commit also addressed a typo.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
this issue has been already fixed long back and available with
ceph backports. We no longer require this mention in the docs.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
based on the discussion on the slack
channel. we are adding a github action
to trigger the CI jobs when a ok-to-test
label is added on the PR.
This action is based on below github action
https://github.com/peter-evans/create-or-update-comment
Sample Demo avaiable at
https://github.com/Madhu-1/
\label-commentor-action-testing/pull/4
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
As we dont need to delete the nfs daemonset
which was present in 3.6.x release in 3.8.x
release as user will upgrade from 3.6.x to
3.7.x and delete the nfs daemonset.
fixes#3324
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
