Niels de Vos
689498e66a
rbd: move common functions for VolumeGroup structs into own type
...
Many functions that are implemented for the volumeGroup type can be
shared with the (coming) volumeGroupSnapshot type. Move these functions
into a commonVolumeGroup type, so that volumeGroup and
volumeGroupSnapshot can inherit them.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-28 11:46:29 +00:00
Madhu Rajanna
3ac596840c
rbd: add a check for CSI pv
...
add a check for CSI as it can be
nil for non-csi PV.
fixes : #4807
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-27 17:08:44 +00:00
dependabot[bot]
4f357b7e27
rebase: bump the github-dependencies group with 3 updates
...
Bumps the github-dependencies group with 3 updates: [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2 ), [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo ) and [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ).
Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.30.4 to 1.30.5
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases )
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.30.4...service/s3/v1.30.5 )
Updates `github.com/onsi/ginkgo/v2` from 2.20.0 to 2.20.1
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v2.20.0...v2.20.1 )
Updates `github.com/prometheus/client_golang` from 1.20.1 to 1.20.2
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.20.1...v1.20.2 )
---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sts
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
- dependency-name: github.com/onsi/ginkgo/v2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
- dependency-name: github.com/prometheus/client_golang
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-27 13:30:42 +00:00
Niels de Vos
cde5048dd2
ci: pass the correct account token for Snyk jobs
...
The secret in the project settings has a typo and is called `SYNK_TOKEN`
instead of `SNYK_TOKEN`. Changing the name of the secret does not seem
to be trivial; it needs to be deleted and re-created, which requires
obtaining a new token, somehow. Adopting the name with the typo in the
GitHub Workflow is easier.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-27 09:58:24 +00:00
dependabot[bot]
5c934d08f2
rebase: bump golang.org/x/oauth2 in /actions/retest
...
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2 ) from 0.18.0 to 0.22.0.
- [Commits](https://github.com/golang/oauth2/compare/v0.18.0...v0.22.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-27 09:52:30 +00:00
Niraj Yadav
91b8efe473
doc: Remove the 400 snapshot limitation
...
The support for more than 400 snapshots was
added at: https://github.com/ceph/ceph/pull/38553
This patch also removes the note regarding
deletion of PVCs with snapshots.
Closes : #4681
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-08-27 09:24:35 +00:00
Dmytro Alieksieiev
601c40b1d8
helm: Always add nodes read permissions to provisioner ClusterRole
...
Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
2024-08-27 09:16:31 +00:00
dependabot[bot]
1865ce0b28
rebase: bump golang.org/x/net from 0.22.0 to 0.23.0 in /actions/retest
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.22.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.22.0...v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-26 08:43:07 +00:00
Niraj Yadav
e19c28927f
build: Update go version to 1.22.5 for submodules
...
This patch updates the submodules api and retest to
use the go version 1.22.5
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-08-22 11:22:39 +00:00
dependabot[bot]
b044363a31
rebase: bump the github-dependencies group across 1 directory with 4 updates
...
Bumps the github-dependencies group with 4 updates in the / directory: [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2 ), [github.com/kubernetes-csi/csi-lib-utils](https://github.com/kubernetes-csi/csi-lib-utils ), [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo ) and [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ).
Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.30.3 to 1.30.4
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases )
- [Commits](https://github.com/aws/aws-sdk-go-v2/compare/v1.30.3...v1.30.4 )
Updates `github.com/kubernetes-csi/csi-lib-utils` from 0.18.1 to 0.19.0
- [Release notes](https://github.com/kubernetes-csi/csi-lib-utils/releases )
- [Commits](https://github.com/kubernetes-csi/csi-lib-utils/compare/v0.18.1...v0.19.0 )
Updates `github.com/onsi/ginkgo/v2` from 2.19.1 to 2.20.0
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v2.19.1...v2.20.0 )
Updates `github.com/prometheus/client_golang` from 1.19.1 to 1.20.1
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.1/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.19.1...v1.20.1 )
---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sts
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
- dependency-name: github.com/kubernetes-csi/csi-lib-utils
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/onsi/ginkgo/v2
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/prometheus/client_golang
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-22 10:52:39 +00:00
Nikhil-Ladha
4da71363b5
ci: update mergify config to replace,remove deprecated attributes
...
update mergify config to remove, replace the deprecated attributes.
Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2024-08-21 20:24:22 +00:00
Madhu Rajanna
38fd27a209
rbd: add image size in toSnapshot
...
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.
fixes : #4788
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-21 20:14:51 +00:00
Praveen M
9181d20d33
helm: add immediate-topology flag to external-provisioner
...
Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-08-21 13:39:53 +00:00
Praveen M
55f221ff50
deploy: add immediate-topology flag to external-provisioner
...
In csi-external-provisioner: v5.0.1, topology-aware
provisioning is enabled by default. As a result provisioner
now expects toologyKeys to be present in CSINode object which
must be passed by user via `--domainlabels` flag in RBD nodeplugin.
Issue: Users upgrading to v3.12.0 who were not previously using
topology-aware provisioning may encounter issues when provisionining
RBD PVCs, as the `--domainlabels` flag might not be set.
Fix: To address this, add `--immediate-topology=false` to disable
topology-aware provisioning. User requiring topology-aware
provisioning should provided the volumeBindingMode as
`WaitForFirstConsumer` and `TopologyConstrainedPools` as required in
the StorageClass and configure `--domainlabels` flag in RBD nodeplugin.
Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-08-21 13:39:53 +00:00
Niraj Yadav
cc6835eee8
build: Use Go v1.22.5
...
Go versions 1.22.0 through 1.22.4 are affected
by CVE-2024-24791
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-08-20 13:30:27 +00:00
Praveen M
3570ac408a
ci: update CSI_UPGRADE_VERSION to v3.12.1
...
Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-08-20 12:59:47 +00:00
Madhu Rajanna
af47630899
rebase: remove prometheus from replace
...
removed prometheus/client_golang and
prometheus/common from replace section
in go.mod as they are not required anymore
to be in replace section.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Madhu Rajanna
681f725a33
rebase: add k8s.io/cri-client to go.mod
...
adding k8s.io/cri-client to the replace
section in the go.mod to fix below problem
```
running: go list -mod=readonly -m all
go: k8s.io/cri-client@v0.0.0:
invalid version: unknown revision v0.0.0
```
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Madhu Rajanna
fbb9687a80
rebase: update go-ceph to latest
...
updating go-ceph to latest
0.29.0 release.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Madhu Rajanna
dbbca6ebf8
rebase: update controller-runtime
...
update controller-runtime to latest
release.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Madhu Rajanna
5a66991bb3
rebase: update kubernetes to latest
...
updating the kubernetes release to the
latest in main go.mod
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Madhu Rajanna
63c4c05b35
rebase: update kubernetes in api folder
...
updating the kubernetes to 1.31.0 in the
api folder.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-20 08:17:01 +00:00
Mark Glines
2c0e65b828
helm: don't specify default topology domainlabels in rbd chart
...
Remove the bad default, add commented-out standard labels as a suggestion.
Fixes : #4775
Signed-off-by: Mark Glines <mark@glines.org>
2024-08-19 10:23:06 +00:00
ShravaniVangur
0eabe32b76
deploy: setting RequiredDropCapabilities to ALL for ceph-csi scc
...
This commit sets the RequiredDropCapabilities of ceph-csi to "ALL".
Signed-off-by: ShravaniVangur <shravanivangur@gmail.com>
2024-08-15 12:00:02 +00:00
Madhu Rajanna
b0751cb06e
ci: update rules for 3.12 release
...
updating release for 3.12 release
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-14 15:11:41 +00:00
Madhu Rajanna
50c202b5f8
doc: update the upgrade doc
...
updating the upgrade doc to
point to 3.12.0 doc for upgrades.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-14 15:11:41 +00:00
Madhu Rajanna
2241e8e074
doc: readme update for 3.12
...
readme update for 3.12.0 release
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-14 15:11:41 +00:00
Madhu Rajanna
dfa565525a
ci: remove feature gates
...
Remove the feature gates as they
are not required anymore as they
are already in beta and few removed
in 1.31.0
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-08-14 14:40:36 +00:00
dependabot[bot]
fb9403e820
rebase: bump sigs.k8s.io/controller-runtime
...
Bumps the k8s-dependencies group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ).
Updates `sigs.k8s.io/controller-runtime` from 0.18.4 to 0.18.5
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.18.4...v0.18.5 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-14 09:57:59 +00:00
dependabot[bot]
3db33b176b
rebase: bump the golang-dependencies group with 3 updates
...
Bumps the golang-dependencies group with 3 updates: [golang.org/x/crypto](https://github.com/golang/crypto ), [golang.org/x/net](https://github.com/golang/net ) and [golang.org/x/sys](https://github.com/golang/sys ).
Updates `golang.org/x/crypto` from 0.25.0 to 0.26.0
- [Commits](https://github.com/golang/crypto/compare/v0.25.0...v0.26.0 )
Updates `golang.org/x/net` from 0.27.0 to 0.28.0
- [Commits](https://github.com/golang/net/compare/v0.27.0...v0.28.0 )
Updates `golang.org/x/sys` from 0.23.0 to 0.24.0
- [Commits](https://github.com/golang/sys/compare/v0.23.0...v0.24.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: golang-dependencies
- dependency-name: golang.org/x/net
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: golang-dependencies
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: golang-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-13 18:12:03 +00:00
Nikhil-Ladha
71cbf3d7eb
ci: add test for uncommitted changes in deploy directory
...
added test for uncommitted changes in deploy directory under go-test GH action.
Also, created a new make target named `make check-deploy-committed` that
can be used to verify the uncommitted changes.
Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
2024-08-13 12:17:43 +00:00
Praveen M
e150fd986b
journal: fix empty csiCreationTimeKey value
...
This commit fixes the issue where the `csiCreationTimeKey`
field was missing during the rebuilding of the
`VolumeGroupJournalConfig` struct in the `Connect()` method,
which led to the `csi.creationtime` key not being stored in
the omap.
Signed-off-by: Praveen M <m.praveen@ibm.com>
2024-08-13 07:22:26 +00:00
Niels de Vos
869aaced7d
rbd: convert rbdVolume to rbdSnapshot
...
After cloning the RBD snapshot, an rbdVolume is returned for the
CSI.Snapshot object. In order to use the rbdSnapshot.ToCSI() function,
the rbdVolume needs to be converted (back) to an rbdSnaphot.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 14:58:59 +00:00
Niels de Vos
503d10eb1a
journal: store CreationTime for VolumeGroups
...
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 14:58:59 +00:00
Niels de Vos
6d1ab1b8d9
rbd: have GetCreationTime() return a time.Time struct
...
Do not use protobuf types when there is no need. Just use the standard
time.Time format instead.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 14:58:59 +00:00
Niels de Vos
2fd92573f4
ci: prevent incorrect pattern matching for skipping ci
command
...
Mergify matches `body-raw` as regular expression, but that makes it
difficult (if not impossible) to match the `[` in a string.
Fixes : #4751
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 10:50:56 +00:00
Niels de Vos
d06497cf32
doc: add description of Mergify commands for merging a PR
...
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 10:06:28 +00:00
Niels de Vos
4a46ffd2b7
ci: detect [skip ci]
in PR descriptions and prevent breakage
...
When Jenkins jobs are started by a comment, and if the PR contains
`[skip ci]` in the description, Jenkins does not run the requested job,
nor set a status for the job in the PR.
This causes Mergify to add the `ok-to-test` label again, instructing a
GitHub Action to add comments to start jobs in Jenkins. Once all
comments have been posted, the `ok-to-test` label is removed. Mergify
then notices that the jobs were not run, and adds the `ok-to-test` label
again.... Endlessly looping of adding the label, commenting and removing
the label as a result.
By reporting the brokenness of the PR description and marking the PR as
Draft, the looping is prevented.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-09 10:06:28 +00:00
dependabot[bot]
dabf3c4099
rebase: bump the github-dependencies group with 3 updates
...
Bumps the github-dependencies group with 3 updates: [github.com/IBM/keyprotect-go-client](https://github.com/IBM/keyprotect-go-client ), [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go ) and [github.com/onsi/gomega](https://github.com/onsi/gomega ).
Updates `github.com/IBM/keyprotect-go-client` from 0.14.3 to 0.15.1
- [Release notes](https://github.com/IBM/keyprotect-go-client/releases )
- [Changelog](https://github.com/IBM/keyprotect-go-client/blob/master/CHANGELOG.md )
- [Commits](https://github.com/IBM/keyprotect-go-client/compare/v0.14.3...v0.15.1 )
Updates `github.com/aws/aws-sdk-go` from 1.55.4 to 1.55.5
- [Release notes](https://github.com/aws/aws-sdk-go/releases )
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.55.4...v1.55.5 )
Updates `github.com/onsi/gomega` from 1.34.0 to 1.34.1
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.34.0...v1.34.1 )
---
updated-dependencies:
- dependency-name: github.com/IBM/keyprotect-go-client
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
- dependency-name: github.com/onsi/gomega
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-06 22:41:49 +00:00
dependabot[bot]
ee503fae54
rebase: bump golang.org/x/sys in the golang-dependencies group
...
Bumps the golang-dependencies group with 1 update: [golang.org/x/sys](https://github.com/golang/sys ).
Updates `golang.org/x/sys` from 0.22.0 to 0.23.0
- [Commits](https://github.com/golang/sys/compare/v0.22.0...v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: golang-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-06 14:37:43 +00:00
Niels de Vos
130e8b42f2
cephfs: use conf.InstanceID instead of global variable
...
RBD does not have a global CSIInstanceID variable anymore, there is no
need for CephFS to use one either.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-05 17:04:52 +00:00
Niels de Vos
dfb48bac17
util: add CSIDriver.GetInstanceID()
...
There has been some confusion about using different variables for the
InstanceID of the RBD-driver. By removing the global variable
CSIInstanceID, there should be no confusion anymore what variable to
use.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-05 17:04:52 +00:00
Niraj Yadav
0092a47586
doc: Remove podSecurityPolicy from helm docs
...
Fixes : #4714
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
2024-08-05 09:53:42 +00:00
Niels de Vos
db6f54f75d
ci: disable seccomp when running podman with GitHub Actions
...
Fedora 40 builds seems to require disabling seccomp. When enabled,
installing Golang inside the container fails.
See-also: containers/podman#21012
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-01 08:31:12 +00:00
Niels de Vos
a8d1b9dfe5
ci: use latest Fedora container-image
...
GitHub had issues with Fedora 40 when it was released. Hopefully this is
not the case anymore.
Closes : #4585
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-08-01 08:31:12 +00:00
Niels de Vos
e3697f4d3e
doc: inform users that the OS in the container-image is updated
...
The Squid container-image that is used as base for the Ceph-CSI
container-image uses CentOS Stream 9.
Closes : #4659
Signed-off-by: Niels de Vos <ndevos@ibm.com>
2024-07-31 14:12:59 +00:00
Madhu Rajanna
3a8981a735
rbd: add support to get volumegroupID
...
updated GetIDFromReplication to return
volumeGroupID if its present.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-31 12:16:42 +00:00
Madhu Rajanna
f7c78ae4fe
rbd: update group Stringer method
...
updated the group stringer method
to have pool and namespace for
proper debugging/logging and to
use it with CLI as agrument as well.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-31 12:16:42 +00:00
Madhu Rajanna
37970ae212
rbd: add context to mirror interface
...
adding required ctx to the mirror
interface as ctx is required for
the volumegroup operations.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-31 12:16:42 +00:00
Madhu Rajanna
8788e5ec08
rbd: adapt to GetVolumeByID error message
...
GetVolumeByID already returning detailed
error message, the caller just need to return
it. No need to add duplicate details to error
message.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
2024-07-31 12:16:42 +00:00