2019-06-24 09:08:09 +00:00
|
|
|
/*
|
|
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package featuregate
|
|
|
|
|
|
|
|
import (
|
2023-02-01 17:06:36 +00:00
|
|
|
"context"
|
2019-06-24 09:08:09 +00:00
|
|
|
"fmt"
|
2024-08-19 08:01:33 +00:00
|
|
|
"reflect"
|
2019-06-24 09:08:09 +00:00
|
|
|
"sort"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
|
|
|
"sync"
|
|
|
|
"sync/atomic"
|
|
|
|
|
|
|
|
"github.com/spf13/pflag"
|
2020-01-14 10:38:55 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
utilerrors "k8s.io/apimachinery/pkg/util/errors"
|
2020-01-14 10:38:55 +00:00
|
|
|
"k8s.io/apimachinery/pkg/util/naming"
|
2024-08-19 08:01:33 +00:00
|
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
|
|
"k8s.io/apimachinery/pkg/util/version"
|
2023-02-01 17:06:36 +00:00
|
|
|
featuremetrics "k8s.io/component-base/metrics/prometheus/feature"
|
2024-08-19 08:01:33 +00:00
|
|
|
baseversion "k8s.io/component-base/version"
|
2020-12-17 12:28:29 +00:00
|
|
|
"k8s.io/klog/v2"
|
2019-06-24 09:08:09 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
type Feature string
|
|
|
|
|
|
|
|
const (
|
|
|
|
flagName = "feature-gates"
|
|
|
|
|
|
|
|
// allAlphaGate is a global toggle for alpha features. Per-feature key
|
|
|
|
// values override the default set by allAlphaGate. Examples:
|
|
|
|
// AllAlpha=false,NewFeature=true will result in newFeature=true
|
|
|
|
// AllAlpha=true,NewFeature=false will result in newFeature=false
|
|
|
|
allAlphaGate Feature = "AllAlpha"
|
2020-01-14 10:38:55 +00:00
|
|
|
|
|
|
|
// allBetaGate is a global toggle for beta features. Per-feature key
|
|
|
|
// values override the default set by allBetaGate. Examples:
|
|
|
|
// AllBeta=false,NewFeature=true will result in NewFeature=true
|
|
|
|
// AllBeta=true,NewFeature=false will result in NewFeature=false
|
|
|
|
allBetaGate Feature = "AllBeta"
|
2019-06-24 09:08:09 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
|
|
|
// The generic features.
|
2024-08-19 08:01:33 +00:00
|
|
|
defaultFeatures = map[Feature]VersionedSpecs{
|
|
|
|
allAlphaGate: {{Default: false, PreRelease: Alpha, Version: version.MajorMinor(0, 0)}},
|
|
|
|
allBetaGate: {{Default: false, PreRelease: Beta, Version: version.MajorMinor(0, 0)}},
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Special handling for a few gates.
|
2024-08-19 08:01:33 +00:00
|
|
|
specialFeatures = map[Feature]func(known map[Feature]VersionedSpecs, enabled map[Feature]bool, val bool, cVer *version.Version){
|
2019-06-24 09:08:09 +00:00
|
|
|
allAlphaGate: setUnsetAlphaGates,
|
2020-01-14 10:38:55 +00:00
|
|
|
allBetaGate: setUnsetBetaGates,
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
)
|
|
|
|
|
|
|
|
type FeatureSpec struct {
|
|
|
|
// Default is the default enablement state for the feature
|
|
|
|
Default bool
|
|
|
|
// LockToDefault indicates that the feature is locked to its default and cannot be changed
|
|
|
|
LockToDefault bool
|
2024-08-19 08:01:33 +00:00
|
|
|
// PreRelease indicates the current maturity level of the feature
|
2019-06-24 09:08:09 +00:00
|
|
|
PreRelease prerelease
|
2024-08-19 08:01:33 +00:00
|
|
|
// Version indicates the earliest version from which this FeatureSpec is valid.
|
|
|
|
// If multiple FeatureSpecs exist for a Feature, the one with the highest version that is less
|
|
|
|
// than or equal to the effective version of the component is used.
|
|
|
|
Version *version.Version
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
type VersionedSpecs []FeatureSpec
|
|
|
|
|
|
|
|
func (g VersionedSpecs) Len() int { return len(g) }
|
|
|
|
func (g VersionedSpecs) Less(i, j int) bool {
|
|
|
|
return g[i].Version.LessThan(g[j].Version)
|
|
|
|
}
|
|
|
|
func (g VersionedSpecs) Swap(i, j int) { g[i], g[j] = g[j], g[i] }
|
|
|
|
|
|
|
|
type PromotionVersionMapping map[prerelease]string
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
type prerelease string
|
|
|
|
|
|
|
|
const (
|
2024-08-19 08:01:33 +00:00
|
|
|
PreAlpha = prerelease("PRE-ALPHA")
|
2019-06-24 09:08:09 +00:00
|
|
|
// Values for PreRelease.
|
|
|
|
Alpha = prerelease("ALPHA")
|
|
|
|
Beta = prerelease("BETA")
|
|
|
|
GA = prerelease("")
|
|
|
|
|
|
|
|
// Deprecated
|
|
|
|
Deprecated = prerelease("DEPRECATED")
|
|
|
|
)
|
|
|
|
|
|
|
|
// FeatureGate indicates whether a given feature is enabled or not
|
|
|
|
type FeatureGate interface {
|
|
|
|
// Enabled returns true if the key is enabled.
|
|
|
|
Enabled(key Feature) bool
|
|
|
|
// KnownFeatures returns a slice of strings describing the FeatureGate's known features.
|
|
|
|
KnownFeatures() []string
|
|
|
|
// DeepCopy returns a deep copy of the FeatureGate object, such that gates can be
|
|
|
|
// set on the copy without mutating the original. This is useful for validating
|
|
|
|
// config against potential feature gate changes before committing those changes.
|
2024-08-19 08:01:33 +00:00
|
|
|
DeepCopy() MutableVersionedFeatureGate
|
|
|
|
// Validate checks if the flag gates are valid at the emulated version.
|
|
|
|
Validate() []error
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// MutableFeatureGate parses and stores flag gates for known features from
|
|
|
|
// a string like feature1=true,feature2=false,...
|
|
|
|
type MutableFeatureGate interface {
|
|
|
|
FeatureGate
|
|
|
|
|
|
|
|
// AddFlag adds a flag for setting global feature gates to the specified FlagSet.
|
|
|
|
AddFlag(fs *pflag.FlagSet)
|
2024-08-19 08:01:33 +00:00
|
|
|
// Close sets closed to true, and prevents subsequent calls to Add
|
|
|
|
Close()
|
2019-06-24 09:08:09 +00:00
|
|
|
// Set parses and stores flag gates for known features
|
|
|
|
// from a string like feature1=true,feature2=false,...
|
|
|
|
Set(value string) error
|
|
|
|
// SetFromMap stores flag gates for known features from a map[string]bool or returns an error
|
|
|
|
SetFromMap(m map[string]bool) error
|
|
|
|
// Add adds features to the featureGate.
|
|
|
|
Add(features map[Feature]FeatureSpec) error
|
2021-08-09 07:19:24 +00:00
|
|
|
// GetAll returns a copy of the map of known feature names to feature specs.
|
|
|
|
GetAll() map[Feature]FeatureSpec
|
2023-02-01 17:06:36 +00:00
|
|
|
// AddMetrics adds feature enablement metrics
|
|
|
|
AddMetrics()
|
2024-05-15 06:54:18 +00:00
|
|
|
// OverrideDefault sets a local override for the registered default value of a named
|
|
|
|
// feature. If the feature has not been previously registered (e.g. by a call to Add), has a
|
|
|
|
// locked default, or if the gate has already registered itself with a FlagSet, a non-nil
|
|
|
|
// error is returned.
|
|
|
|
//
|
|
|
|
// When two or more components consume a common feature, one component can override its
|
|
|
|
// default at runtime in order to adopt new defaults before or after the other
|
|
|
|
// components. For example, a new feature can be evaluated with a limited blast radius by
|
|
|
|
// overriding its default to true for a limited number of components without simultaneously
|
|
|
|
// changing its default for all consuming components.
|
|
|
|
OverrideDefault(name Feature, override bool) error
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// MutableVersionedFeatureGate parses and stores flag gates for known features from
|
|
|
|
// a string like feature1=true,feature2=false,...
|
|
|
|
// MutableVersionedFeatureGate sets options based on the emulated version of the featured gate.
|
|
|
|
type MutableVersionedFeatureGate interface {
|
|
|
|
MutableFeatureGate
|
|
|
|
// EmulationVersion returns the version the feature gate is set to emulate.
|
|
|
|
// If set, the feature gate would enable/disable features based on
|
|
|
|
// feature availability and pre-release at the emulated version instead of the binary version.
|
|
|
|
EmulationVersion() *version.Version
|
|
|
|
// SetEmulationVersion overrides the emulationVersion of the feature gate.
|
|
|
|
// Otherwise, the emulationVersion will be the same as the binary version.
|
|
|
|
// If set, the feature defaults and availability will be as if the binary is at the emulated version.
|
|
|
|
SetEmulationVersion(emulationVersion *version.Version) error
|
|
|
|
// GetAll returns a copy of the map of known feature names to versioned feature specs.
|
|
|
|
GetAllVersioned() map[Feature]VersionedSpecs
|
|
|
|
// AddVersioned adds versioned feature specs to the featureGate.
|
|
|
|
AddVersioned(features map[Feature]VersionedSpecs) error
|
|
|
|
// OverrideDefaultAtVersion sets a local override for the registered default value of a named
|
|
|
|
// feature for the prerelease lifecycle the given version is at.
|
|
|
|
// If the feature has not been previously registered (e.g. by a call to Add),
|
|
|
|
// has a locked default, or if the gate has already registered itself with a FlagSet, a non-nil
|
|
|
|
// error is returned.
|
|
|
|
//
|
|
|
|
// When two or more components consume a common feature, one component can override its
|
|
|
|
// default at runtime in order to adopt new defaults before or after the other
|
|
|
|
// components. For example, a new feature can be evaluated with a limited blast radius by
|
|
|
|
// overriding its default to true for a limited number of components without simultaneously
|
|
|
|
// changing its default for all consuming components.
|
|
|
|
OverrideDefaultAtVersion(name Feature, override bool, ver *version.Version) error
|
|
|
|
// ExplicitlySet returns true if the feature value is explicitly set instead of
|
|
|
|
// being derived from the default values or special features.
|
|
|
|
ExplicitlySet(name Feature) bool
|
|
|
|
// ResetFeatureValueToDefault resets the value of the feature back to the default value.
|
|
|
|
ResetFeatureValueToDefault(name Feature) error
|
|
|
|
// DeepCopyAndReset copies all the registered features of the FeatureGate object, with all the known features and overrides,
|
|
|
|
// and resets all the enabled status of the new feature gate.
|
|
|
|
// This is useful for creating a new instance of feature gate without inheriting all the enabled configurations of the base feature gate.
|
|
|
|
DeepCopyAndReset() MutableVersionedFeatureGate
|
|
|
|
}
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
// featureGate implements FeatureGate as well as pflag.Value for flag parsing.
|
|
|
|
type featureGate struct {
|
2020-01-14 10:38:55 +00:00
|
|
|
featureGateName string
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
special map[Feature]func(map[Feature]VersionedSpecs, map[Feature]bool, bool, *version.Version)
|
2019-06-24 09:08:09 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// lock guards writes to all below fields.
|
2019-06-24 09:08:09 +00:00
|
|
|
lock sync.Mutex
|
|
|
|
// known holds a map[Feature]FeatureSpec
|
2024-05-15 06:54:18 +00:00
|
|
|
known atomic.Value
|
2019-06-24 09:08:09 +00:00
|
|
|
// enabled holds a map[Feature]bool
|
2024-05-15 06:54:18 +00:00
|
|
|
enabled atomic.Value
|
2024-08-19 08:01:33 +00:00
|
|
|
// enabledRaw holds a raw map[string]bool of the parsed flag.
|
|
|
|
// It keeps the original values of "special" features like "all alpha gates",
|
|
|
|
// while enabled keeps the values of all resolved features.
|
|
|
|
enabledRaw atomic.Value
|
2019-06-24 09:08:09 +00:00
|
|
|
// closed is set to true when AddFlag is called, and prevents subsequent calls to Add
|
|
|
|
closed bool
|
2024-08-19 08:01:33 +00:00
|
|
|
// queriedFeatures stores all the features that have been queried through the Enabled interface.
|
|
|
|
// It is reset when SetEmulationVersion is called.
|
|
|
|
queriedFeatures atomic.Value
|
|
|
|
emulationVersion atomic.Pointer[version.Version]
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
func setUnsetAlphaGates(known map[Feature]VersionedSpecs, enabled map[Feature]bool, val bool, cVer *version.Version) {
|
2019-06-24 09:08:09 +00:00
|
|
|
for k, v := range known {
|
2024-08-19 08:01:33 +00:00
|
|
|
if k == "AllAlpha" || k == "AllBeta" {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
featureSpec := featureSpecAtEmulationVersion(v, cVer)
|
|
|
|
if featureSpec.PreRelease == Alpha {
|
2019-06-24 09:08:09 +00:00
|
|
|
if _, found := enabled[k]; !found {
|
|
|
|
enabled[k] = val
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
func setUnsetBetaGates(known map[Feature]VersionedSpecs, enabled map[Feature]bool, val bool, cVer *version.Version) {
|
2020-01-14 10:38:55 +00:00
|
|
|
for k, v := range known {
|
2024-08-19 08:01:33 +00:00
|
|
|
if k == "AllAlpha" || k == "AllBeta" {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
featureSpec := featureSpecAtEmulationVersion(v, cVer)
|
|
|
|
if featureSpec.PreRelease == Beta {
|
2020-01-14 10:38:55 +00:00
|
|
|
if _, found := enabled[k]; !found {
|
|
|
|
enabled[k] = val
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
// Set, String, and Type implement pflag.Value
|
|
|
|
var _ pflag.Value = &featureGate{}
|
|
|
|
|
2020-01-14 10:38:55 +00:00
|
|
|
// internalPackages are packages that ignored when creating a name for featureGates. These packages are in the common
|
|
|
|
// call chains, so they'd be unhelpful as names.
|
|
|
|
var internalPackages = []string{"k8s.io/component-base/featuregate/feature_gate.go"}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// NewVersionedFeatureGate creates a feature gate with the emulation version set to the provided version.
|
|
|
|
// SetEmulationVersion can be called after to change emulation version to a desired value.
|
|
|
|
func NewVersionedFeatureGate(emulationVersion *version.Version) *featureGate {
|
|
|
|
known := map[Feature]VersionedSpecs{}
|
2019-06-24 09:08:09 +00:00
|
|
|
for k, v := range defaultFeatures {
|
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
|
|
|
|
f := &featureGate{
|
2020-01-14 10:38:55 +00:00
|
|
|
featureGateName: naming.GetNameFromCallsite(internalPackages...),
|
|
|
|
special: specialFeatures,
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
2024-05-15 06:54:18 +00:00
|
|
|
f.known.Store(known)
|
|
|
|
f.enabled.Store(map[Feature]bool{})
|
2024-08-19 08:01:33 +00:00
|
|
|
f.enabledRaw.Store(map[string]bool{})
|
|
|
|
f.emulationVersion.Store(emulationVersion)
|
|
|
|
f.queriedFeatures.Store(sets.Set[Feature]{})
|
|
|
|
klog.V(1).Infof("new feature gate with emulationVersion=%s", f.emulationVersion.Load().String())
|
2019-06-24 09:08:09 +00:00
|
|
|
return f
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// NewFeatureGate creates a feature gate with the current binary version.
|
|
|
|
func NewFeatureGate() *featureGate {
|
|
|
|
binaryVersison := version.MustParse(baseversion.DefaultKubeBinaryVersion)
|
|
|
|
return NewVersionedFeatureGate(binaryVersison)
|
|
|
|
}
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
// Set parses a string of the form "key1=value1,key2=value2,..." into a
|
|
|
|
// map[string]bool of known keys or returns an error.
|
|
|
|
func (f *featureGate) Set(value string) error {
|
|
|
|
m := make(map[string]bool)
|
|
|
|
for _, s := range strings.Split(value, ",") {
|
|
|
|
if len(s) == 0 {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
arr := strings.SplitN(s, "=", 2)
|
|
|
|
k := strings.TrimSpace(arr[0])
|
|
|
|
if len(arr) != 2 {
|
|
|
|
return fmt.Errorf("missing bool value for %s", k)
|
|
|
|
}
|
|
|
|
v := strings.TrimSpace(arr[1])
|
|
|
|
boolValue, err := strconv.ParseBool(v)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("invalid value of %s=%s, err: %v", k, v, err)
|
|
|
|
}
|
|
|
|
m[k] = boolValue
|
|
|
|
}
|
|
|
|
return f.SetFromMap(m)
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// Validate checks if the flag gates are valid at the emulated version.
|
|
|
|
func (f *featureGate) Validate() []error {
|
2019-06-24 09:08:09 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
2024-08-19 08:01:33 +00:00
|
|
|
m, ok := f.enabledRaw.Load().(map[string]bool)
|
|
|
|
if !ok {
|
|
|
|
return []error{fmt.Errorf("cannot cast enabledRaw to map[string]bool")}
|
|
|
|
}
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
return f.unsafeSetFromMap(enabled, m, f.EmulationVersion())
|
|
|
|
}
|
2019-06-24 09:08:09 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// unsafeSetFromMap stores flag gates for known features from a map[string]bool into an enabled map.
|
|
|
|
func (f *featureGate) unsafeSetFromMap(enabled map[Feature]bool, m map[string]bool, emulationVersion *version.Version) []error {
|
|
|
|
var errs []error
|
2019-06-24 09:08:09 +00:00
|
|
|
// Copy existing state
|
2024-08-19 08:01:33 +00:00
|
|
|
known := map[Feature]VersionedSpecs{}
|
|
|
|
for k, v := range f.known.Load().(map[Feature]VersionedSpecs) {
|
|
|
|
sort.Sort(v)
|
2019-06-24 09:08:09 +00:00
|
|
|
known[k] = v
|
|
|
|
}
|
|
|
|
|
|
|
|
for k, v := range m {
|
2024-08-19 08:01:33 +00:00
|
|
|
key := Feature(k)
|
|
|
|
versionedSpecs, ok := known[key]
|
2019-06-24 09:08:09 +00:00
|
|
|
if !ok {
|
2024-08-19 08:01:33 +00:00
|
|
|
// early return if encounters an unknown feature.
|
|
|
|
errs = append(errs, fmt.Errorf("unrecognized feature gate: %s", k))
|
|
|
|
return errs
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
featureSpec := featureSpecAtEmulationVersion(versionedSpecs, emulationVersion)
|
2019-06-24 09:08:09 +00:00
|
|
|
if featureSpec.LockToDefault && featureSpec.Default != v {
|
2024-08-19 08:01:33 +00:00
|
|
|
errs = append(errs, fmt.Errorf("cannot set feature gate %v to %v, feature is locked to %v", k, v, featureSpec.Default))
|
|
|
|
continue
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
// Handle "special" features like "all alpha gates"
|
2024-08-19 08:01:33 +00:00
|
|
|
if fn, found := f.special[key]; found {
|
|
|
|
fn(known, enabled, v, emulationVersion)
|
|
|
|
enabled[key] = v
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
if featureSpec.PreRelease == PreAlpha {
|
|
|
|
errs = append(errs, fmt.Errorf("cannot set feature gate %v to %v, feature is PreAlpha at emulated version %s", k, v, emulationVersion.String()))
|
|
|
|
continue
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
enabled[key] = v
|
2019-06-24 09:08:09 +00:00
|
|
|
|
|
|
|
if featureSpec.PreRelease == Deprecated {
|
|
|
|
klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v)
|
|
|
|
} else if featureSpec.PreRelease == GA {
|
|
|
|
klog.Warningf("Setting GA feature gate %s=%t. It will be removed in a future release.", k, v)
|
|
|
|
}
|
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
return errs
|
|
|
|
}
|
2019-06-24 09:08:09 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// SetFromMap stores flag gates for known features from a map[string]bool or returns an error
|
|
|
|
func (f *featureGate) SetFromMap(m map[string]bool) error {
|
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
2019-06-24 09:08:09 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// Copy existing state
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
enabled[k] = v
|
|
|
|
}
|
|
|
|
enabledRaw := map[string]bool{}
|
|
|
|
for k, v := range f.enabledRaw.Load().(map[string]bool) {
|
|
|
|
enabledRaw[k] = v
|
|
|
|
}
|
|
|
|
|
|
|
|
// Update enabledRaw first.
|
|
|
|
// SetFromMap might be called when emulationVersion is not finalized yet, and we do not know the final state of enabled.
|
|
|
|
// But the flags still need to be saved.
|
|
|
|
for k, v := range m {
|
|
|
|
enabledRaw[k] = v
|
|
|
|
}
|
|
|
|
f.enabledRaw.Store(enabledRaw)
|
|
|
|
|
|
|
|
errs := f.unsafeSetFromMap(enabled, enabledRaw, f.EmulationVersion())
|
|
|
|
if len(errs) == 0 {
|
|
|
|
// Persist changes
|
|
|
|
f.enabled.Store(enabled)
|
|
|
|
klog.V(1).Infof("feature gates: %v", f.enabled)
|
|
|
|
}
|
|
|
|
return utilerrors.NewAggregate(errs)
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// String returns a string containing all enabled feature gates, formatted as "key1=value1,key2=value2,...".
|
|
|
|
func (f *featureGate) String() string {
|
|
|
|
pairs := []string{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
pairs = append(pairs, fmt.Sprintf("%s=%t", k, v))
|
|
|
|
}
|
|
|
|
sort.Strings(pairs)
|
|
|
|
return strings.Join(pairs, ",")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) Type() string {
|
|
|
|
return "mapStringBool"
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add adds features to the featureGate.
|
|
|
|
func (f *featureGate) Add(features map[Feature]FeatureSpec) error {
|
2024-08-19 08:01:33 +00:00
|
|
|
vs := map[Feature]VersionedSpecs{}
|
|
|
|
for name, spec := range features {
|
|
|
|
// if no version is provided for the FeatureSpec, it is defaulted to version 0.0 so that it can be enabled/disabled regardless of emulation version.
|
|
|
|
spec.Version = version.MajorMinor(0, 0)
|
|
|
|
vs[name] = VersionedSpecs{spec}
|
|
|
|
}
|
|
|
|
return f.AddVersioned(vs)
|
|
|
|
}
|
|
|
|
|
|
|
|
// AddVersioned adds versioned feature specs to the featureGate.
|
|
|
|
func (f *featureGate) AddVersioned(features map[Feature]VersionedSpecs) error {
|
2019-06-24 09:08:09 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
|
|
|
|
if f.closed {
|
|
|
|
return fmt.Errorf("cannot add a feature gate after adding it to the flag set")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Copy existing state
|
2024-08-19 08:01:33 +00:00
|
|
|
known := f.GetAllVersioned()
|
2019-06-24 09:08:09 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
for name, specs := range features {
|
|
|
|
sort.Sort(specs)
|
2019-06-24 09:08:09 +00:00
|
|
|
if existingSpec, found := known[name]; found {
|
2024-08-19 08:01:33 +00:00
|
|
|
sort.Sort(existingSpec)
|
|
|
|
if reflect.DeepEqual(existingSpec, specs) {
|
2019-06-24 09:08:09 +00:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
return fmt.Errorf("feature gate %q with different spec already exists: %v", name, existingSpec)
|
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
known[name] = specs
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Persist updated state
|
|
|
|
f.known.Store(known)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2024-05-15 06:54:18 +00:00
|
|
|
func (f *featureGate) OverrideDefault(name Feature, override bool) error {
|
2024-08-19 08:01:33 +00:00
|
|
|
return f.OverrideDefaultAtVersion(name, override, f.EmulationVersion())
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) OverrideDefaultAtVersion(name Feature, override bool, ver *version.Version) error {
|
2024-05-15 06:54:18 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
|
|
|
|
if f.closed {
|
|
|
|
return fmt.Errorf("cannot override default for feature %q: gates already added to a flag set", name)
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// Copy existing state
|
|
|
|
known := f.GetAllVersioned()
|
2024-05-15 06:54:18 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
specs, ok := known[name]
|
|
|
|
if !ok {
|
2024-05-15 06:54:18 +00:00
|
|
|
return fmt.Errorf("cannot override default: feature %q is not registered", name)
|
2024-08-19 08:01:33 +00:00
|
|
|
}
|
|
|
|
spec := featureSpecAtEmulationVersion(specs, ver)
|
|
|
|
switch {
|
2024-05-15 06:54:18 +00:00
|
|
|
case spec.LockToDefault:
|
|
|
|
return fmt.Errorf("cannot override default: feature %q default is locked to %t", name, spec.Default)
|
2024-08-19 08:01:33 +00:00
|
|
|
case spec.PreRelease == PreAlpha:
|
|
|
|
return fmt.Errorf("cannot override default: feature %q is not available before version %s", name, ver.String())
|
2024-05-15 06:54:18 +00:00
|
|
|
case spec.PreRelease == Deprecated:
|
|
|
|
klog.Warningf("Overriding default of deprecated feature gate %s=%t. It will be removed in a future release.", name, override)
|
|
|
|
case spec.PreRelease == GA:
|
|
|
|
klog.Warningf("Overriding default of GA feature gate %s=%t. It will be removed in a future release.", name, override)
|
|
|
|
}
|
|
|
|
|
|
|
|
spec.Default = override
|
2024-08-19 08:01:33 +00:00
|
|
|
known[name] = specs
|
2024-05-15 06:54:18 +00:00
|
|
|
f.known.Store(known)
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// GetAll returns a copy of the map of known feature names to feature specs for the current emulationVersion.
|
2021-08-09 07:19:24 +00:00
|
|
|
func (f *featureGate) GetAll() map[Feature]FeatureSpec {
|
|
|
|
retval := map[Feature]FeatureSpec{}
|
2024-08-19 08:01:33 +00:00
|
|
|
f.lock.Lock()
|
|
|
|
versionedSpecs := f.GetAllVersioned()
|
|
|
|
emuVer := f.EmulationVersion()
|
|
|
|
f.lock.Unlock()
|
|
|
|
for k, v := range versionedSpecs {
|
|
|
|
spec := featureSpecAtEmulationVersion(v, emuVer)
|
|
|
|
if spec.PreRelease == PreAlpha {
|
|
|
|
// The feature is not available at the emulation version.
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
retval[k] = *spec
|
2021-08-09 07:19:24 +00:00
|
|
|
}
|
|
|
|
return retval
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// GetAllVersioned returns a copy of the map of known feature names to versioned feature specs.
|
|
|
|
func (f *featureGate) GetAllVersioned() map[Feature]VersionedSpecs {
|
|
|
|
retval := map[Feature]VersionedSpecs{}
|
|
|
|
for k, v := range f.known.Load().(map[Feature]VersionedSpecs) {
|
|
|
|
vCopy := make([]FeatureSpec, len(v))
|
|
|
|
_ = copy(vCopy, v)
|
|
|
|
retval[k] = vCopy
|
|
|
|
}
|
|
|
|
return retval
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) SetEmulationVersion(emulationVersion *version.Version) error {
|
|
|
|
if emulationVersion.EqualTo(f.EmulationVersion()) {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
klog.V(1).Infof("set feature gate emulationVersion to %s", emulationVersion.String())
|
|
|
|
|
|
|
|
// Copy existing state
|
|
|
|
enabledRaw := map[string]bool{}
|
|
|
|
for k, v := range f.enabledRaw.Load().(map[string]bool) {
|
|
|
|
enabledRaw[k] = v
|
|
|
|
}
|
|
|
|
// enabled map should be reset whenever emulationVersion is changed.
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
errs := f.unsafeSetFromMap(enabled, enabledRaw, emulationVersion)
|
|
|
|
|
|
|
|
queriedFeatures := f.queriedFeatures.Load().(sets.Set[Feature])
|
|
|
|
known := f.known.Load().(map[Feature]VersionedSpecs)
|
|
|
|
for feature := range queriedFeatures {
|
|
|
|
newVal := featureEnabled(feature, enabled, known, emulationVersion)
|
|
|
|
oldVal := featureEnabled(feature, f.enabled.Load().(map[Feature]bool), known, f.EmulationVersion())
|
|
|
|
if newVal != oldVal {
|
|
|
|
klog.Warningf("SetEmulationVersion will change already queried feature:%s from %v to %v", feature, oldVal, newVal)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(errs) == 0 {
|
|
|
|
// Persist changes
|
|
|
|
f.enabled.Store(enabled)
|
|
|
|
f.emulationVersion.Store(emulationVersion)
|
|
|
|
f.queriedFeatures.Store(sets.Set[Feature]{})
|
|
|
|
}
|
|
|
|
return utilerrors.NewAggregate(errs)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) EmulationVersion() *version.Version {
|
|
|
|
return f.emulationVersion.Load()
|
|
|
|
}
|
|
|
|
|
|
|
|
// featureSpec returns the featureSpec at the EmulationVersion if the key exists, an error otherwise.
|
|
|
|
// This is useful to keep multiple implementations of a feature based on the PreRelease or Version info.
|
|
|
|
func (f *featureGate) featureSpec(key Feature) (FeatureSpec, error) {
|
|
|
|
if v, ok := f.known.Load().(map[Feature]VersionedSpecs)[key]; ok {
|
|
|
|
featureSpec := f.featureSpecAtEmulationVersion(v)
|
|
|
|
return *featureSpec, nil
|
|
|
|
}
|
|
|
|
return FeatureSpec{}, fmt.Errorf("feature %q is not registered in FeatureGate %q", key, f.featureGateName)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) unsafeRecordQueried(key Feature) {
|
|
|
|
queriedFeatures := f.queriedFeatures.Load().(sets.Set[Feature])
|
|
|
|
if _, ok := queriedFeatures[key]; ok {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
// Clone items from queriedFeatures before mutating it
|
|
|
|
newQueriedFeatures := queriedFeatures.Clone()
|
|
|
|
newQueriedFeatures.Insert(key)
|
|
|
|
f.queriedFeatures.Store(newQueriedFeatures)
|
|
|
|
}
|
|
|
|
|
|
|
|
func featureEnabled(key Feature, enabled map[Feature]bool, known map[Feature]VersionedSpecs, emulationVersion *version.Version) bool {
|
|
|
|
// check explicitly set enabled list
|
|
|
|
if v, ok := enabled[key]; ok {
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
if v, ok := known[key]; ok {
|
|
|
|
return featureSpecAtEmulationVersion(v, emulationVersion).Default
|
|
|
|
}
|
|
|
|
|
|
|
|
panic(fmt.Errorf("feature %q is not registered in FeatureGate", key))
|
|
|
|
}
|
|
|
|
|
2020-01-14 10:38:55 +00:00
|
|
|
// Enabled returns true if the key is enabled. If the key is not known, this call will panic.
|
2019-06-24 09:08:09 +00:00
|
|
|
func (f *featureGate) Enabled(key Feature) bool {
|
2024-08-19 08:01:33 +00:00
|
|
|
// TODO: ideally we should lock the feature gate in this call to be safe, need to evaluate how much performance impact locking would have.
|
|
|
|
v := featureEnabled(key, f.enabled.Load().(map[Feature]bool), f.known.Load().(map[Feature]VersionedSpecs), f.EmulationVersion())
|
|
|
|
f.unsafeRecordQueried(key)
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *featureGate) featureSpecAtEmulationVersion(v VersionedSpecs) *FeatureSpec {
|
|
|
|
return featureSpecAtEmulationVersion(v, f.EmulationVersion())
|
|
|
|
}
|
|
|
|
|
|
|
|
func featureSpecAtEmulationVersion(v VersionedSpecs, emulationVersion *version.Version) *FeatureSpec {
|
|
|
|
i := len(v) - 1
|
|
|
|
for ; i >= 0; i-- {
|
|
|
|
if v[i].Version.GreaterThan(emulationVersion) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
return &v[i]
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
return &FeatureSpec{
|
|
|
|
Default: false,
|
|
|
|
PreRelease: PreAlpha,
|
|
|
|
Version: version.MajorMinor(0, 0),
|
2020-01-14 10:38:55 +00:00
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
}
|
2020-01-14 10:38:55 +00:00
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// Close sets closed to true, and prevents subsequent calls to Add
|
|
|
|
func (f *featureGate) Close() {
|
|
|
|
f.lock.Lock()
|
|
|
|
f.closed = true
|
|
|
|
f.lock.Unlock()
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// AddFlag adds a flag for setting global feature gates to the specified FlagSet.
|
|
|
|
func (f *featureGate) AddFlag(fs *pflag.FlagSet) {
|
|
|
|
// TODO(mtaufen): Shouldn't we just close it on the first Set/SetFromMap instead?
|
|
|
|
// Not all components expose a feature gates flag using this AddFlag method, and
|
|
|
|
// in the future, all components will completely stop exposing a feature gates flag,
|
|
|
|
// in favor of componentconfig.
|
2024-08-19 08:01:33 +00:00
|
|
|
f.Close()
|
2019-06-24 09:08:09 +00:00
|
|
|
|
|
|
|
known := f.KnownFeatures()
|
|
|
|
fs.Var(f, flagName, ""+
|
|
|
|
"A set of key=value pairs that describe feature gates for alpha/experimental features. "+
|
|
|
|
"Options are:\n"+strings.Join(known, "\n"))
|
|
|
|
}
|
|
|
|
|
2023-02-01 17:06:36 +00:00
|
|
|
func (f *featureGate) AddMetrics() {
|
|
|
|
for feature, featureSpec := range f.GetAll() {
|
|
|
|
featuremetrics.RecordFeatureInfo(context.Background(), string(feature), string(featureSpec.PreRelease), f.Enabled(feature))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
// KnownFeatures returns a slice of strings describing the FeatureGate's known features.
|
2024-08-19 08:01:33 +00:00
|
|
|
// preAlpha, Deprecated and GA features are hidden from the list.
|
2019-06-24 09:08:09 +00:00
|
|
|
func (f *featureGate) KnownFeatures() []string {
|
|
|
|
var known []string
|
2024-08-19 08:01:33 +00:00
|
|
|
for k, v := range f.known.Load().(map[Feature]VersionedSpecs) {
|
|
|
|
if k == "AllAlpha" || k == "AllBeta" {
|
|
|
|
known = append(known, fmt.Sprintf("%s=true|false (%s - default=%t)", k, v[0].PreRelease, v[0].Default))
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
featureSpec := f.featureSpecAtEmulationVersion(v)
|
|
|
|
if featureSpec.PreRelease == GA || featureSpec.PreRelease == Deprecated || featureSpec.PreRelease == PreAlpha {
|
2019-06-24 09:08:09 +00:00
|
|
|
continue
|
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
known = append(known, fmt.Sprintf("%s=true|false (%s - default=%t)", k, featureSpec.PreRelease, featureSpec.Default))
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
|
|
|
sort.Strings(known)
|
|
|
|
return known
|
|
|
|
}
|
|
|
|
|
2024-08-19 08:01:33 +00:00
|
|
|
// DeepCopyAndReset copies all the registered features of the FeatureGate object, with all the known features and overrides,
|
|
|
|
// and resets all the enabled status of the new feature gate.
|
|
|
|
// This is useful for creating a new instance of feature gate without inheriting all the enabled configurations of the base feature gate.
|
|
|
|
func (f *featureGate) DeepCopyAndReset() MutableVersionedFeatureGate {
|
|
|
|
fg := NewVersionedFeatureGate(f.EmulationVersion())
|
|
|
|
known := f.GetAllVersioned()
|
|
|
|
fg.known.Store(known)
|
|
|
|
return fg
|
|
|
|
}
|
|
|
|
|
2019-06-24 09:08:09 +00:00
|
|
|
// DeepCopy returns a deep copy of the FeatureGate object, such that gates can be
|
|
|
|
// set on the copy without mutating the original. This is useful for validating
|
|
|
|
// config against potential feature gate changes before committing those changes.
|
2024-08-19 08:01:33 +00:00
|
|
|
func (f *featureGate) DeepCopy() MutableVersionedFeatureGate {
|
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
2019-06-24 09:08:09 +00:00
|
|
|
// Copy existing state.
|
2024-08-19 08:01:33 +00:00
|
|
|
known := f.GetAllVersioned()
|
2019-06-24 09:08:09 +00:00
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
enabled[k] = v
|
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
enabledRaw := map[string]bool{}
|
|
|
|
for k, v := range f.enabledRaw.Load().(map[string]bool) {
|
|
|
|
enabledRaw[k] = v
|
|
|
|
}
|
2019-06-24 09:08:09 +00:00
|
|
|
|
|
|
|
// Construct a new featureGate around the copied state.
|
|
|
|
// Note that specialFeatures is treated as immutable by convention,
|
|
|
|
// and we maintain the value of f.closed across the copy.
|
2024-05-15 06:54:18 +00:00
|
|
|
fg := &featureGate{
|
2019-06-24 09:08:09 +00:00
|
|
|
special: specialFeatures,
|
|
|
|
closed: f.closed,
|
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
fg.emulationVersion.Store(f.EmulationVersion())
|
2024-05-15 06:54:18 +00:00
|
|
|
fg.known.Store(known)
|
|
|
|
fg.enabled.Store(enabled)
|
2024-08-19 08:01:33 +00:00
|
|
|
fg.enabledRaw.Store(enabledRaw)
|
|
|
|
fg.queriedFeatures.Store(sets.Set[Feature]{})
|
2024-05-15 06:54:18 +00:00
|
|
|
return fg
|
2019-06-24 09:08:09 +00:00
|
|
|
}
|
2024-08-19 08:01:33 +00:00
|
|
|
|
|
|
|
// ExplicitlySet returns true if the feature value is explicitly set instead of
|
|
|
|
// being derived from the default values or special features.
|
|
|
|
func (f *featureGate) ExplicitlySet(name Feature) bool {
|
|
|
|
enabledRaw := f.enabledRaw.Load().(map[string]bool)
|
|
|
|
_, ok := enabledRaw[string(name)]
|
|
|
|
return ok
|
|
|
|
}
|
|
|
|
|
|
|
|
// ResetFeatureValueToDefault resets the value of the feature back to the default value.
|
|
|
|
func (f *featureGate) ResetFeatureValueToDefault(name Feature) error {
|
|
|
|
f.lock.Lock()
|
|
|
|
defer f.lock.Unlock()
|
|
|
|
enabled := map[Feature]bool{}
|
|
|
|
for k, v := range f.enabled.Load().(map[Feature]bool) {
|
|
|
|
enabled[k] = v
|
|
|
|
}
|
|
|
|
enabledRaw := map[string]bool{}
|
|
|
|
for k, v := range f.enabledRaw.Load().(map[string]bool) {
|
|
|
|
enabledRaw[k] = v
|
|
|
|
}
|
|
|
|
_, inEnabled := enabled[name]
|
|
|
|
if inEnabled {
|
|
|
|
delete(enabled, name)
|
|
|
|
}
|
|
|
|
_, inEnabledRaw := enabledRaw[string(name)]
|
|
|
|
if inEnabledRaw {
|
|
|
|
delete(enabledRaw, string(name))
|
|
|
|
}
|
|
|
|
// some features could be in enabled map but not enabledRaw map,
|
|
|
|
// for example some Alpha feature when AllAlpha is set.
|
|
|
|
if inEnabledRaw && !inEnabled {
|
|
|
|
return fmt.Errorf("feature:%s was explicitly set, but not in enabled map", name)
|
|
|
|
}
|
|
|
|
f.enabled.Store(enabled)
|
|
|
|
f.enabledRaw.Store(enabledRaw)
|
|
|
|
return nil
|
|
|
|
}
|