mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-04-11 18:13:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

e2e: Skip() inside a test case causes other cases to be skipped

Browse Source 
The Ginkgo `Skip()` function does not only skip the current `By()`, but
it's parent `It()` function. That means other `By()` tests will not be
run after a `Skip()` was called.

Replacing the `Skip()` with an early return of the function makes sure
that all `By()` tests are executed.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
This commit is contained in:
Niels de Vos 2025-04-03 17:01:24 +02:00 committed by mergify[bot]
parent 25c9c11d23
commit 49d094e3d5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
e2e/rbd.go
View File

@ -5219,7 +5219,8 @@ var _ = Describe("RBD", func() {
framework.Failf("failed to check for VolumeGroupSnapshot support: %v", err)
}
if !supported {
Skip("librbd does not support required VolumeGroupSnapshot function(s)")
framework.Logf("SKIPPING: librbd does not support required VolumeGroupSnapshot function(s)")
return
}
scName := "csi-rbd-sc"